Re: [PATCH v5 0/2] Add device driver for APU2/APU3 GPIOs

2018-12-04 Thread Florian Eckert
>> Yes i will fix your hints tomorrow and send a v6 of my patchset. >> Thank you for your hints and time >> It would be nice if you could fix ACPI problemmatik. > > I would like to see the ACPI dump for that... See https://github.com/openwrt/openwrt/pull/1232#issuecomment-443224576 In this

Re: [PATCH v5 0/2] Add device driver for APU2/APU3 GPIOs

2018-12-04 Thread Florian Eckert
>> Yes i will fix your hints tomorrow and send a v6 of my patchset. >> Thank you for your hints and time >> It would be nice if you could fix ACPI problemmatik. > > I would like to see the ACPI dump for that... See https://github.com/openwrt/openwrt/pull/1232#issuecomment-443224576 In this

Re: [PATCH v5 0/2] Add device driver for APU2/APU3 GPIOs

2018-12-03 Thread Andy Shevchenko
On Mon, Dec 3, 2018 at 9:58 AM Florian Eckert wrote: > >> > Btw, is the statement in above email still actual? "...I can fix > >> > required things." > > > >> Yes i will fix your hints tomorrow and send a v6 of my patchset. > >> Thank you for your hints and time > >> It would be nice if you

Re: [PATCH v5 0/2] Add device driver for APU2/APU3 GPIOs

2018-12-03 Thread Andy Shevchenko
On Mon, Dec 3, 2018 at 9:58 AM Florian Eckert wrote: > >> > Btw, is the statement in above email still actual? "...I can fix > >> > required things." > > > >> Yes i will fix your hints tomorrow and send a v6 of my patchset. > >> Thank you for your hints and time > >> It would be nice if you

Re: [PATCH v5 0/2] Add device driver for APU2/APU3 GPIOs

2018-12-02 Thread Florian Eckert
Hello Andy > Btw, is the statement in above email still actual? "...I can fix > required things." Yes i will fix your hints tomorrow and send a v6 of my patchset. Thank you for your hints and time It would be nice if you could fix ACPI problemmatik. I would like to see the ACPI dump for

Re: [PATCH v5 0/2] Add device driver for APU2/APU3 GPIOs

2018-12-02 Thread Florian Eckert
Hello Andy > Btw, is the statement in above email still actual? "...I can fix > required things." Yes i will fix your hints tomorrow and send a v6 of my patchset. Thank you for your hints and time It would be nice if you could fix ACPI problemmatik. I would like to see the ACPI dump for

Re: [PATCH v5 0/2] Add device driver for APU2/APU3 GPIOs

2018-11-29 Thread Andy Shevchenko
On Thu, Nov 29, 2018 at 4:02 PM Florian Eckert wrote: > > >> Thank you very very much for your code review "again" I will update my > >> patch set with your hints. > >> Should I send v6 or should i wait till I get feedback from you about > >> ACPI? > >> > >> >> > >> >> Until now it was not

Re: [PATCH v5 0/2] Add device driver for APU2/APU3 GPIOs

2018-11-29 Thread Andy Shevchenko
On Thu, Nov 29, 2018 at 4:02 PM Florian Eckert wrote: > > >> Thank you very very much for your code review "again" I will update my > >> patch set with your hints. > >> Should I send v6 or should i wait till I get feedback from you about > >> ACPI? > >> > >> >> > >> >> Until now it was not

Re: [PATCH v5 0/2] Add device driver for APU2/APU3 GPIOs

2018-11-29 Thread Florian Eckert
Thank you very very much for your code review "again" I will update my patch set with your hints. Should I send v6 or should i wait till I get feedback from you about ACPI? >> >> Until now it was not possible to get more information to detect the >> MMIO_BASE address from the ACPI subsystem. > >

Re: [PATCH v5 0/2] Add device driver for APU2/APU3 GPIOs

2018-11-29 Thread Florian Eckert
Thank you very very much for your code review "again" I will update my patch set with your hints. Should I send v6 or should i wait till I get feedback from you about ACPI? >> >> Until now it was not possible to get more information to detect the >> MMIO_BASE address from the ACPI subsystem. > >

Re: [PATCH v5 0/2] Add device driver for APU2/APU3 GPIOs

2018-11-29 Thread Andy Shevchenko
On Thu, Nov 29, 2018 at 12:15 PM Florian Eckert wrote: > > Hello Andy, > > Thank you very very much for your code review "again" I will update my > patch set with your hints. > Should I send v6 or should i wait till I get feedback from you about > ACPI? > > >> > >> Until now it was not possible

Re: [PATCH v5 0/2] Add device driver for APU2/APU3 GPIOs

2018-11-29 Thread Andy Shevchenko
On Thu, Nov 29, 2018 at 12:15 PM Florian Eckert wrote: > > Hello Andy, > > Thank you very very much for your code review "again" I will update my > patch set with your hints. > Should I send v6 or should i wait till I get feedback from you about > ACPI? > > >> > >> Until now it was not possible

Re: [PATCH v5 0/2] Add device driver for APU2/APU3 GPIOs

2018-11-29 Thread Florian Eckert
Hello Andy, Thank you very very much for your code review "again" I will update my patch set with your hints. Should I send v6 or should i wait till I get feedback from you about ACPI? Until now it was not possible to get more information to detect the MMIO_BASE address from the ACPI

Re: [PATCH v5 0/2] Add device driver for APU2/APU3 GPIOs

2018-11-29 Thread Florian Eckert
Hello Andy, Thank you very very much for your code review "again" I will update my patch set with your hints. Should I send v6 or should i wait till I get feedback from you about ACPI? Until now it was not possible to get more information to detect the MMIO_BASE address from the ACPI

Re: [PATCH v5 0/2] Add device driver for APU2/APU3 GPIOs

2018-11-28 Thread Andy Shevchenko
On Tue, Nov 27, 2018 at 3:25 PM Florian Eckert wrote: > Changes v5: > gpio-apu.c > - Remove GPIO_GENERIC select from Kconfig > - Make gpio_chip real member of apu_gpio_pdata > - Use BIT macro for get_data and get_dir functions > - Pass platform data to devm_gpiochip_add_data to get data >

Re: [PATCH v5 0/2] Add device driver for APU2/APU3 GPIOs

2018-11-28 Thread Andy Shevchenko
On Tue, Nov 27, 2018 at 3:25 PM Florian Eckert wrote: > Changes v5: > gpio-apu.c > - Remove GPIO_GENERIC select from Kconfig > - Make gpio_chip real member of apu_gpio_pdata > - Use BIT macro for get_data and get_dir functions > - Pass platform data to devm_gpiochip_add_data to get data >

[PATCH v5 0/2] Add device driver for APU2/APU3 GPIOs

2018-11-27 Thread Florian Eckert
Changes v2: - Update SPDX short identifier - Remove gpio-keys-polled device moved to arch/x86/platform - Fix styling - Use spinnlock only there where it is useful - Removed useless output on driver load - Do bit manipulation later not on IO - Add additional GPIOs handling mpci2_reset and

[PATCH v5 0/2] Add device driver for APU2/APU3 GPIOs

2018-11-27 Thread Florian Eckert
Changes v2: - Update SPDX short identifier - Remove gpio-keys-polled device moved to arch/x86/platform - Fix styling - Use spinnlock only there where it is useful - Removed useless output on driver load - Do bit manipulation later not on IO - Add additional GPIOs handling mpci2_reset and