Re: [PATCH v5 02/20] perf: Add AUX area to ring buffer for raw data streams

2014-10-22 Thread Frederic Weisbecker
On Wed, Oct 22, 2014 at 02:35:47PM +0200, Peter Zijlstra wrote: > On Mon, Oct 13, 2014 at 04:45:30PM +0300, Alexander Shishkin wrote: > > + struct kref aux_refcount; > > I'm not a fan of kref, pointless obfuscation that. It has a good potential for debugging though. Sure

Re: [PATCH v5 02/20] perf: Add AUX area to ring buffer for raw data streams

2014-10-22 Thread Peter Zijlstra
On Mon, Oct 13, 2014 at 04:45:30PM +0300, Alexander Shishkin wrote: > + struct kref aux_refcount; I'm not a fan of kref, pointless obfuscation that. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH v5 02/20] perf: Add AUX area to ring buffer for raw data streams

2014-10-22 Thread Frederic Weisbecker
On Wed, Oct 22, 2014 at 02:35:47PM +0200, Peter Zijlstra wrote: On Mon, Oct 13, 2014 at 04:45:30PM +0300, Alexander Shishkin wrote: + struct kref aux_refcount; I'm not a fan of kref, pointless obfuscation that. It has a good potential for debugging though. Sure right

Re: [PATCH v5 02/20] perf: Add AUX area to ring buffer for raw data streams

2014-10-22 Thread Peter Zijlstra
On Mon, Oct 13, 2014 at 04:45:30PM +0300, Alexander Shishkin wrote: + struct kref aux_refcount; I'm not a fan of kref, pointless obfuscation that. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

[PATCH v5 02/20] perf: Add AUX area to ring buffer for raw data streams

2014-10-13 Thread Alexander Shishkin
From: Peter Zijlstra This patch introduces "AUX space" in the perf mmap buffer, intended for exporting high bandwidth data streams to userspace, such as instruction flow traces. AUX space is a ring buffer, defined by aux_{offset,size} fields in the user_page structure, and read/write pointers

[PATCH v5 02/20] perf: Add AUX area to ring buffer for raw data streams

2014-10-13 Thread Alexander Shishkin
From: Peter Zijlstra pet...@infradead.org This patch introduces AUX space in the perf mmap buffer, intended for exporting high bandwidth data streams to userspace, such as instruction flow traces. AUX space is a ring buffer, defined by aux_{offset,size} fields in the user_page structure, and