Re: [PATCH v5 09/10] PCI: dwc: Small computation improvement

2018-04-17 Thread Joao Pinto
Às 3:34 PM de 4/17/2018, Gustavo Pimentel escreveu: > Replaces a simple division by 2 to a right shift rotation of 1 bit. > > Probably any recent and decent compiler does this kind of substitution > in order to improve code performance. Nevertheless it's a coding good > practice whenever there is

Re: [PATCH v5 09/10] PCI: dwc: Small computation improvement

2018-04-17 Thread Joao Pinto
Às 3:34 PM de 4/17/2018, Gustavo Pimentel escreveu: > Replaces a simple division by 2 to a right shift rotation of 1 bit. > > Probably any recent and decent compiler does this kind of substitution > in order to improve code performance. Nevertheless it's a coding good > practice whenever there is

[PATCH v5 09/10] PCI: dwc: Small computation improvement

2018-04-17 Thread Gustavo Pimentel
Replaces a simple division by 2 to a right shift rotation of 1 bit. Probably any recent and decent compiler does this kind of substitution in order to improve code performance. Nevertheless it's a coding good practice whenever there is a division / multiplication by multiple of 2 to replace it by

[PATCH v5 09/10] PCI: dwc: Small computation improvement

2018-04-17 Thread Gustavo Pimentel
Replaces a simple division by 2 to a right shift rotation of 1 bit. Probably any recent and decent compiler does this kind of substitution in order to improve code performance. Nevertheless it's a coding good practice whenever there is a division / multiplication by multiple of 2 to replace it by

Re: [PATCH v5 09/10] PCI: dwc: Small computation improvement

2018-04-17 Thread Jingoo Han
On Tuesday, April 17, 2018 10:34 AM, Gustavo Pimentel wrote: > > Replaces a simple division by 2 to a right shift rotation of 1 bit. > > Probably any recent and decent compiler does this kind of substitution > in order to improve code performance. Nevertheless it's a coding good > practice

Re: [PATCH v5 09/10] PCI: dwc: Small computation improvement

2018-04-17 Thread Jingoo Han
On Tuesday, April 17, 2018 10:34 AM, Gustavo Pimentel wrote: > > Replaces a simple division by 2 to a right shift rotation of 1 bit. > > Probably any recent and decent compiler does this kind of substitution > in order to improve code performance. Nevertheless it's a coding good > practice