Re: [PATCH v5 1/5] perf metric: Restructure struct expr_parse_ctx.

2020-12-07 Thread Namhyung Kim
Hi Ian, On Wed, Dec 2, 2020 at 4:40 PM Ian Rogers wrote: > > A later change to parsing the ids out (in expr__find_other) will > potentially drop hashmaps and so it is more convenient to move > expr_parse_ctx to have a hashmap pointer rather than a struct value. As > this pointer must be freed,

[PATCH v5 1/5] perf metric: Restructure struct expr_parse_ctx.

2020-12-01 Thread Ian Rogers
A later change to parsing the ids out (in expr__find_other) will potentially drop hashmaps and so it is more convenient to move expr_parse_ctx to have a hashmap pointer rather than a struct value. As this pointer must be freed, rather than just going out of scope, add expr__ctx_new and