Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-13 Thread Wanpeng Li
2016-06-13 15:55 GMT+08:00 Paolo Bonzini : > > > On 13/06/2016 05:38, Wanpeng Li wrote: >> + delta_jiffies = jiffies_to_cputime(now - tsk->vtime_snap); >> + steal_jiffies = >> jiffies_to_cputime(steal_account_process_tick(delta_jiffies)); > > Without jiffies_to_cputime here.

Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-13 Thread Wanpeng Li
2016-06-13 15:55 GMT+08:00 Paolo Bonzini : > > > On 13/06/2016 05:38, Wanpeng Li wrote: >> + delta_jiffies = jiffies_to_cputime(now - tsk->vtime_snap); >> + steal_jiffies = >> jiffies_to_cputime(steal_account_process_tick(delta_jiffies)); > > Without jiffies_to_cputime here. Apart from this,

Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-13 Thread Paolo Bonzini
On 13/06/2016 05:38, Wanpeng Li wrote: > + delta_jiffies = jiffies_to_cputime(now - tsk->vtime_snap); > + steal_jiffies = > jiffies_to_cputime(steal_account_process_tick(delta_jiffies)); Without jiffies_to_cputime here. Apart from this, yes, this is what I meant. Paolo >

Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-13 Thread Paolo Bonzini
On 13/06/2016 05:38, Wanpeng Li wrote: > + delta_jiffies = jiffies_to_cputime(now - tsk->vtime_snap); > + steal_jiffies = > jiffies_to_cputime(steal_account_process_tick(delta_jiffies)); Without jiffies_to_cputime here. Apart from this, yes, this is what I meant. Paolo >

Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-12 Thread Wanpeng Li
2016-06-08 18:14 GMT+08:00 Paolo Bonzini : > > > On 08/06/2016 05:05, Wanpeng Li wrote: >> From: Wanpeng Li >> >> This patch adds guest steal-time support to full dynticks CPU >> time accounting. After the following commit: >> >> ff9a9b4c4334 ("sched,

Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-12 Thread Wanpeng Li
2016-06-08 18:14 GMT+08:00 Paolo Bonzini : > > > On 08/06/2016 05:05, Wanpeng Li wrote: >> From: Wanpeng Li >> >> This patch adds guest steal-time support to full dynticks CPU >> time accounting. After the following commit: >> >> ff9a9b4c4334 ("sched, time: Switch VIRT_CPU_ACCOUNTING_GEN to jiffy

Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-08 Thread Rik van Riel
On Thu, 2016-06-09 at 07:57 +0800, Wanpeng Li wrote: > 2016-06-09 3:05 GMT+08:00 Rik van Riel : > > > > On Wed, 2016-06-08 at 11:05 +0800, Wanpeng Li wrote: > > > > > > > > > @@ -681,12 +681,17 @@ static cputime_t vtime_delta(struct > > > task_struct > > > *tsk) > > >  static

Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-08 Thread Rik van Riel
On Thu, 2016-06-09 at 07:57 +0800, Wanpeng Li wrote: > 2016-06-09 3:05 GMT+08:00 Rik van Riel : > > > > On Wed, 2016-06-08 at 11:05 +0800, Wanpeng Li wrote: > > > > > > > > > @@ -681,12 +681,17 @@ static cputime_t vtime_delta(struct > > > task_struct > > > *tsk) > > >  static cputime_t

Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-08 Thread Wanpeng Li
2016-06-09 3:05 GMT+08:00 Rik van Riel : > On Wed, 2016-06-08 at 11:05 +0800, Wanpeng Li wrote: >> >> @@ -681,12 +681,17 @@ static cputime_t vtime_delta(struct task_struct >> *tsk) >> static cputime_t get_vtime_delta(struct task_struct *tsk) >> { >> unsigned long now =

Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-08 Thread Wanpeng Li
2016-06-09 3:05 GMT+08:00 Rik van Riel : > On Wed, 2016-06-08 at 11:05 +0800, Wanpeng Li wrote: >> >> @@ -681,12 +681,17 @@ static cputime_t vtime_delta(struct task_struct >> *tsk) >> static cputime_t get_vtime_delta(struct task_struct *tsk) >> { >> unsigned long now = READ_ONCE(jiffies);

Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-08 Thread Rik van Riel
On Wed, 2016-06-08 at 11:05 +0800, Wanpeng Li wrote: >  > @@ -681,12 +681,17 @@ static cputime_t vtime_delta(struct task_struct > *tsk) >  static cputime_t get_vtime_delta(struct task_struct *tsk) >  { >   unsigned long now = READ_ONCE(jiffies); > - unsigned long delta = now -

Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-08 Thread Rik van Riel
On Wed, 2016-06-08 at 11:05 +0800, Wanpeng Li wrote: >  > @@ -681,12 +681,17 @@ static cputime_t vtime_delta(struct task_struct > *tsk) >  static cputime_t get_vtime_delta(struct task_struct *tsk) >  { >   unsigned long now = READ_ONCE(jiffies); > - unsigned long delta = now -

Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-08 Thread Wanpeng Li
2016-06-08 18:14 GMT+08:00 Paolo Bonzini : > > > On 08/06/2016 05:05, Wanpeng Li wrote: >> From: Wanpeng Li >> >> This patch adds guest steal-time support to full dynticks CPU >> time accounting. After the following commit: >> >> ff9a9b4c4334 ("sched,

Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-08 Thread Wanpeng Li
2016-06-08 18:14 GMT+08:00 Paolo Bonzini : > > > On 08/06/2016 05:05, Wanpeng Li wrote: >> From: Wanpeng Li >> >> This patch adds guest steal-time support to full dynticks CPU >> time accounting. After the following commit: >> >> ff9a9b4c4334 ("sched, time: Switch VIRT_CPU_ACCOUNTING_GEN to jiffy

Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-08 Thread Paolo Bonzini
On 08/06/2016 05:05, Wanpeng Li wrote: > From: Wanpeng Li > > This patch adds guest steal-time support to full dynticks CPU > time accounting. After the following commit: > > ff9a9b4c4334 ("sched, time: Switch VIRT_CPU_ACCOUNTING_GEN to jiffy > granularity") > > ...

Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-08 Thread Paolo Bonzini
On 08/06/2016 05:05, Wanpeng Li wrote: > From: Wanpeng Li > > This patch adds guest steal-time support to full dynticks CPU > time accounting. After the following commit: > > ff9a9b4c4334 ("sched, time: Switch VIRT_CPU_ACCOUNTING_GEN to jiffy > granularity") > > ... time sampling became

Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-08 Thread Wanpeng Li
2016-06-08 16:04 GMT+08:00 Wanpeng Li : > 2016-06-08 15:52 GMT+08:00 Ingo Molnar : >> >> * Wanpeng Li wrote: >> >>> 2016-06-08 15:22 GMT+08:00 Ingo Molnar : >>> > >>> > * Wanpeng Li wrote: >>> >

Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-08 Thread Wanpeng Li
2016-06-08 16:04 GMT+08:00 Wanpeng Li : > 2016-06-08 15:52 GMT+08:00 Ingo Molnar : >> >> * Wanpeng Li wrote: >> >>> 2016-06-08 15:22 GMT+08:00 Ingo Molnar : >>> > >>> > * Wanpeng Li wrote: >>> > >>> >> From: Wanpeng Li >>> >> >>> >> This patch adds guest steal-time support to full dynticks CPU

Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-08 Thread Wanpeng Li
2016-06-08 15:52 GMT+08:00 Ingo Molnar : > > * Wanpeng Li wrote: > >> 2016-06-08 15:22 GMT+08:00 Ingo Molnar : >> > >> > * Wanpeng Li wrote: >> > >> >> From: Wanpeng Li >> >> >> >> This patch

Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-08 Thread Wanpeng Li
2016-06-08 15:52 GMT+08:00 Ingo Molnar : > > * Wanpeng Li wrote: > >> 2016-06-08 15:22 GMT+08:00 Ingo Molnar : >> > >> > * Wanpeng Li wrote: >> > >> >> From: Wanpeng Li >> >> >> >> This patch adds guest steal-time support to full dynticks CPU >> >> time accounting. After the following commit:

Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-08 Thread Ingo Molnar
* Wanpeng Li wrote: > 2016-06-08 15:22 GMT+08:00 Ingo Molnar : > > > > * Wanpeng Li wrote: > > > >> From: Wanpeng Li > >> > >> This patch adds guest steal-time support to full dynticks CPU > >> time

Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-08 Thread Ingo Molnar
* Wanpeng Li wrote: > 2016-06-08 15:22 GMT+08:00 Ingo Molnar : > > > > * Wanpeng Li wrote: > > > >> From: Wanpeng Li > >> > >> This patch adds guest steal-time support to full dynticks CPU > >> time accounting. After the following commit: > >> > >> ff9a9b4c4334 ("sched, time: Switch

Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-08 Thread Wanpeng Li
2016-06-08 15:22 GMT+08:00 Ingo Molnar : > > * Wanpeng Li wrote: > >> From: Wanpeng Li >> >> This patch adds guest steal-time support to full dynticks CPU >> time accounting. After the following commit: >> >> ff9a9b4c4334 ("sched,

Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-08 Thread Wanpeng Li
2016-06-08 15:22 GMT+08:00 Ingo Molnar : > > * Wanpeng Li wrote: > >> From: Wanpeng Li >> >> This patch adds guest steal-time support to full dynticks CPU >> time accounting. After the following commit: >> >> ff9a9b4c4334 ("sched, time: Switch VIRT_CPU_ACCOUNTING_GEN to jiffy >> granularity")

Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-08 Thread Ingo Molnar
* Wanpeng Li wrote: > From: Wanpeng Li > > This patch adds guest steal-time support to full dynticks CPU > time accounting. After the following commit: > > ff9a9b4c4334 ("sched, time: Switch VIRT_CPU_ACCOUNTING_GEN to jiffy > granularity") > >

Re: [PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-08 Thread Ingo Molnar
* Wanpeng Li wrote: > From: Wanpeng Li > > This patch adds guest steal-time support to full dynticks CPU > time accounting. After the following commit: > > ff9a9b4c4334 ("sched, time: Switch VIRT_CPU_ACCOUNTING_GEN to jiffy > granularity") > > ... time sampling became jiffy based, even if

[PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-07 Thread Wanpeng Li
From: Wanpeng Li This patch adds guest steal-time support to full dynticks CPU time accounting. After the following commit: ff9a9b4c4334 ("sched, time: Switch VIRT_CPU_ACCOUNTING_GEN to jiffy granularity") ... time sampling became jiffy based, even if it's still

[PATCH v5 3/3] sched/cputime: Add steal time support to full dynticks CPU time accounting

2016-06-07 Thread Wanpeng Li
From: Wanpeng Li This patch adds guest steal-time support to full dynticks CPU time accounting. After the following commit: ff9a9b4c4334 ("sched, time: Switch VIRT_CPU_ACCOUNTING_GEN to jiffy granularity") ... time sampling became jiffy based, even if it's still listened to ring boundaries,