Re: [PATCH v6 03/14] videobuf2: handle V4L2 buffer cache flags

2020-06-03 Thread Sergey Senozhatsky
On (20/06/02 14:24), Hans Verkuil wrote: [..] > For vim2m (but looks the same for vivid/vimc/vicodec): > > Streaming ioctls: > test read/write: OK (Not Supported) > test blocking wait: OK > Video Capture: Captured 8 buffers > test MMAP (no poll): OK > Video

Re: [PATCH v6 03/14] videobuf2: handle V4L2 buffer cache flags

2020-06-02 Thread Hans Verkuil
On 02/06/2020 14:22, Tomasz Figa wrote: > Hi Hans, > > On Tue, Jun 2, 2020 at 11:51 AM Hans Verkuil wrote: >> >> Hi Sergey, >> >> While doing final testing for this patch series (together with the v4l-utils >> patch) >> I found one remaining issue: >> >> On 14/05/2020 18:01, Sergey Senozhatsky

Re: [PATCH v6 03/14] videobuf2: handle V4L2 buffer cache flags

2020-06-02 Thread Tomasz Figa
Hi Hans, On Tue, Jun 2, 2020 at 11:51 AM Hans Verkuil wrote: > > Hi Sergey, > > While doing final testing for this patch series (together with the v4l-utils > patch) > I found one remaining issue: > > On 14/05/2020 18:01, Sergey Senozhatsky wrote: > > From: Sergey Senozhatsky > > > > Set video

Re: [PATCH v6 03/14] videobuf2: handle V4L2 buffer cache flags

2020-06-02 Thread Hans Verkuil
On 02/06/2020 14:10, Sergey Senozhatsky wrote: > On (20/06/02 12:27), Hans Verkuil wrote: > [..] >>> Sorry, Hans, do you suggest to have something like this: >>> >>> if (q->memory == VB2_MEMORY_DMABUF) { >>> vb->need_cache_sync_on_finish = 0; >>>

Re: [PATCH v6 03/14] videobuf2: handle V4L2 buffer cache flags

2020-06-02 Thread Sergey Senozhatsky
On (20/06/02 12:27), Hans Verkuil wrote: [..] > > Sorry, Hans, do you suggest to have something like this: > > > > if (q->memory == VB2_MEMORY_DMABUF) { > > vb->need_cache_sync_on_finish = 0; > > vb->need_cache_sync_on_prepare = 0; > > b->flags &=

Re: [PATCH v6 03/14] videobuf2: handle V4L2 buffer cache flags

2020-06-02 Thread Hans Verkuil
On 02/06/2020 12:18, Sergey Senozhatsky wrote: > Hi Hans, > > On (20/06/02 11:51), Hans Verkuil wrote: >> Hi Sergey, >> >> While doing final testing for this patch series (together with the v4l-utils >> patch) >> I found one remaining issue: > > Thanks for the report. > >>> +static void

Re: [PATCH v6 03/14] videobuf2: handle V4L2 buffer cache flags

2020-06-02 Thread Sergey Senozhatsky
Hi Hans, On (20/06/02 11:51), Hans Verkuil wrote: > Hi Sergey, > > While doing final testing for this patch series (together with the v4l-utils > patch) > I found one remaining issue: Thanks for the report. > > +static void set_buffer_cache_hints(struct vb2_queue *q, > > +

Re: [PATCH v6 03/14] videobuf2: handle V4L2 buffer cache flags

2020-06-02 Thread Hans Verkuil
Hi Sergey, While doing final testing for this patch series (together with the v4l-utils patch) I found one remaining issue: On 14/05/2020 18:01, Sergey Senozhatsky wrote: > From: Sergey Senozhatsky > > Set video buffer cache management flags corresponding to V4L2 cache > flags. > > Both

[PATCH v6 03/14] videobuf2: handle V4L2 buffer cache flags

2020-05-14 Thread Sergey Senozhatsky
From: Sergey Senozhatsky Set video buffer cache management flags corresponding to V4L2 cache flags. Both ->prepare() and ->finish() cache management hints should be passed during this stage (buffer preparation), because there is no other way for user-space to tell V4L2 to avoid ->finish() cache