Re: [PATCH v6 19/27] x86, boot: update comments about entries for 64bit image

2012-12-13 Thread Yinghai Lu
On Thu, Dec 13, 2012 at 3:27 PM, H. Peter Anvin wrote: > if we depend on other > things we should make that explicit, not just here but in boot.txt. please check lines for boot.txt --- 64-bit BOOT PROTOCOL For machine with 64bit cpus and 64bit kernel, we could use 64bit bootloader We

Re: [PATCH v6 19/27] x86, boot: update comments about entries for 64bit image

2012-12-13 Thread H. Peter Anvin
On 12/13/2012 05:00 PM, Yinghai Lu wrote: > On Thu, Dec 13, 2012 at 4:54 PM, H. Peter Anvin wrote: >> On 12/13/2012 04:51 PM, Yinghai Lu wrote: > >>> also need to make sure zero page and command line get ident mapping. >>> because arch/x86/boot/compressed/head_64.S is using them. >>> >> >> ...

Re: [PATCH v6 19/27] x86, boot: update comments about entries for 64bit image

2012-12-13 Thread Yinghai Lu
On Thu, Dec 13, 2012 at 4:54 PM, H. Peter Anvin wrote: > On 12/13/2012 04:51 PM, Yinghai Lu wrote: >> also need to make sure zero page and command line get ident mapping. >> because arch/x86/boot/compressed/head_64.S is using them. >> > > ... or we need to do the same kind of thing there. > your

Re: [PATCH v6 19/27] x86, boot: update comments about entries for 64bit image

2012-12-13 Thread H. Peter Anvin
On 12/13/2012 04:51 PM, Yinghai Lu wrote: On Thu, Dec 13, 2012 at 4:44 PM, Yinghai Lu wrote: On Thu, Dec 13, 2012 at 4:38 PM, H. Peter Anvin wrote: On 12/13/2012 04:13 PM, Yinghai Lu wrote: It is definitely the minmum we can rely on, and so is the minimum we should rely on. In fact, we

Re: [PATCH v6 19/27] x86, boot: update comments about entries for 64bit image

2012-12-13 Thread Yinghai Lu
On Thu, Dec 13, 2012 at 4:44 PM, Yinghai Lu wrote: > On Thu, Dec 13, 2012 at 4:38 PM, H. Peter Anvin wrote: >> On 12/13/2012 04:13 PM, Yinghai Lu wrote: >> >> It is definitely the minmum we can rely on, and so is the minimum we should >> rely on. In fact, we don't even need .bss/.brk to be

Re: [PATCH v6 19/27] x86, boot: update comments about entries for 64bit image

2012-12-13 Thread H. Peter Anvin
On 12/13/2012 04:44 PM, Yinghai Lu wrote: On Thu, Dec 13, 2012 at 4:38 PM, H. Peter Anvin wrote: On 12/13/2012 04:13 PM, Yinghai Lu wrote: It is definitely the minmum we can rely on, and so is the minimum we should rely on. In fact, we don't even need .bss/.brk to be mapped, but we probably

Re: [PATCH v6 19/27] x86, boot: update comments about entries for 64bit image

2012-12-13 Thread Yinghai Lu
On Thu, Dec 13, 2012 at 4:38 PM, H. Peter Anvin wrote: > On 12/13/2012 04:13 PM, Yinghai Lu wrote: > > It is definitely the minmum we can rely on, and so is the minimum we should > rely on. In fact, we don't even need .bss/.brk to be mapped, but we > probably should require that as a matter of

Re: [PATCH v6 19/27] x86, boot: update comments about entries for 64bit image

2012-12-13 Thread H. Peter Anvin
On 12/13/2012 04:13 PM, Yinghai Lu wrote: On Thu, Dec 13, 2012 at 3:27 PM, H. Peter Anvin wrote: On 12/13/2012 02:02 PM, Yinghai Lu wrote: + * If we come here from a bootloader, kernel(text+data+bss+brk), + * ramdisk, zero_page, command line could be above 4G. + * We depend on

Re: [PATCH v6 19/27] x86, boot: update comments about entries for 64bit image

2012-12-13 Thread Yinghai Lu
On Thu, Dec 13, 2012 at 3:27 PM, H. Peter Anvin wrote: > On 12/13/2012 02:02 PM, Yinghai Lu wrote: >> + * If we come here from a bootloader, kernel(text+data+bss+brk), >> + * ramdisk, zero_page, command line could be above 4G. >> + * We depend on an identity mapped page table being

Re: [PATCH v6 19/27] x86, boot: update comments about entries for 64bit image

2012-12-13 Thread H. Peter Anvin
On 12/13/2012 02:02 PM, Yinghai Lu wrote: > + * If we come here from a bootloader, kernel(text+data+bss+brk), > + * ramdisk, zero_page, command line could be above 4G. > + * We depend on an identity mapped page table being provided > + * that maps our entire

[PATCH v6 19/27] x86, boot: update comments about entries for 64bit image

2012-12-13 Thread Yinghai Lu
Now 64bit entry is fixed on 0x200, can not be changed anymore. Update the comments to reflect that. Signed-off-by: Yinghai Lu --- arch/x86/boot/compressed/head_64.S | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/arch/x86/boot/compressed/head_64.S

[PATCH v6 19/27] x86, boot: update comments about entries for 64bit image

2012-12-13 Thread Yinghai Lu
Now 64bit entry is fixed on 0x200, can not be changed anymore. Update the comments to reflect that. Signed-off-by: Yinghai Lu ying...@kernel.org --- arch/x86/boot/compressed/head_64.S | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git

Re: [PATCH v6 19/27] x86, boot: update comments about entries for 64bit image

2012-12-13 Thread H. Peter Anvin
On 12/13/2012 02:02 PM, Yinghai Lu wrote: + * If we come here from a bootloader, kernel(text+data+bss+brk), + * ramdisk, zero_page, command line could be above 4G. + * We depend on an identity mapped page table being provided + * that maps our entire

Re: [PATCH v6 19/27] x86, boot: update comments about entries for 64bit image

2012-12-13 Thread Yinghai Lu
On Thu, Dec 13, 2012 at 3:27 PM, H. Peter Anvin h...@zytor.com wrote: On 12/13/2012 02:02 PM, Yinghai Lu wrote: + * If we come here from a bootloader, kernel(text+data+bss+brk), + * ramdisk, zero_page, command line could be above 4G. + * We depend on an identity mapped page

Re: [PATCH v6 19/27] x86, boot: update comments about entries for 64bit image

2012-12-13 Thread H. Peter Anvin
On 12/13/2012 04:13 PM, Yinghai Lu wrote: On Thu, Dec 13, 2012 at 3:27 PM, H. Peter Anvin h...@zytor.com wrote: On 12/13/2012 02:02 PM, Yinghai Lu wrote: + * If we come here from a bootloader, kernel(text+data+bss+brk), + * ramdisk, zero_page, command line could be above 4G. + *

Re: [PATCH v6 19/27] x86, boot: update comments about entries for 64bit image

2012-12-13 Thread Yinghai Lu
On Thu, Dec 13, 2012 at 4:38 PM, H. Peter Anvin h...@zytor.com wrote: On 12/13/2012 04:13 PM, Yinghai Lu wrote: It is definitely the minmum we can rely on, and so is the minimum we should rely on. In fact, we don't even need .bss/.brk to be mapped, but we probably should require that as a

Re: [PATCH v6 19/27] x86, boot: update comments about entries for 64bit image

2012-12-13 Thread H. Peter Anvin
On 12/13/2012 04:44 PM, Yinghai Lu wrote: On Thu, Dec 13, 2012 at 4:38 PM, H. Peter Anvin h...@zytor.com wrote: On 12/13/2012 04:13 PM, Yinghai Lu wrote: It is definitely the minmum we can rely on, and so is the minimum we should rely on. In fact, we don't even need .bss/.brk to be mapped,

Re: [PATCH v6 19/27] x86, boot: update comments about entries for 64bit image

2012-12-13 Thread Yinghai Lu
On Thu, Dec 13, 2012 at 4:44 PM, Yinghai Lu ying...@kernel.org wrote: On Thu, Dec 13, 2012 at 4:38 PM, H. Peter Anvin h...@zytor.com wrote: On 12/13/2012 04:13 PM, Yinghai Lu wrote: It is definitely the minmum we can rely on, and so is the minimum we should rely on. In fact, we don't even

Re: [PATCH v6 19/27] x86, boot: update comments about entries for 64bit image

2012-12-13 Thread H. Peter Anvin
On 12/13/2012 04:51 PM, Yinghai Lu wrote: On Thu, Dec 13, 2012 at 4:44 PM, Yinghai Lu ying...@kernel.org wrote: On Thu, Dec 13, 2012 at 4:38 PM, H. Peter Anvin h...@zytor.com wrote: On 12/13/2012 04:13 PM, Yinghai Lu wrote: It is definitely the minmum we can rely on, and so is the minimum we

Re: [PATCH v6 19/27] x86, boot: update comments about entries for 64bit image

2012-12-13 Thread Yinghai Lu
On Thu, Dec 13, 2012 at 4:54 PM, H. Peter Anvin h...@zytor.com wrote: On 12/13/2012 04:51 PM, Yinghai Lu wrote: also need to make sure zero page and command line get ident mapping. because arch/x86/boot/compressed/head_64.S is using them. ... or we need to do the same kind of thing there.

Re: [PATCH v6 19/27] x86, boot: update comments about entries for 64bit image

2012-12-13 Thread H. Peter Anvin
On 12/13/2012 05:00 PM, Yinghai Lu wrote: On Thu, Dec 13, 2012 at 4:54 PM, H. Peter Anvin h...@zytor.com wrote: On 12/13/2012 04:51 PM, Yinghai Lu wrote: also need to make sure zero page and command line get ident mapping. because arch/x86/boot/compressed/head_64.S is using them. ... or

Re: [PATCH v6 19/27] x86, boot: update comments about entries for 64bit image

2012-12-13 Thread Yinghai Lu
On Thu, Dec 13, 2012 at 3:27 PM, H. Peter Anvin h...@zytor.com wrote: if we depend on other things we should make that explicit, not just here but in boot.txt. please check lines for boot.txt --- 64-bit BOOT PROTOCOL For machine with 64bit cpus and 64bit kernel, we could use 64bit