Re: [PATCH v6 2/5] i2c: Add STM32F4 I2C driver

> I thought (but I could be wrong) that if the driver is called > "stm32f4-i2c", it is used to match "st,stm32f4-i2c" even without > .of_match_table. If this doesn't work, please disregard my question. This currently works only for *i2c client drivers*, it never did for i2c adapters. And even

Re: [PATCH v6 2/5] i2c: Add STM32F4 I2C driver

> I thought (but I could be wrong) that if the driver is called > "stm32f4-i2c", it is used to match "st,stm32f4-i2c" even without > .of_match_table. If this doesn't work, please disregard my question. This currently works only for *i2c client drivers*, it never did for i2c adapters. And even

Re: [PATCH v6 2/5] i2c: Add STM32F4 I2C driver

> > + if (ret) { > > + dev_err(i2c_dev->dev, "bus not free\n"); > > + ret = -EBUSY; > > I'm not sure if "bus not free" deserves an error message. Wolfram? I tend to agree. But I never enforced it up to now, never found the time to double check if I could/should enforce it.

Re: [PATCH v6 2/5] i2c: Add STM32F4 I2C driver

> > + if (ret) { > > + dev_err(i2c_dev->dev, "bus not free\n"); > > + ret = -EBUSY; > > I'm not sure if "bus not free" deserves an error message. Wolfram? I tend to agree. But I never enforced it up to now, never found the time to double check if I could/should enforce it.

Re: [PATCH v6 2/5] i2c: Add STM32F4 I2C driver

Hello Cedric, On Thu, Dec 15, 2016 at 04:26:25PM +0100, M'boumba Cedric Madianga wrote: > >> +static struct platform_driver stm32f4_i2c_driver = { > >> + .driver = { > >> + .name = "stm32f4-i2c", > >> + .of_match_table = stm32f4_i2c_match, > > > > Is this needed? >

Re: [PATCH v6 2/5] i2c: Add STM32F4 I2C driver

Hello Cedric, On Thu, Dec 15, 2016 at 04:26:25PM +0100, M'boumba Cedric Madianga wrote: > >> +static struct platform_driver stm32f4_i2c_driver = { > >> + .driver = { > >> + .name = "stm32f4-i2c", > >> + .of_match_table = stm32f4_i2c_match, > > > > Is this needed? >

Re: [PATCH v6 2/5] i2c: Add STM32F4 I2C driver

Hello, Thanks for this review, it will help. 2016-12-13 10:20 GMT+01:00 Uwe Kleine-König : > Hello, > > On Mon, Dec 12, 2016 at 05:15:39PM +0100, M'boumba Cedric Madianga wrote: >> This patch adds support for the STM32F4 I2C controller. >> >> Signed-off-by:

Re: [PATCH v6 2/5] i2c: Add STM32F4 I2C driver

Hello, Thanks for this review, it will help. 2016-12-13 10:20 GMT+01:00 Uwe Kleine-König : > Hello, > > On Mon, Dec 12, 2016 at 05:15:39PM +0100, M'boumba Cedric Madianga wrote: >> This patch adds support for the STM32F4 I2C controller. >> >> Signed-off-by: M'boumba Cedric Madianga >> --- >>

Re: [PATCH v6 2/5] i2c: Add STM32F4 I2C driver

Hello, On Mon, Dec 12, 2016 at 05:15:39PM +0100, M'boumba Cedric Madianga wrote: > This patch adds support for the STM32F4 I2C controller. > > Signed-off-by: M'boumba Cedric Madianga > --- > drivers/i2c/busses/Kconfig | 10 + > drivers/i2c/busses/Makefile

Re: [PATCH v6 2/5] i2c: Add STM32F4 I2C driver

Hello, On Mon, Dec 12, 2016 at 05:15:39PM +0100, M'boumba Cedric Madianga wrote: > This patch adds support for the STM32F4 I2C controller. > > Signed-off-by: M'boumba Cedric Madianga > --- > drivers/i2c/busses/Kconfig | 10 + > drivers/i2c/busses/Makefile | 1 + >

[PATCH v6 2/5] i2c: Add STM32F4 I2C driver

This patch adds support for the STM32F4 I2C controller. Signed-off-by: M'boumba Cedric Madianga --- drivers/i2c/busses/Kconfig | 10 + drivers/i2c/busses/Makefile | 1 + drivers/i2c/busses/i2c-stm32f4.c | 849 +++ 3

[PATCH v6 2/5] i2c: Add STM32F4 I2C driver

This patch adds support for the STM32F4 I2C controller. Signed-off-by: M'boumba Cedric Madianga --- drivers/i2c/busses/Kconfig | 10 + drivers/i2c/busses/Makefile | 1 + drivers/i2c/busses/i2c-stm32f4.c | 849 +++ 3 files changed, 860