Re: [PATCH v6 3/3] arm64: kexec_file: add rng-seed support

2019-06-30 Thread Hsin-Yi Wang
On Fri, Jun 28, 2019 at 7:47 PM Hsin-Yi Wang wrote: > > > > If the RNG wasn't initialised, we'd carry on with a warning. Why do we > > follow a different policy here? > > (Sorry, please ignore previous comment) I think this part should be same as kaslr, since they are both adding random seeds:

Re: [PATCH v6 3/3] arm64: kexec_file: add rng-seed support

2019-06-28 Thread Hsin-Yi Wang
On Fri, Jun 28, 2019 at 5:42 PM Mark Rutland wrote: > > On Wed, Jun 12, 2019 at 12:33:02PM +0800, Hsin-Yi Wang wrote: > > Adding "rng-seed" to dtb. It's fine to add this property if original > > fdt doesn't contain it. Since original seed will be wiped after > > read, so use a default size 128

Re: [PATCH v6 3/3] arm64: kexec_file: add rng-seed support

2019-06-28 Thread Mark Rutland
On Wed, Jun 12, 2019 at 12:33:02PM +0800, Hsin-Yi Wang wrote: > Adding "rng-seed" to dtb. It's fine to add this property if original > fdt doesn't contain it. Since original seed will be wiped after > read, so use a default size 128 bytes here. Why is 128 bytes the default value? I didn't see an

[PATCH v6 3/3] arm64: kexec_file: add rng-seed support

2019-06-11 Thread Hsin-Yi Wang
Adding "rng-seed" to dtb. It's fine to add this property if original fdt doesn't contain it. Since original seed will be wiped after read, so use a default size 128 bytes here. Signed-off-by: Hsin-Yi Wang Reviewed-by: Stephen Boyd --- change log v5->v6: * no change ---