Re: [PATCH v6 4/4] ARM: Add KGDB/KDB FIQ debugger generic code

2014-06-30 Thread Daniel Thompson
On 26/06/14 10:54, Daniel Thompson wrote: >> Also bear in mind that svc_entry calls trace_hardirqs_off - is this >> appropriate and safe for the FIQ to call? > > I personally think it appropriate and it looked safe on the lockdep side > of things. However I will look a bit deeper at this since I

Re: [PATCH v6 4/4] ARM: Add KGDB/KDB FIQ debugger generic code

2014-06-30 Thread Daniel Thompson
On 26/06/14 10:54, Daniel Thompson wrote: Also bear in mind that svc_entry calls trace_hardirqs_off - is this appropriate and safe for the FIQ to call? I personally think it appropriate and it looked safe on the lockdep side of things. However I will look a bit deeper at this since I don't

Re: [PATCH v6 4/4] ARM: Add KGDB/KDB FIQ debugger generic code

2014-06-26 Thread Daniel Thompson
On 24/06/14 17:22, Nicolas Pitre wrote: > On Tue, 24 Jun 2014, Daniel Thompson wrote: > >> From: Anton Vorontsov >> >> The FIQ debugger may be used to debug situations when the kernel stuck >> in uninterruptable sections, e.g. the kernel infinitely loops or >> deadlocked in an interrupt or with

Re: [PATCH v6 4/4] ARM: Add KGDB/KDB FIQ debugger generic code

2014-06-26 Thread Daniel Thompson
On 24/06/14 17:08, Russell King - ARM Linux wrote: > On Tue, Jun 24, 2014 at 04:18:17PM +0100, Daniel Thompson wrote: >> +.align 5 >> +__fiq_svc: >> +svc_entry > > Remember that the registers you have on the stack here are r0-r12, plus > the SVC banked sp and lr registers. These may not

Re: [PATCH v6 4/4] ARM: Add KGDB/KDB FIQ debugger generic code

2014-06-26 Thread Daniel Thompson
On 24/06/14 17:08, Russell King - ARM Linux wrote: On Tue, Jun 24, 2014 at 04:18:17PM +0100, Daniel Thompson wrote: +.align 5 +__fiq_svc: +svc_entry Remember that the registers you have on the stack here are r0-r12, plus the SVC banked sp and lr registers. These may not be the

Re: [PATCH v6 4/4] ARM: Add KGDB/KDB FIQ debugger generic code

2014-06-26 Thread Daniel Thompson
On 24/06/14 17:22, Nicolas Pitre wrote: On Tue, 24 Jun 2014, Daniel Thompson wrote: From: Anton Vorontsov anton.voront...@linaro.org The FIQ debugger may be used to debug situations when the kernel stuck in uninterruptable sections, e.g. the kernel infinitely loops or deadlocked in an

Re: [PATCH v6 4/4] ARM: Add KGDB/KDB FIQ debugger generic code

2014-06-24 Thread Nicolas Pitre
On Tue, 24 Jun 2014, Daniel Thompson wrote: > From: Anton Vorontsov > > The FIQ debugger may be used to debug situations when the kernel stuck > in uninterruptable sections, e.g. the kernel infinitely loops or > deadlocked in an interrupt or with interrupts disabled. > > By default KGDB FIQ is

Re: [PATCH v6 4/4] ARM: Add KGDB/KDB FIQ debugger generic code

2014-06-24 Thread Russell King - ARM Linux
On Tue, Jun 24, 2014 at 04:18:17PM +0100, Daniel Thompson wrote: > + .align 5 > +__fiq_svc: > + svc_entry Remember that the registers you have on the stack here are r0-r12, plus the SVC banked sp and lr registers. These may not be the registers from the mode you took the FIQ (eg, if it

[PATCH v6 4/4] ARM: Add KGDB/KDB FIQ debugger generic code

2014-06-24 Thread Daniel Thompson
From: Anton Vorontsov The FIQ debugger may be used to debug situations when the kernel stuck in uninterruptable sections, e.g. the kernel infinitely loops or deadlocked in an interrupt or with interrupts disabled. By default KGDB FIQ is disabled in runtime, but can be enabled with

[PATCH v6 4/4] ARM: Add KGDB/KDB FIQ debugger generic code

2014-06-24 Thread Daniel Thompson
From: Anton Vorontsov anton.voront...@linaro.org The FIQ debugger may be used to debug situations when the kernel stuck in uninterruptable sections, e.g. the kernel infinitely loops or deadlocked in an interrupt or with interrupts disabled. By default KGDB FIQ is disabled in runtime, but can be

Re: [PATCH v6 4/4] ARM: Add KGDB/KDB FIQ debugger generic code

2014-06-24 Thread Russell King - ARM Linux
On Tue, Jun 24, 2014 at 04:18:17PM +0100, Daniel Thompson wrote: + .align 5 +__fiq_svc: + svc_entry Remember that the registers you have on the stack here are r0-r12, plus the SVC banked sp and lr registers. These may not be the registers from the mode you took the FIQ (eg, if it was

Re: [PATCH v6 4/4] ARM: Add KGDB/KDB FIQ debugger generic code

2014-06-24 Thread Nicolas Pitre
On Tue, 24 Jun 2014, Daniel Thompson wrote: From: Anton Vorontsov anton.voront...@linaro.org The FIQ debugger may be used to debug situations when the kernel stuck in uninterruptable sections, e.g. the kernel infinitely loops or deadlocked in an interrupt or with interrupts disabled. By