Re: [PATCH v6 5/5] media: i2c: max9286: Configure reverse channel amplitude

2021-01-14 Thread Jacopo Mondi
Hi Laurent, On Thu, Jan 14, 2021 at 07:53:36AM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > > > > All in all: > > - yes, I think there might be a need to control the noise immunity > > settings after initialization > > - I think it should be done on the serializer side, possibly with a DT >

Re: [PATCH v6 5/5] media: i2c: max9286: Configure reverse channel amplitude

2021-01-13 Thread Laurent Pinchart
Hi Jacopo, On Tue, Jan 12, 2021 at 10:08:05AM +0100, Jacopo Mondi wrote: > On Tue, Jan 12, 2021 at 07:03:42AM +0200, Laurent Pinchart wrote: > > On Mon, Jan 11, 2021 at 12:20:23PM +0100, Jacopo Mondi wrote: > > > On Mon, Jan 11, 2021 at 12:58:59PM +0200, Laurent Pinchart wrote: > > > > On Mon,

Re: [PATCH v6 5/5] media: i2c: max9286: Configure reverse channel amplitude

2021-01-12 Thread Jacopo Mondi
Hi Geert On Tue, Jan 12, 2021 at 10:10:39AM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > On Tue, Jan 12, 2021 at 10:07 AM Jacopo Mondi wrote: > > On Tue, Jan 12, 2021 at 07:03:42AM +0200, Laurent Pinchart wrote: > > > On Mon, Jan 11, 2021 at 12:20:23PM +0100, Jacopo Mondi wrote: > > > > On

Re: [PATCH v6 5/5] media: i2c: max9286: Configure reverse channel amplitude

2021-01-12 Thread Geert Uytterhoeven
Hi Jacopo, On Tue, Jan 12, 2021 at 10:07 AM Jacopo Mondi wrote: > On Tue, Jan 12, 2021 at 07:03:42AM +0200, Laurent Pinchart wrote: > > On Mon, Jan 11, 2021 at 12:20:23PM +0100, Jacopo Mondi wrote: > > > On Mon, Jan 11, 2021 at 12:58:59PM +0200, Laurent Pinchart wrote: > > > > On Mon, Jan 11,

Re: [PATCH v6 5/5] media: i2c: max9286: Configure reverse channel amplitude

2021-01-12 Thread Jacopo Mondi
Hi Laurent, On Tue, Jan 12, 2021 at 07:03:42AM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > On Mon, Jan 11, 2021 at 12:20:23PM +0100, Jacopo Mondi wrote: > > On Mon, Jan 11, 2021 at 12:58:59PM +0200, Laurent Pinchart wrote: > > > On Mon, Jan 11, 2021 at 11:43:11AM +0100, Jacopo Mondi wrote: >

Re: [PATCH v6 5/5] media: i2c: max9286: Configure reverse channel amplitude

2021-01-11 Thread Laurent Pinchart
Hi Jacopo, On Mon, Jan 11, 2021 at 12:20:23PM +0100, Jacopo Mondi wrote: > On Mon, Jan 11, 2021 at 12:58:59PM +0200, Laurent Pinchart wrote: > > On Mon, Jan 11, 2021 at 11:43:11AM +0100, Jacopo Mondi wrote: > >> On Wed, Dec 16, 2020 at 07:22:17PM +0200, Laurent Pinchart wrote: > >>> On Tue, Dec

Re: [PATCH v6 5/5] media: i2c: max9286: Configure reverse channel amplitude

2021-01-11 Thread Jacopo Mondi
Hi Laurent, On Mon, Jan 11, 2021 at 12:58:59PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > On Mon, Jan 11, 2021 at 11:43:11AM +0100, Jacopo Mondi wrote: > > On Wed, Dec 16, 2020 at 07:22:17PM +0200, Laurent Pinchart wrote: > > > On Tue, Dec 15, 2020 at 06:09:57PM +0100, Jacopo Mondi wrote: >

Re: [PATCH v6 5/5] media: i2c: max9286: Configure reverse channel amplitude

2021-01-11 Thread Laurent Pinchart
Hi Jacopo, On Mon, Jan 11, 2021 at 11:43:11AM +0100, Jacopo Mondi wrote: > On Wed, Dec 16, 2020 at 07:22:17PM +0200, Laurent Pinchart wrote: > > On Tue, Dec 15, 2020 at 06:09:57PM +0100, Jacopo Mondi wrote: > > > Adjust the initial reverse channel amplitude parsing from > > > firmware interface

Re: [PATCH v6 5/5] media: i2c: max9286: Configure reverse channel amplitude

2021-01-11 Thread Jacopo Mondi
Hi Laurent, On Wed, Dec 16, 2020 at 07:22:17PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Tue, Dec 15, 2020 at 06:09:57PM +0100, Jacopo Mondi wrote: > > Adjust the initial reverse channel amplitude parsing from > > firmware interface the

Re: [PATCH v6 5/5] media: i2c: max9286: Configure reverse channel amplitude

2020-12-16 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Tue, Dec 15, 2020 at 06:09:57PM +0100, Jacopo Mondi wrote: > Adjust the initial reverse channel amplitude parsing from > firmware interface the 'maxim,reverse-channel-microvolt' > property. > > This change is required for both rdacm20 and rdacm21 camera >

[PATCH v6 5/5] media: i2c: max9286: Configure reverse channel amplitude

2020-12-15 Thread Jacopo Mondi
Adjust the initial reverse channel amplitude parsing from firmware interface the 'maxim,reverse-channel-microvolt' property. This change is required for both rdacm20 and rdacm21 camera modules to be correctly probed when used in combination with the max9286 deserializer. Reviewed-by: Kieran