Re: [PATCH v6 6/6] perf util: use correct IP mapping to find srcline for hist entry

2017-10-30 Thread Namhyung Kim
Hi Arnaldo, On Mon, Oct 30, 2017 at 05:03:47PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 25, 2017 at 10:46:00AM +0900, Namhyung Kim escreveu: > > Hi Milian, > > > > On Tue, Oct 24, 2017 at 10:51:43AM +0200, Milian Wolff wrote: > > > On Freitag, 20. Oktober 2017 07:15:33 CEST Namhyung

Re: [PATCH v6 6/6] perf util: use correct IP mapping to find srcline for hist entry

2017-10-30 Thread Namhyung Kim
Hi Arnaldo, On Mon, Oct 30, 2017 at 05:03:47PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 25, 2017 at 10:46:00AM +0900, Namhyung Kim escreveu: > > Hi Milian, > > > > On Tue, Oct 24, 2017 at 10:51:43AM +0200, Milian Wolff wrote: > > > On Freitag, 20. Oktober 2017 07:15:33 CEST Namhyung

Re: [PATCH v6 6/6] perf util: use correct IP mapping to find srcline for hist entry

2017-10-30 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 25, 2017 at 10:46:00AM +0900, Namhyung Kim escreveu: > Hi Milian, > > On Tue, Oct 24, 2017 at 10:51:43AM +0200, Milian Wolff wrote: > > On Freitag, 20. Oktober 2017 07:15:33 CEST Namhyung Kim wrote: > > > I looked into it and found a bug handling cumulative (children) > > > entries.

Re: [PATCH v6 6/6] perf util: use correct IP mapping to find srcline for hist entry

2017-10-30 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 25, 2017 at 10:46:00AM +0900, Namhyung Kim escreveu: > Hi Milian, > > On Tue, Oct 24, 2017 at 10:51:43AM +0200, Milian Wolff wrote: > > On Freitag, 20. Oktober 2017 07:15:33 CEST Namhyung Kim wrote: > > > I looked into it and found a bug handling cumulative (children) > > > entries.

Re: [PATCH v6 6/6] perf util: use correct IP mapping to find srcline for hist entry

2017-10-24 Thread Namhyung Kim
Hi Milian, On Tue, Oct 24, 2017 at 10:51:43AM +0200, Milian Wolff wrote: > On Freitag, 20. Oktober 2017 07:15:33 CEST Namhyung Kim wrote: > > I looked into it and found a bug handling cumulative (children) > > entries. For chilren entries that has no self period, the al->addr > > (so he->ip)

Re: [PATCH v6 6/6] perf util: use correct IP mapping to find srcline for hist entry

2017-10-24 Thread Namhyung Kim
Hi Milian, On Tue, Oct 24, 2017 at 10:51:43AM +0200, Milian Wolff wrote: > On Freitag, 20. Oktober 2017 07:15:33 CEST Namhyung Kim wrote: > > I looked into it and found a bug handling cumulative (children) > > entries. For chilren entries that has no self period, the al->addr > > (so he->ip)

Re: [PATCH v6 6/6] perf util: use correct IP mapping to find srcline for hist entry

2017-10-24 Thread Milian Wolff
On Freitag, 20. Oktober 2017 07:15:33 CEST Namhyung Kim wrote: > Hi Milian, > > On Thu, Oct 19, 2017 at 12:54:18PM +0200, Milian Wolff wrote: > > On Mittwoch, 18. Oktober 2017 20:53:50 CEST Milian Wolff wrote: > > > When inline frame resolution is disabled, a bogus srcline is obtained > > > for

Re: [PATCH v6 6/6] perf util: use correct IP mapping to find srcline for hist entry

2017-10-24 Thread Milian Wolff
On Freitag, 20. Oktober 2017 07:15:33 CEST Namhyung Kim wrote: > Hi Milian, > > On Thu, Oct 19, 2017 at 12:54:18PM +0200, Milian Wolff wrote: > > On Mittwoch, 18. Oktober 2017 20:53:50 CEST Milian Wolff wrote: > > > When inline frame resolution is disabled, a bogus srcline is obtained > > > for

Re: [PATCH v6 6/6] perf util: use correct IP mapping to find srcline for hist entry

2017-10-19 Thread Namhyung Kim
Hi Milian, On Thu, Oct 19, 2017 at 12:54:18PM +0200, Milian Wolff wrote: > On Mittwoch, 18. Oktober 2017 20:53:50 CEST Milian Wolff wrote: > > When inline frame resolution is disabled, a bogus srcline is obtained > > for hist entries: > > > > ~ > > $ perf report -s sym,srcline --no-inline

Re: [PATCH v6 6/6] perf util: use correct IP mapping to find srcline for hist entry

2017-10-19 Thread Namhyung Kim
Hi Milian, On Thu, Oct 19, 2017 at 12:54:18PM +0200, Milian Wolff wrote: > On Mittwoch, 18. Oktober 2017 20:53:50 CEST Milian Wolff wrote: > > When inline frame resolution is disabled, a bogus srcline is obtained > > for hist entries: > > > > ~ > > $ perf report -s sym,srcline --no-inline

Re: [PATCH v6 6/6] perf util: use correct IP mapping to find srcline for hist entry

2017-10-19 Thread Milian Wolff
On Mittwoch, 18. Oktober 2017 20:53:50 CEST Milian Wolff wrote: > When inline frame resolution is disabled, a bogus srcline is obtained > for hist entries: > > ~ > $ perf report -s sym,srcline --no-inline --stdio -g none > 95.21% 0.00% [.] __libc_start_main

Re: [PATCH v6 6/6] perf util: use correct IP mapping to find srcline for hist entry

2017-10-19 Thread Milian Wolff
On Mittwoch, 18. Oktober 2017 20:53:50 CEST Milian Wolff wrote: > When inline frame resolution is disabled, a bogus srcline is obtained > for hist entries: > > ~ > $ perf report -s sym,srcline --no-inline --stdio -g none > 95.21% 0.00% [.] __libc_start_main

[PATCH v6 6/6] perf util: use correct IP mapping to find srcline for hist entry

2017-10-18 Thread Milian Wolff
When inline frame resolution is disabled, a bogus srcline is obtained for hist entries: ~ $ perf report -s sym,srcline --no-inline --stdio -g none 95.21% 0.00% [.] __libc_start_main

[PATCH v6 6/6] perf util: use correct IP mapping to find srcline for hist entry

2017-10-18 Thread Milian Wolff
When inline frame resolution is disabled, a bogus srcline is obtained for hist entries: ~ $ perf report -s sym,srcline --no-inline --stdio -g none 95.21% 0.00% [.] __libc_start_main