Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

Hi Steve, On Thu, 21 Jun 2018 16:16:48 -0400 Steven Rostedt wrote: > Hi Masami, > > Are you going to post another version of this patch set? No, this is the latest one which I sent to LKML. Oops, it was 2 month ago now... Thank you, > > -- Steve > > > On Wed, 25 Apr 2018 21:16:06 +0900 >

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

Hi Steve, On Thu, 21 Jun 2018 16:16:48 -0400 Steven Rostedt wrote: > Hi Masami, > > Are you going to post another version of this patch set? No, this is the latest one which I sent to LKML. Oops, it was 2 month ago now... Thank you, > > -- Steve > > > On Wed, 25 Apr 2018 21:16:06 +0900 >

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

Hi Masami, Are you going to post another version of this patch set? -- Steve On Wed, 25 Apr 2018 21:16:06 +0900 Masami Hiramatsu wrote: > Hi, > > This is the 7th version of the fetch-arg improvement series. > This includes variable changes on fetcharg framework like, > > - Add fetcharg

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

Hi Masami, Are you going to post another version of this patch set? -- Steve On Wed, 25 Apr 2018 21:16:06 +0900 Masami Hiramatsu wrote: > Hi, > > This is the 7th version of the fetch-arg improvement series. > This includes variable changes on fetcharg framework like, > > - Add fetcharg

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

Masami Hiramatsu wrote: On Tue, 08 May 2018 15:41:11 +0530 "Naveen N. Rao" wrote: Masami Hiramatsu wrote: > On Mon, 07 May 2018 13:41:53 +0530 > "Naveen N. Rao" wrote: >> >> >> >> I didn't understand that. Which code are you

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

Masami Hiramatsu wrote: On Tue, 08 May 2018 15:41:11 +0530 "Naveen N. Rao" wrote: Masami Hiramatsu wrote: > On Mon, 07 May 2018 13:41:53 +0530 > "Naveen N. Rao" wrote: >> >> >> >> I didn't understand that. Which code are you planning to remove? Can you >> >> please elaborate? I thought we

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

On Tue, 08 May 2018 15:41:11 +0530 "Naveen N. Rao" wrote: > Masami Hiramatsu wrote: > > On Mon, 07 May 2018 13:41:53 +0530 > > "Naveen N. Rao" wrote: > >> >> > >> >> I didn't understand that. Which code are you planning to

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

On Tue, 08 May 2018 15:41:11 +0530 "Naveen N. Rao" wrote: > Masami Hiramatsu wrote: > > On Mon, 07 May 2018 13:41:53 +0530 > > "Naveen N. Rao" wrote: > >> >> > >> >> I didn't understand that. Which code are you planning to remove? Can > >> >> you > >> >> please elaborate? I thought we still

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

Masami Hiramatsu wrote: On Mon, 07 May 2018 13:41:53 +0530 "Naveen N. Rao" wrote: >> >> I didn't understand that. Which code are you planning to remove? Can you >> please elaborate? I thought we still need to disable preemption in the >> ftrace handler. > >

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

Masami Hiramatsu wrote: On Mon, 07 May 2018 13:41:53 +0530 "Naveen N. Rao" wrote: >> >> I didn't understand that. Which code are you planning to remove? Can you >> please elaborate? I thought we still need to disable preemption in the >> ftrace handler. > > Yes, kprobe_ftrace_handler itself

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

On Mon, 7 May 2018 11:30:03 -0400 Steven Rostedt wrote: > On Sun, 6 May 2018 00:51:43 +0900 > Masami Hiramatsu wrote: > > > OK, now I think it is a time to introduce new unified interface for dynamic > > events, > > tracefs/dynamic_events and make

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

On Mon, 7 May 2018 11:30:03 -0400 Steven Rostedt wrote: > On Sun, 6 May 2018 00:51:43 +0900 > Masami Hiramatsu wrote: > > > OK, now I think it is a time to introduce new unified interface for dynamic > > events, > > tracefs/dynamic_events and make uprobe_events and kprobe_events as > >

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

On Sun, 6 May 2018 00:51:43 +0900 Masami Hiramatsu wrote: > OK, now I think it is a time to introduce new unified interface for dynamic > events, > tracefs/dynamic_events and make uprobe_events and kprobe_events as > symbolic-links > to the new interface file. So

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

On Sun, 6 May 2018 00:51:43 +0900 Masami Hiramatsu wrote: > OK, now I think it is a time to introduce new unified interface for dynamic > events, > tracefs/dynamic_events and make uprobe_events and kprobe_events as > symbolic-links > to the new interface file. So basically make one file that

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

On Sat, 5 May 2018 11:38:03 +0900 Masami Hiramatsu wrote: > On Fri, 4 May 2018 12:06:42 -0400 > Steven Rostedt wrote: > > > On Sat, 5 May 2018 00:48:28 +0900 > > Masami Hiramatsu wrote: > > > > > So the syntax will be > > > >

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

On Sat, 5 May 2018 11:38:03 +0900 Masami Hiramatsu wrote: > On Fri, 4 May 2018 12:06:42 -0400 > Steven Rostedt wrote: > > > On Sat, 5 May 2018 00:48:28 +0900 > > Masami Hiramatsu wrote: > > > > > So the syntax will be > > > > > > p[:EVENT] SYM[(CAST)|+OFFS] [FETCHARG] > > > > > > And

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

On Mon, 07 May 2018 13:41:53 +0530 "Naveen N. Rao" wrote: > Masami Hiramatsu wrote: > > On Sat, 05 May 2018 13:16:04 +0530 > > "Naveen N. Rao" wrote: > > > >> Masami Hiramatsu wrote: > >> > On Fri, 4 May 2018 12:06:42 -0400 > >>

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

On Mon, 07 May 2018 13:41:53 +0530 "Naveen N. Rao" wrote: > Masami Hiramatsu wrote: > > On Sat, 05 May 2018 13:16:04 +0530 > > "Naveen N. Rao" wrote: > > > >> Masami Hiramatsu wrote: > >> > On Fri, 4 May 2018 12:06:42 -0400 > >> > Steven Rostedt wrote: > >> > > >> >> On Sat, 5 May 2018

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

Masami Hiramatsu wrote: On Sat, 05 May 2018 13:16:04 +0530 "Naveen N. Rao" wrote: Masami Hiramatsu wrote: > On Fri, 4 May 2018 12:06:42 -0400 > Steven Rostedt wrote: > >> On Sat, 5 May 2018 00:48:28 +0900 >> Masami Hiramatsu

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

Masami Hiramatsu wrote: On Sat, 05 May 2018 13:16:04 +0530 "Naveen N. Rao" wrote: Masami Hiramatsu wrote: > On Fri, 4 May 2018 12:06:42 -0400 > Steven Rostedt wrote: > >> On Sat, 5 May 2018 00:48:28 +0900 >> Masami Hiramatsu wrote: >> >> > > Also, when looking at the kprobe code, I was

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

On Sat, 5 May 2018 11:38:03 +0900 Masami Hiramatsu wrote: > On Fri, 4 May 2018 12:06:42 -0400 > Steven Rostedt wrote: > > > On Sat, 5 May 2018 00:48:28 +0900 > > Masami Hiramatsu wrote: > > > > > So the syntax will be > > > > >

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

On Sat, 5 May 2018 11:38:03 +0900 Masami Hiramatsu wrote: > On Fri, 4 May 2018 12:06:42 -0400 > Steven Rostedt wrote: > > > On Sat, 5 May 2018 00:48:28 +0900 > > Masami Hiramatsu wrote: > > > > > So the syntax will be > > > > > > p[:EVENT] SYM[(CAST)|+OFFS] [FETCHARG] > > > > > > And here

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

On Sat, 05 May 2018 13:16:04 +0530 "Naveen N. Rao" wrote: > Masami Hiramatsu wrote: > > On Fri, 4 May 2018 12:06:42 -0400 > > Steven Rostedt wrote: > > > >> On Sat, 5 May 2018 00:48:28 +0900 > >> Masami Hiramatsu

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

On Sat, 05 May 2018 13:16:04 +0530 "Naveen N. Rao" wrote: > Masami Hiramatsu wrote: > > On Fri, 4 May 2018 12:06:42 -0400 > > Steven Rostedt wrote: > > > >> On Sat, 5 May 2018 00:48:28 +0900 > >> Masami Hiramatsu wrote: > >> > >> > > Also, when looking at the kprobe code, I was looking at

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

Masami Hiramatsu wrote: On Fri, 4 May 2018 12:06:42 -0400 Steven Rostedt wrote: On Sat, 5 May 2018 00:48:28 +0900 Masami Hiramatsu wrote: > > Also, when looking at the kprobe code, I was looking at this > > function: > > > > > /* Ftrace callback

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

Masami Hiramatsu wrote: On Fri, 4 May 2018 12:06:42 -0400 Steven Rostedt wrote: On Sat, 5 May 2018 00:48:28 +0900 Masami Hiramatsu wrote: > > Also, when looking at the kprobe code, I was looking at this > > function: > > > > > /* Ftrace callback handler for kprobes -- called under

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

On Fri, 4 May 2018 12:06:42 -0400 Steven Rostedt wrote: > On Sat, 5 May 2018 00:48:28 +0900 > Masami Hiramatsu wrote: > > > So the syntax will be > > > > p[:EVENT] SYM[(CAST)|+OFFS] [FETCHARG] > > > > And here is an example; > > > > p:myevent

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

On Fri, 4 May 2018 12:06:42 -0400 Steven Rostedt wrote: > On Sat, 5 May 2018 00:48:28 +0900 > Masami Hiramatsu wrote: > > > So the syntax will be > > > > p[:EVENT] SYM[(CAST)|+OFFS] [FETCHARG] > > > > And here is an example; > > > > p:myevent vfs_read(void *file, char *buf, size_t count,

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

Steven Rostedt wrote: On Sat, 5 May 2018 00:48:28 +0900 Masami Hiramatsu wrote: > > Also, when looking at the kprobe code, I was looking at this function: > > > /* Ftrace callback handler for kprobes -- called under preepmt disabed */ > > void

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

Steven Rostedt wrote: On Sat, 5 May 2018 00:48:28 +0900 Masami Hiramatsu wrote: > > Also, when looking at the kprobe code, I was looking at this function: > > > /* Ftrace callback handler for kprobes -- called under preepmt disabed */ > > void kprobe_ftrace_handler(unsigned long ip,

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

On Sat, 5 May 2018 00:48:28 +0900 Masami Hiramatsu wrote: > So the syntax will be > > p[:EVENT] SYM[(CAST)|+OFFS] [FETCHARG] > > And here is an example; > > p:myevent vfs_read(void *file, char *buf, size_t count, void *pos) $arg1 $arg2 If we do this, why bother with

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

On Sat, 5 May 2018 00:48:28 +0900 Masami Hiramatsu wrote: > So the syntax will be > > p[:EVENT] SYM[(CAST)|+OFFS] [FETCHARG] > > And here is an example; > > p:myevent vfs_read(void *file, char *buf, size_t count, void *pos) $arg1 $arg2 If we do this, why bother with $arg1 $arg2? We could

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

On Thu, 3 May 2018 18:11:37 -0400 Steven Rostedt wrote: > On Wed, 25 Apr 2018 21:16:06 +0900 > Masami Hiramatsu wrote: > > > Hi, > > > > This is the 7th version of the fetch-arg improvement series. > > This includes variable changes on fetcharg

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

On Thu, 3 May 2018 18:11:37 -0400 Steven Rostedt wrote: > On Wed, 25 Apr 2018 21:16:06 +0900 > Masami Hiramatsu wrote: > > > Hi, > > > > This is the 7th version of the fetch-arg improvement series. > > This includes variable changes on fetcharg framework like, > > > > - Add fetcharg

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

On Wed, 25 Apr 2018 21:16:06 +0900 Masami Hiramatsu wrote: > Hi, > > This is the 7th version of the fetch-arg improvement series. > This includes variable changes on fetcharg framework like, > > - Add fetcharg testcases (syntax, argN, symbol, string and array) > and

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

On Wed, 25 Apr 2018 21:16:06 +0900 Masami Hiramatsu wrote: > Hi, > > This is the 7th version of the fetch-arg improvement series. > This includes variable changes on fetcharg framework like, > > - Add fetcharg testcases (syntax, argN, symbol, string and array) > and probepoint testcase. > -

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

On Wed, 25 Apr 2018 21:16:06 +0900 Masami Hiramatsu wrote: > Hi, > > This is the 7th version of the fetch-arg improvement series. > This includes variable changes on fetcharg framework like, > > - Add fetcharg testcases (syntax, argN, symbol, string and array) > and

Re: [PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

On Wed, 25 Apr 2018 21:16:06 +0900 Masami Hiramatsu wrote: > Hi, > > This is the 7th version of the fetch-arg improvement series. > This includes variable changes on fetcharg framework like, > > - Add fetcharg testcases (syntax, argN, symbol, string and array) > and probepoint testcase. > -

[PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

Hi, This is the 7th version of the fetch-arg improvement series. This includes variable changes on fetcharg framework like, - Add fetcharg testcases (syntax, argN, symbol, string and array) and probepoint testcase. - Rewrite fetcharg framework with fetch_insn, switch-case based instead of

[PATCH v7 00/16] tracing: probeevent: Improve fetcharg features

Hi, This is the 7th version of the fetch-arg improvement series. This includes variable changes on fetcharg framework like, - Add fetcharg testcases (syntax, argN, symbol, string and array) and probepoint testcase. - Rewrite fetcharg framework with fetch_insn, switch-case based instead of