Re: [PATCH v7 01/12] Add kernel address sanitizer infrastructure.

2014-11-25 Thread Andrey Ryabinin
On 11/25/2014 03:40 PM, Dmitry Chernenkov wrote: > I'm a little concerned with how enabling/disabling works. If an > enable() is forgotten once, it's disabled forever. If disable() is > forgotten once, the toggle is reversed for the forseable future. MB > check for inequality in kasan_enabled()?

Re: [PATCH v7 01/12] Add kernel address sanitizer infrastructure.

2014-11-25 Thread Dmitry Chernenkov
I'm a little concerned with how enabling/disabling works. If an enable() is forgotten once, it's disabled forever. If disable() is forgotten once, the toggle is reversed for the forseable future. MB check for inequality in kasan_enabled()? like current->kasan_depth >= 0 (will need a signed int for

Re: [PATCH v7 01/12] Add kernel address sanitizer infrastructure.

2014-11-25 Thread Dmitry Chernenkov
I'm a little concerned with how enabling/disabling works. If an enable() is forgotten once, it's disabled forever. If disable() is forgotten once, the toggle is reversed for the forseable future. MB check for inequality in kasan_enabled()? like current-kasan_depth = 0 (will need a signed int for

Re: [PATCH v7 01/12] Add kernel address sanitizer infrastructure.

2014-11-25 Thread Andrey Ryabinin
On 11/25/2014 03:40 PM, Dmitry Chernenkov wrote: I'm a little concerned with how enabling/disabling works. If an enable() is forgotten once, it's disabled forever. If disable() is forgotten once, the toggle is reversed for the forseable future. MB check for inequality in kasan_enabled()? like

[PATCH v7 01/12] Add kernel address sanitizer infrastructure.

2014-11-24 Thread Andrey Ryabinin
Kernel Address sanitizer (KASan) is a dynamic memory error detector. It provides fast and comprehensive solution for finding use-after-free and out-of-bounds bugs. KASAN uses compile-time instrumentation for checking every memory access, therefore GCC >= v4.9.2 required. This patch only adds

[PATCH v7 01/12] Add kernel address sanitizer infrastructure.

2014-11-24 Thread Andrey Ryabinin
Kernel Address sanitizer (KASan) is a dynamic memory error detector. It provides fast and comprehensive solution for finding use-after-free and out-of-bounds bugs. KASAN uses compile-time instrumentation for checking every memory access, therefore GCC = v4.9.2 required. This patch only adds