Re: [PATCH v7 8/8] block: create the request_queue debugfs_dir on registration

2020-06-22 Thread Bart Van Assche
On 2020-06-22 05:42, Luis Chamberlain wrote: > On Sat, Jun 20, 2020 at 11:07:43AM -0700, Bart Van Assche wrote: >> On 2020-06-19 13:47, Luis Chamberlain wrote: >>> We were only creating the request_queue debugfs_dir only >>> for make_request block drivers (multiqueue), but never for >>>

Re: [PATCH v7 8/8] block: create the request_queue debugfs_dir on registration

2020-06-22 Thread Luis Chamberlain
On Sat, Jun 20, 2020 at 11:07:43AM -0700, Bart Van Assche wrote: > On 2020-06-19 13:47, Luis Chamberlain wrote: > > We were only creating the request_queue debugfs_dir only > > for make_request block drivers (multiqueue), but never for > > request-based block drivers. We did this as we were only >

Re: [PATCH v7 8/8] block: create the request_queue debugfs_dir on registration

2020-06-20 Thread Bart Van Assche
On 2020-06-19 13:47, Luis Chamberlain wrote: > We were only creating the request_queue debugfs_dir only > for make_request block drivers (multiqueue), but never for > request-based block drivers. We did this as we were only > creating non-blktrace additional debugfs files on that directory > for

Re: [PATCH v7 8/8] block: create the request_queue debugfs_dir on registration

2020-06-20 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

[PATCH v7 8/8] block: create the request_queue debugfs_dir on registration

2020-06-19 Thread Luis Chamberlain
We were only creating the request_queue debugfs_dir only for make_request block drivers (multiqueue), but never for request-based block drivers. We did this as we were only creating non-blktrace additional debugfs files on that directory for make_request drivers. However, since blktrace *always*