Re: [PATCH v9 1/6] fpga: dfl: fix the definitions of type & feature_id for dfl devices

2020-10-12 Thread Greg KH
On Mon, Oct 12, 2020 at 07:07:55AM -0700, Tom Rix wrote: > > On 10/11/20 7:41 PM, Xu Yilun wrote: > > On Sat, Oct 10, 2020 at 08:07:07AM -0700, Tom Rix wrote: > >> On 10/10/20 12:09 AM, Xu Yilun wrote: > >>> The value of the field dfl_device.type comes from the 12 bits register > >>> field DFH_ID

Re: [PATCH v9 1/6] fpga: dfl: fix the definitions of type & feature_id for dfl devices

2020-10-12 Thread Tom Rix
On 10/11/20 7:41 PM, Xu Yilun wrote: > On Sat, Oct 10, 2020 at 08:07:07AM -0700, Tom Rix wrote: >> On 10/10/20 12:09 AM, Xu Yilun wrote: >>> The value of the field dfl_device.type comes from the 12 bits register >>> field DFH_ID according to DFL spec. So this patch changes the definition >>> of

Re: [PATCH v9 1/6] fpga: dfl: fix the definitions of type & feature_id for dfl devices

2020-10-11 Thread Xu Yilun
On Sat, Oct 10, 2020 at 08:07:07AM -0700, Tom Rix wrote: > > On 10/10/20 12:09 AM, Xu Yilun wrote: > > The value of the field dfl_device.type comes from the 12 bits register > > field DFH_ID according to DFL spec. So this patch changes the definition > > of the type field to u16. > > > > Also it

Re: [PATCH v9 1/6] fpga: dfl: fix the definitions of type & feature_id for dfl devices

2020-10-10 Thread Tom Rix
On 10/10/20 12:09 AM, Xu Yilun wrote: > The value of the field dfl_device.type comes from the 12 bits register > field DFH_ID according to DFL spec. So this patch changes the definition > of the type field to u16. > > Also it is not necessary to illustrate the valid bits of the type field > in

[PATCH v9 1/6] fpga: dfl: fix the definitions of type & feature_id for dfl devices

2020-10-10 Thread Xu Yilun
The value of the field dfl_device.type comes from the 12 bits register field DFH_ID according to DFL spec. So this patch changes the definition of the type field to u16. Also it is not necessary to illustrate the valid bits of the type field in comments. Instead we should explicitly define the