Re: [PATCHv3 3/6] staging: rts_pstor: reuse kbasename()

2012-10-22 Thread Greg Kroah-Hartman
On Tue, Oct 16, 2012 at 02:48:11PM +0300, Andy Shevchenko wrote: > The custom filename function mostly repeats the kernel's kbasename. This patch > simplifies it. The updated filename() will not check for the '\' in the > filenames. It seems redundant in Linux. The __FILE__ macro always defined if

Re: [PATCHv3 3/6] staging: rts_pstor: reuse kbasename()

2012-10-22 Thread Greg Kroah-Hartman
On Tue, Oct 16, 2012 at 02:48:11PM +0300, Andy Shevchenko wrote: The custom filename function mostly repeats the kernel's kbasename. This patch simplifies it. The updated filename() will not check for the '\' in the filenames. It seems redundant in Linux. The __FILE__ macro always defined if

[PATCHv3 3/6] staging: rts_pstor: reuse kbasename()

2012-10-16 Thread Andy Shevchenko
The custom filename function mostly repeats the kernel's kbasename. This patch simplifies it. The updated filename() will not check for the '\' in the filenames. It seems redundant in Linux. The __FILE__ macro always defined if we compile an existing file. Thus, NULL check is not needed there as

[PATCHv3 3/6] staging: rts_pstor: reuse kbasename()

2012-10-16 Thread Andy Shevchenko
The custom filename function mostly repeats the kernel's kbasename. This patch simplifies it. The updated filename() will not check for the '\' in the filenames. It seems redundant in Linux. The __FILE__ macro always defined if we compile an existing file. Thus, NULL check is not needed there as