Re: [PATCHv3 5/6] zswap: add to mm/

2013-02-06 Thread Seth Jennings
On 02/06/2013 05:47 PM, Dan Magenheimer wrote: >> From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] >> Subject: Re: [PATCHv3 5/6] zswap: add to mm/ >> >> On 01/29/2013 12:27 AM, Minchan Kim wrote: >>> First feeling is it's simple and nice approach. &

RE: [PATCHv3 5/6] zswap: add to mm/

2013-02-06 Thread Dan Magenheimer
> From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] > Subject: Re: [PATCHv3 5/6] zswap: add to mm/ > > On 01/29/2013 12:27 AM, Minchan Kim wrote: > > First feeling is it's simple and nice approach. > > Although we have some problems to decide policy, it could s

RE: [PATCHv3 5/6] zswap: add to mm/

2013-02-06 Thread Dan Magenheimer
From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] Subject: Re: [PATCHv3 5/6] zswap: add to mm/ On 01/29/2013 12:27 AM, Minchan Kim wrote: First feeling is it's simple and nice approach. Although we have some problems to decide policy, it could solve by later patch so I hope we

Re: [PATCHv3 5/6] zswap: add to mm/

2013-02-06 Thread Seth Jennings
On 02/06/2013 05:47 PM, Dan Magenheimer wrote: From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] Subject: Re: [PATCHv3 5/6] zswap: add to mm/ On 01/29/2013 12:27 AM, Minchan Kim wrote: First feeling is it's simple and nice approach. Although we have some problems to decide policy

Re: [PATCHv3 5/6] zswap: add to mm/

2013-01-29 Thread Minchan Kim
On Tue, Jan 29, 2013 at 11:26:48AM -0600, Seth Jennings wrote: > On 01/29/2013 12:27 AM, Minchan Kim wrote: > > First feeling is it's simple and nice approach. > > Although we have some problems to decide policy, it could solve by later > > patch > > so I hope we make basic infrasture more solid

Re: [PATCHv3 5/6] zswap: add to mm/

2013-01-29 Thread Seth Jennings
On 01/29/2013 12:27 AM, Minchan Kim wrote: > On Mon, Jan 28, 2013 at 03:49:26PM -0600, Seth Jennings wrote: >> +/* >> +* tunables >> +**/ >> +/* Enable/disable zswap (enabled by default, fixed at boot for now) */ >> +static bool

Re: [PATCHv3 5/6] zswap: add to mm/

2013-01-29 Thread Seth Jennings
On 01/29/2013 12:27 AM, Minchan Kim wrote: > First feeling is it's simple and nice approach. > Although we have some problems to decide policy, it could solve by later patch > so I hope we make basic infrasture more solid by lots of comment. Thanks very much for the review! > > There are two

Re: [PATCHv3 5/6] zswap: add to mm/

2013-01-29 Thread Seth Jennings
On 01/29/2013 12:27 AM, Minchan Kim wrote: First feeling is it's simple and nice approach. Although we have some problems to decide policy, it could solve by later patch so I hope we make basic infrasture more solid by lots of comment. Thanks very much for the review! There are two things

Re: [PATCHv3 5/6] zswap: add to mm/

2013-01-29 Thread Seth Jennings
On 01/29/2013 12:27 AM, Minchan Kim wrote: snip On Mon, Jan 28, 2013 at 03:49:26PM -0600, Seth Jennings wrote: snip +/* +* tunables +**/ +/* Enable/disable zswap (enabled by default, fixed at boot for now) */ +static bool

Re: [PATCHv3 5/6] zswap: add to mm/

2013-01-29 Thread Minchan Kim
On Tue, Jan 29, 2013 at 11:26:48AM -0600, Seth Jennings wrote: On 01/29/2013 12:27 AM, Minchan Kim wrote: First feeling is it's simple and nice approach. Although we have some problems to decide policy, it could solve by later patch so I hope we make basic infrasture more solid by lots

Re: [PATCHv3 5/6] zswap: add to mm/

2013-01-28 Thread Minchan Kim
First feeling is it's simple and nice approach. Although we have some problems to decide policy, it could solve by later patch so I hope we make basic infrasture more solid by lots of comment. There are two things to review hard. 1. data structure life - when any data structure is died by whom?

[PATCHv3 5/6] zswap: add to mm/

2013-01-28 Thread Seth Jennings
zswap is a thin compression backend for frontswap. It receives pages from frontswap and attempts to store them in a compressed memory pool, resulting in an effective partial memory reclaim and dramatically reduced swap device I/O. Additional, in most cases, pages can be retrieved from this

[PATCHv3 5/6] zswap: add to mm/

2013-01-28 Thread Seth Jennings
zswap is a thin compression backend for frontswap. It receives pages from frontswap and attempts to store them in a compressed memory pool, resulting in an effective partial memory reclaim and dramatically reduced swap device I/O. Additional, in most cases, pages can be retrieved from this

Re: [PATCHv3 5/6] zswap: add to mm/

2013-01-28 Thread Minchan Kim
First feeling is it's simple and nice approach. Although we have some problems to decide policy, it could solve by later patch so I hope we make basic infrasture more solid by lots of comment. There are two things to review hard. 1. data structure life - when any data structure is died by whom?