Re: [Patch v8 2/2] dmaengine: add Qualcomm BAM dma driver

2014-03-07 Thread Andy Gross
On Mon, Mar 03, 2014 at 09:38:03AM +, Shevchenko, Andriy wrote: > > + if (IS_ERR(bdev->bamclk)) > > + return PTR_ERR(bdev->bamclk); > > + > > + ret = clk_prepare_enable(bdev->bamclk); > > + if (ret) { > > + dev_err(bdev->dev, "failed to prepare/enable clock\n"); >

Re: [Patch v8 2/2] dmaengine: add Qualcomm BAM dma driver

2014-03-07 Thread Andy Gross
On Sat, Mar 08, 2014 at 12:29:49AM +0200, Stanimir Vabanov wrote: > > +#define BAM_IRQ_SRCS_EE(pipe) (0x0800 + ((pipe) * 0x80)) > > +#define BAM_IRQ_SRCS_MSK_EE(pipe) (0x0804 + ((pipe) * 0x80)) > > s/pipe/ee ? > Ah good catch. I'll fix that. > > +struct bam_chan { > > + struct

Re: [Patch v8 2/2] dmaengine: add Qualcomm BAM dma driver

2014-03-07 Thread Stanimir Vabanov
Hi Andy, Thanks for the patch. > +#define BAM_IRQ_SRCS_EE(pipe)(0x0800 + ((pipe) * 0x80)) > +#define BAM_IRQ_SRCS_MSK_EE(pipe)(0x0804 + ((pipe) * 0x80)) s/pipe/ee ? > +struct bam_chan { > + struct virt_dma_chan vc; > + > + struct bam_device *bdev; > + > + /*

Re: [Patch v8 2/2] dmaengine: add Qualcomm BAM dma driver

2014-03-07 Thread Stanimir Vabanov
Hi Andy, Thanks for the patch. snip +#define BAM_IRQ_SRCS_EE(pipe)(0x0800 + ((pipe) * 0x80)) +#define BAM_IRQ_SRCS_MSK_EE(pipe)(0x0804 + ((pipe) * 0x80)) s/pipe/ee ? snip +struct bam_chan { + struct virt_dma_chan vc; + + struct bam_device *bdev; + + /*

Re: [Patch v8 2/2] dmaengine: add Qualcomm BAM dma driver

2014-03-07 Thread Andy Gross
On Sat, Mar 08, 2014 at 12:29:49AM +0200, Stanimir Vabanov wrote: +#define BAM_IRQ_SRCS_EE(pipe) (0x0800 + ((pipe) * 0x80)) +#define BAM_IRQ_SRCS_MSK_EE(pipe) (0x0804 + ((pipe) * 0x80)) s/pipe/ee ? Ah good catch. I'll fix that. +struct bam_chan { + struct

Re: [Patch v8 2/2] dmaengine: add Qualcomm BAM dma driver

2014-03-07 Thread Andy Gross
On Mon, Mar 03, 2014 at 09:38:03AM +, Shevchenko, Andriy wrote: snip + if (IS_ERR(bdev-bamclk)) + return PTR_ERR(bdev-bamclk); + + ret = clk_prepare_enable(bdev-bamclk); + if (ret) { + dev_err(bdev-dev, failed to prepare/enable clock\n); +

Re: [Patch v8 2/2] dmaengine: add Qualcomm BAM dma driver

2014-03-03 Thread Shevchenko, Andriy
On Mon, 2014-03-03 at 00:30 -0600, Andy Gross wrote: > Add the DMA engine driver for the QCOM Bus Access Manager (BAM) DMA controller > found in the MSM 8x74 platforms. > > Each BAM DMA device is associated with a specific on-chip peripheral. Each > channel provides a uni-directional data

Re: [Patch v8 2/2] dmaengine: add Qualcomm BAM dma driver

2014-03-03 Thread Shevchenko, Andriy
On Mon, 2014-03-03 at 00:30 -0600, Andy Gross wrote: Add the DMA engine driver for the QCOM Bus Access Manager (BAM) DMA controller found in the MSM 8x74 platforms. Each BAM DMA device is associated with a specific on-chip peripheral. Each channel provides a uni-directional data transfer

Re: [Patch v8 2/2] dmaengine: add Qualcomm BAM dma driver

2014-03-02 Thread Joe Perches
On Mon, 2014-03-03 at 00:30 -0600, Andy Gross wrote: > Add the DMA engine driver for the QCOM Bus Access Manager (BAM) DMA controller > found in the MSM 8x74 platforms. > > Each BAM DMA device is associated with a specific on-chip peripheral. Each > channel provides a uni-directional data

[Patch v8 2/2] dmaengine: add Qualcomm BAM dma driver

2014-03-02 Thread Andy Gross
Add the DMA engine driver for the QCOM Bus Access Manager (BAM) DMA controller found in the MSM 8x74 platforms. Each BAM DMA device is associated with a specific on-chip peripheral. Each channel provides a uni-directional data transfer engine that is capable of transferring data between the

[Patch v8 2/2] dmaengine: add Qualcomm BAM dma driver

2014-03-02 Thread Andy Gross
Add the DMA engine driver for the QCOM Bus Access Manager (BAM) DMA controller found in the MSM 8x74 platforms. Each BAM DMA device is associated with a specific on-chip peripheral. Each channel provides a uni-directional data transfer engine that is capable of transferring data between the

Re: [Patch v8 2/2] dmaengine: add Qualcomm BAM dma driver

2014-03-02 Thread Joe Perches
On Mon, 2014-03-03 at 00:30 -0600, Andy Gross wrote: Add the DMA engine driver for the QCOM Bus Access Manager (BAM) DMA controller found in the MSM 8x74 platforms. Each BAM DMA device is associated with a specific on-chip peripheral. Each channel provides a uni-directional data transfer