Re: [Pv-drivers] [PATCH 01/12] VMCI: context implementation.

2012-11-22 Thread Joe Perches
On Wed, 2012-11-21 at 13:29 -0800, Dmitry Torokhov wrote: > Hi Joe, Howdy. > On Wed, Nov 21, 2012 at 01:04:46PM -0800, Joe Perches wrote: > > On Wed, 2012-11-21 at 12:31 -0800, George Zhang wrote: > > > + context = kzalloc(sizeof(*context), GFP_KERNEL); > > > + if (!context) { > > > +

Re: [Pv-drivers] [PATCH 01/12] VMCI: context implementation.

2012-11-22 Thread Dmitry Torokhov
Hi Joe, On Wed, Nov 21, 2012 at 01:04:46PM -0800, Joe Perches wrote: > On Wed, 2012-11-21 at 12:31 -0800, George Zhang wrote: > > + context = kzalloc(sizeof(*context), GFP_KERNEL); > > + if (!context) { > > + pr_warn("Failed to allocate memory for VMCI context.\n"); > > OOM logging

Re: [Pv-drivers] [PATCH 01/12] VMCI: context implementation.

2012-11-22 Thread Dmitry Torokhov
Hi Joe, On Wed, Nov 21, 2012 at 01:04:46PM -0800, Joe Perches wrote: On Wed, 2012-11-21 at 12:31 -0800, George Zhang wrote: + context = kzalloc(sizeof(*context), GFP_KERNEL); + if (!context) { + pr_warn(Failed to allocate memory for VMCI context.\n); OOM logging messages

Re: [Pv-drivers] [PATCH 01/12] VMCI: context implementation.

2012-11-22 Thread Joe Perches
On Wed, 2012-11-21 at 13:29 -0800, Dmitry Torokhov wrote: Hi Joe, Howdy. On Wed, Nov 21, 2012 at 01:04:46PM -0800, Joe Perches wrote: On Wed, 2012-11-21 at 12:31 -0800, George Zhang wrote: + context = kzalloc(sizeof(*context), GFP_KERNEL); + if (!context) { + pr_warn(Failed

Re: [Pv-drivers] [PATCH 01/12] VMCI: context implementation.

2012-11-21 Thread Andy King
Hi Joe, > Just some trivial notes. Thanks for taking a look! > > + pr_warn("Failed to allocate memory for VMCI context.\n"); > > OOM logging messages aren't necessary as alloc failures > are already logged with a stack trace. Noted, we'll remove all such occurrences. > Maybe just

Re: [Pv-drivers] [PATCH 01/12] VMCI: context implementation.

2012-11-21 Thread Andy King
Hi Joe, Just some trivial notes. Thanks for taking a look! + pr_warn(Failed to allocate memory for VMCI context.\n); OOM logging messages aren't necessary as alloc failures are already logged with a stack trace. Noted, we'll remove all such occurrences. Maybe just use

Re: [Pv-drivers] [PATCH 01/12] VMCI: context implementation.

2012-10-30 Thread Dmitry Torokhov
On Tuesday, October 30, 2012 08:46:52 AM Greg KH wrote: > On Mon, Oct 29, 2012 at 09:01:40PM -0700, Dmitry Torokhov wrote: > > Hi Greg, > > > > On Mon, Oct 29, 2012 at 07:10:58PM -0700, Greg KH wrote: > > > On Mon, Oct 29, 2012 at 06:03:42PM -0700, George Zhang wrote: > > > > +/* > > > > + *

Re: [Pv-drivers] [PATCH 01/12] VMCI: context implementation.

2012-10-30 Thread Greg KH
On Mon, Oct 29, 2012 at 09:01:40PM -0700, Dmitry Torokhov wrote: > Hi Greg, > > On Mon, Oct 29, 2012 at 07:10:58PM -0700, Greg KH wrote: > > On Mon, Oct 29, 2012 at 06:03:42PM -0700, George Zhang wrote: > > > +/* > > > + * Releases the VMCI context. If this is the last reference to > > > + * the

Re: [Pv-drivers] [PATCH 01/12] VMCI: context implementation.

2012-10-30 Thread Greg KH
On Mon, Oct 29, 2012 at 09:01:40PM -0700, Dmitry Torokhov wrote: Hi Greg, On Mon, Oct 29, 2012 at 07:10:58PM -0700, Greg KH wrote: On Mon, Oct 29, 2012 at 06:03:42PM -0700, George Zhang wrote: +/* + * Releases the VMCI context. If this is the last reference to + * the context it

Re: [Pv-drivers] [PATCH 01/12] VMCI: context implementation.

2012-10-30 Thread Dmitry Torokhov
On Tuesday, October 30, 2012 08:46:52 AM Greg KH wrote: On Mon, Oct 29, 2012 at 09:01:40PM -0700, Dmitry Torokhov wrote: Hi Greg, On Mon, Oct 29, 2012 at 07:10:58PM -0700, Greg KH wrote: On Mon, Oct 29, 2012 at 06:03:42PM -0700, George Zhang wrote: +/* + * Releases the VMCI

Re: [Pv-drivers] [PATCH 01/12] VMCI: context implementation.

2012-10-29 Thread Dmitry Torokhov
Hi Greg, On Mon, Oct 29, 2012 at 07:10:58PM -0700, Greg KH wrote: > On Mon, Oct 29, 2012 at 06:03:42PM -0700, George Zhang wrote: > > +/* > > + * Releases the VMCI context. If this is the last reference to > > + * the context it will be deallocated. A context is created with > > + * a reference

Re: [Pv-drivers] [PATCH 01/12] VMCI: context implementation.

2012-10-29 Thread Dmitry Torokhov
Hi Greg, On Mon, Oct 29, 2012 at 07:10:58PM -0700, Greg KH wrote: On Mon, Oct 29, 2012 at 06:03:42PM -0700, George Zhang wrote: +/* + * Releases the VMCI context. If this is the last reference to + * the context it will be deallocated. A context is created with + * a reference count of