Re: [RESEND][PATCH v2] firmware/psci: add support for SYSTEM_RESET2

2019-04-12 Thread Sudeep Holla
On Thu, Apr 11, 2019 at 09:26:37PM +0300, Aaro Koskinen wrote: > Hi, > > On Thu, Apr 11, 2019 at 05:49:36PM +0100, Sudeep Holla wrote: > > On Thu, Apr 11, 2019 at 11:42:28AM +, Koskinen, Aaro (Nokia - FI/Espoo) > > wrote: > > > From: Sudeep Holla [sudeep.ho...@arm.com]: > > > > static void

Re: [RESEND][PATCH v2] firmware/psci: add support for SYSTEM_RESET2

2019-04-11 Thread Aaro Koskinen
Hi, On Thu, Apr 11, 2019 at 05:49:36PM +0100, Sudeep Holla wrote: > On Thu, Apr 11, 2019 at 11:42:28AM +, Koskinen, Aaro (Nokia - FI/Espoo) > wrote: > > From: Sudeep Holla [sudeep.ho...@arm.com]: > > > static void psci_sys_reset(enum reboot_mode reboot_mode, const char *cmd) > > > { > > >

Re: [RESEND][PATCH v2] firmware/psci: add support for SYSTEM_RESET2

2019-04-11 Thread Sudeep Holla
On Thu, Apr 11, 2019 at 11:42:28AM +, Koskinen, Aaro (Nokia - FI/Espoo) wrote: > Hi, > > From: Sudeep Holla [sudeep.ho...@arm.com]: > > static void psci_sys_reset(enum reboot_mode reboot_mode, const char *cmd) > > { > > + if ((reboot_mode == REBOOT_WARM || reboot_mode == REBOOT_SOFT)

Re: [RESEND][PATCH v2] firmware/psci: add support for SYSTEM_RESET2

2019-04-11 Thread Sudeep Holla
On Thu, Apr 11, 2019 at 12:03:04PM +0100, Mark Rutland wrote: > On Thu, Apr 11, 2019 at 11:33:46AM +0100, Sudeep Holla wrote: > > PSCI v1.1 introduced SYSTEM_RESET2 to allow both architectural resets > > where the semantics are described by the PSCI specification itself as > > well as

RE: [RESEND][PATCH v2] firmware/psci: add support for SYSTEM_RESET2

2019-04-11 Thread Koskinen, Aaro (Nokia - FI/Espoo)
Hi, From: Sudeep Holla [sudeep.ho...@arm.com]: > static void psci_sys_reset(enum reboot_mode reboot_mode, const char *cmd) > { > + if ((reboot_mode == REBOOT_WARM || reboot_mode == REBOOT_SOFT) && I would omit the REBOOT_SOFT here. > + psci_system_reset2_supported) > +

Re: [RESEND][PATCH v2] firmware/psci: add support for SYSTEM_RESET2

2019-04-11 Thread Mark Rutland
On Thu, Apr 11, 2019 at 11:33:46AM +0100, Sudeep Holla wrote: > PSCI v1.1 introduced SYSTEM_RESET2 to allow both architectural resets > where the semantics are described by the PSCI specification itself as > well as vendor-specific resets. Currently only system warm reset > semantics is defined as

[RESEND][PATCH v2] firmware/psci: add support for SYSTEM_RESET2

2019-04-11 Thread Sudeep Holla
PSCI v1.1 introduced SYSTEM_RESET2 to allow both architectural resets where the semantics are described by the PSCI specification itself as well as vendor-specific resets. Currently only system warm reset semantics is defined as part of architectural resets by the specification. This patch