Re: [RESEND] [PATCH] fix invalidate_inode_pages2_range not to clear ret

2008-02-21 Thread Jeff Moyer
Hisashi Hifumi <[EMAIL PROTECTED]> writes: > Hi Jeff. > >> >>I agree with the patch (and I see Andrew already accepted it). Do you >>have a reproducer for this problem? > > Do you want to know the way of failing invalidate_complete_page2() ? I was hoping for a test program that shows the

Re: [RESEND] [PATCH] fix invalidate_inode_pages2_range not to clear ret

2008-02-21 Thread Jeff Moyer
Hisashi Hifumi [EMAIL PROTECTED] writes: Hi Jeff. I agree with the patch (and I see Andrew already accepted it). Do you have a reproducer for this problem? Do you want to know the way of failing invalidate_complete_page2() ? I was hoping for a test program that shows the problem. Looking

Re: [RESEND] [PATCH] fix invalidate_inode_pages2_range not to clear ret

2008-02-20 Thread Hisashi Hifumi
Hi Jeff. > >I agree with the patch (and I see Andrew already accepted it). Do you >have a reproducer for this problem? Do you want to know the way of failing invalidate_complete_page2() ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [RESEND] [PATCH] fix invalidate_inode_pages2_range not to clear ret

2008-02-20 Thread Jeff Moyer
Hisashi Hifumi <[EMAIL PROTECTED]> writes: > Hi Andrew. > > DIO invalidates page cache through invalidate_inode_pages2_range(). > invalidate_inode_pages2_range() sets ret=-EIO when invalidate_complete_page2() > fails, but this ret is cleared if do_launder_page() succeed on a page of next >

Re: [RESEND] [PATCH] fix invalidate_inode_pages2_range not to clear ret

2008-02-20 Thread Jeff Moyer
Hisashi Hifumi [EMAIL PROTECTED] writes: Hi Andrew. DIO invalidates page cache through invalidate_inode_pages2_range(). invalidate_inode_pages2_range() sets ret=-EIO when invalidate_complete_page2() fails, but this ret is cleared if do_launder_page() succeed on a page of next index. In

Re: [RESEND] [PATCH] fix invalidate_inode_pages2_range not to clear ret

2008-02-20 Thread Hisashi Hifumi
Hi Jeff. I agree with the patch (and I see Andrew already accepted it). Do you have a reproducer for this problem? Do you want to know the way of failing invalidate_complete_page2() ? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

[RESEND] [PATCH] fix invalidate_inode_pages2_range not to clear ret

2008-02-14 Thread Hisashi Hifumi
Hi Andrew. DIO invalidates page cache through invalidate_inode_pages2_range(). invalidate_inode_pages2_range() sets ret=-EIO when invalidate_complete_page2() fails, but this ret is cleared if do_launder_page() succeed on a page of next index. In this case, dio is carried out even if

[RESEND] [PATCH] fix invalidate_inode_pages2_range not to clear ret

2008-02-14 Thread Hisashi Hifumi
Hi Andrew. DIO invalidates page cache through invalidate_inode_pages2_range(). invalidate_inode_pages2_range() sets ret=-EIO when invalidate_complete_page2() fails, but this ret is cleared if do_launder_page() succeed on a page of next index. In this case, dio is carried out even if