Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-07-27 Thread Ludovic Desroches
On Mon, Jul 27, 2015 at 11:43:52AM +0200, Linus Walleij wrote: > On Wed, Jul 15, 2015 at 9:46 AM, Ludovic Desroches > wrote: > > On Tue, Jul 14, 2015 at 07:57:49AM +0200, Sascha Hauer wrote: > >> > >> Note that in the recently introduced Mediatek pinctrl driver we used > >> 'pinmux' for the

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-07-27 Thread Linus Walleij
On Wed, Jul 15, 2015 at 9:46 AM, Ludovic Desroches wrote: > On Tue, Jul 14, 2015 at 07:57:49AM +0200, Sascha Hauer wrote: >> >> Note that in the recently introduced Mediatek pinctrl driver we used >> 'pinmux' for the property that you name 'pins' here. We probably want to >> use the same name. >

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-07-27 Thread Ludovic Desroches
On Mon, Jul 27, 2015 at 11:43:52AM +0200, Linus Walleij wrote: On Wed, Jul 15, 2015 at 9:46 AM, Ludovic Desroches ludovic.desroc...@atmel.com wrote: On Tue, Jul 14, 2015 at 07:57:49AM +0200, Sascha Hauer wrote: Note that in the recently introduced Mediatek pinctrl driver we used 'pinmux'

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-07-27 Thread Linus Walleij
On Wed, Jul 15, 2015 at 9:46 AM, Ludovic Desroches ludovic.desroc...@atmel.com wrote: On Tue, Jul 14, 2015 at 07:57:49AM +0200, Sascha Hauer wrote: Note that in the recently introduced Mediatek pinctrl driver we used 'pinmux' for the property that you name 'pins' here. We probably want to use

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-07-15 Thread Ludovic Desroches
On Wed, Jul 15, 2015 at 09:46:42AM +0200, Ludovic Desroches wrote: > This driver fits most of my needs but I didn't do it in this way for the > two previous reasons. If it is not an issue to add a new > dt_node_to_map() implementation which should be quite close to the > mediatek one, let's do it.

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-07-15 Thread Ludovic Desroches
On Tue, Jul 14, 2015 at 07:57:49AM +0200, Sascha Hauer wrote: > On Thu, Jun 18, 2015 at 02:33:48PM +0200, Ludovic Desroches wrote: > > On Wed, Jun 17, 2015 at 09:55:56AM -0600, Stephen Warren wrote: > > > On 06/17/2015 06:38 AM, Ludovic Desroches wrote: > > > >Hi Stephen, > > > > > > > >On Mon,

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-07-15 Thread Ludovic Desroches
On Tue, Jul 14, 2015 at 07:57:49AM +0200, Sascha Hauer wrote: On Thu, Jun 18, 2015 at 02:33:48PM +0200, Ludovic Desroches wrote: On Wed, Jun 17, 2015 at 09:55:56AM -0600, Stephen Warren wrote: On 06/17/2015 06:38 AM, Ludovic Desroches wrote: Hi Stephen, On Mon, Jun 15, 2015 at

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-07-15 Thread Ludovic Desroches
On Wed, Jul 15, 2015 at 09:46:42AM +0200, Ludovic Desroches wrote: This driver fits most of my needs but I didn't do it in this way for the two previous reasons. If it is not an issue to add a new dt_node_to_map() implementation which should be quite close to the mediatek one, let's do it.

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-07-14 Thread Sascha Hauer
On Mon, Jul 13, 2015 at 02:07:45PM +0200, Linus Walleij wrote: > On Tue, Jun 30, 2015 at 11:17 AM, Nicolas Ferre > wrote: > > > - no agreement on 3 points: > > 1/ ways to use groups in generic pinctrl > > 2/ ways to describe a comprehensive configuration in device tree > > 3/ readability of a

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-07-14 Thread Sascha Hauer
On Mon, Jul 13, 2015 at 02:07:45PM +0200, Linus Walleij wrote: On Tue, Jun 30, 2015 at 11:17 AM, Nicolas Ferre nicolas.fe...@atmel.com wrote: - no agreement on 3 points: 1/ ways to use groups in generic pinctrl 2/ ways to describe a comprehensive configuration in device tree 3/

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-07-13 Thread Sascha Hauer
On Thu, Jun 18, 2015 at 02:33:48PM +0200, Ludovic Desroches wrote: > On Wed, Jun 17, 2015 at 09:55:56AM -0600, Stephen Warren wrote: > > On 06/17/2015 06:38 AM, Ludovic Desroches wrote: > > >Hi Stephen, > > > > > >On Mon, Jun 15, 2015 at 09:58:05AM -0600, Stephen Warren wrote: > > >>On 06/10/2015

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-07-13 Thread Linus Walleij
On Wed, Jun 17, 2015 at 2:38 PM, Ludovic Desroches wrote: > It is not the first time, there are discussions about it. Sascha sent a > patch which fits part of my needs: > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-January/318452.html It would be helpful to have Sascha's review

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-07-13 Thread Linus Walleij
On Tue, Jun 30, 2015 at 11:17 AM, Nicolas Ferre wrote: > - no agreement on 3 points: > 1/ ways to use groups in generic pinctrl > 2/ ways to describe a comprehensive configuration in device tree > 3/ readability of a sysfs information > > - no way out on the generic pinctrl little changes that

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-07-13 Thread Linus Walleij
On Wed, Jun 17, 2015 at 2:38 PM, Ludovic Desroches ludovic.desroc...@atmel.com wrote: It is not the first time, there are discussions about it. Sascha sent a patch which fits part of my needs: http://lists.infradead.org/pipermail/linux-arm-kernel/2015-January/318452.html It would be helpful

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-07-13 Thread Linus Walleij
On Tue, Jun 30, 2015 at 11:17 AM, Nicolas Ferre nicolas.fe...@atmel.com wrote: - no agreement on 3 points: 1/ ways to use groups in generic pinctrl 2/ ways to describe a comprehensive configuration in device tree 3/ readability of a sysfs information - no way out on the generic pinctrl

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-07-13 Thread Sascha Hauer
On Thu, Jun 18, 2015 at 02:33:48PM +0200, Ludovic Desroches wrote: On Wed, Jun 17, 2015 at 09:55:56AM -0600, Stephen Warren wrote: On 06/17/2015 06:38 AM, Ludovic Desroches wrote: Hi Stephen, On Mon, Jun 15, 2015 at 09:58:05AM -0600, Stephen Warren wrote: On 06/10/2015 09:04 AM,

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-06-30 Thread Nicolas Ferre
Le 17/06/2015 17:55, Stephen Warren a écrit : > On 06/17/2015 06:38 AM, Ludovic Desroches wrote: [..] >> I have sent patches months ago trying to improve things by having >> something more flexible. I don't think I introduce too big changes. >> The only answers I got were from people thinking

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-06-30 Thread Nicolas Ferre
Le 17/06/2015 17:55, Stephen Warren a écrit : On 06/17/2015 06:38 AM, Ludovic Desroches wrote: [..] I have sent patches months ago trying to improve things by having something more flexible. I don't think I introduce too big changes. The only answers I got were from people thinking that

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-06-18 Thread Ludovic Desroches
On Wed, Jun 17, 2015 at 09:55:56AM -0600, Stephen Warren wrote: > On 06/17/2015 06:38 AM, Ludovic Desroches wrote: > >Hi Stephen, > > > >On Mon, Jun 15, 2015 at 09:58:05AM -0600, Stephen Warren wrote: > >>On 06/10/2015 09:04 AM, Ludovic Desroches wrote: > >>>When having a controller which allows

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-06-18 Thread Ludovic Desroches
On Wed, Jun 17, 2015 at 09:55:56AM -0600, Stephen Warren wrote: On 06/17/2015 06:38 AM, Ludovic Desroches wrote: Hi Stephen, On Mon, Jun 15, 2015 at 09:58:05AM -0600, Stephen Warren wrote: On 06/10/2015 09:04 AM, Ludovic Desroches wrote: When having a controller which allows per pin muxing,

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-06-17 Thread Stephen Warren
On 06/17/2015 06:38 AM, Ludovic Desroches wrote: Hi Stephen, On Mon, Jun 15, 2015 at 09:58:05AM -0600, Stephen Warren wrote: On 06/10/2015 09:04 AM, Ludovic Desroches wrote: When having a controller which allows per pin muxing, declaring with which groups a function can be used is a useless

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-06-17 Thread Ludovic Desroches
Hi Stephen, On Mon, Jun 15, 2015 at 09:58:05AM -0600, Stephen Warren wrote: > On 06/10/2015 09:04 AM, Ludovic Desroches wrote: > >When having a controller which allows per pin muxing, declaring with > >which groups a function can be used is a useless constraint since groups > >are something

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-06-17 Thread Ludovic Desroches
Hi Stephen, On Mon, Jun 15, 2015 at 09:58:05AM -0600, Stephen Warren wrote: On 06/10/2015 09:04 AM, Ludovic Desroches wrote: When having a controller which allows per pin muxing, declaring with which groups a function can be used is a useless constraint since groups are something virtual.

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-06-17 Thread Stephen Warren
On 06/17/2015 06:38 AM, Ludovic Desroches wrote: Hi Stephen, On Mon, Jun 15, 2015 at 09:58:05AM -0600, Stephen Warren wrote: On 06/10/2015 09:04 AM, Ludovic Desroches wrote: When having a controller which allows per pin muxing, declaring with which groups a function can be used is a useless

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-06-15 Thread Stephen Warren
On 06/10/2015 09:04 AM, Ludovic Desroches wrote: When having a controller which allows per pin muxing, declaring with which groups a function can be used is a useless constraint since groups are something virtual. This isn't true. Irrespective of whether a particular piece of pinmux HW can

Re: [RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-06-15 Thread Stephen Warren
On 06/10/2015 09:04 AM, Ludovic Desroches wrote: When having a controller which allows per pin muxing, declaring with which groups a function can be used is a useless constraint since groups are something virtual. This isn't true. Irrespective of whether a particular piece of pinmux HW can

[RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-06-10 Thread Ludovic Desroches
When having a controller which allows per pin muxing, declaring with which groups a function can be used is a useless constraint since groups are something virtual. Signed-off-by: Ludovic Desroches --- drivers/pinctrl/pinmux.c | 58 +++---

[RESEND PATCH 1/2] pinctrl: change function behavior for per pin muxing controllers

2015-06-10 Thread Ludovic Desroches
When having a controller which allows per pin muxing, declaring with which groups a function can be used is a useless constraint since groups are something virtual. Signed-off-by: Ludovic Desroches ludovic.desroc...@atmel.com --- drivers/pinctrl/pinmux.c | 58