Re: [RFC/PATCH] ftrace: add set_graph_notrace filter

2013-10-13 Thread Namhyung Kim
Hi, On Fri, 11 Oct 2013 08:31:45 -0400, Steven Rostedt wrote: > On Fri, 11 Oct 2013 17:19:46 +0900 > Namhyung Kim wrote: > >> Hi Steve, >> >> On Fri, 11 Oct 2013 00:17:17 -0400, Steven Rostedt wrote: >> > Sorry for the very late reply, finally got some time to look at other >> > peoples code.

Re: [RFC/PATCH] ftrace: add set_graph_notrace filter

2013-10-13 Thread Namhyung Kim
Hi, On Fri, 11 Oct 2013 08:31:45 -0400, Steven Rostedt wrote: On Fri, 11 Oct 2013 17:19:46 +0900 Namhyung Kim namhy...@kernel.org wrote: Hi Steve, On Fri, 11 Oct 2013 00:17:17 -0400, Steven Rostedt wrote: Sorry for the very late reply, finally got some time to look at other peoples

Re: [RFC/PATCH] ftrace: add set_graph_notrace filter

2013-10-11 Thread Steven Rostedt
On Fri, 11 Oct 2013 17:19:46 +0900 Namhyung Kim wrote: > Hi Steve, > > On Fri, 11 Oct 2013 00:17:17 -0400, Steven Rostedt wrote: > > Sorry for the very late reply, finally got some time to look at other > > peoples code. > > Thank you for taking your time to review this carefully. :) Sorry

Re: [RFC/PATCH] ftrace: add set_graph_notrace filter

2013-10-11 Thread Steven Rostedt
On Fri, 11 Oct 2013 09:21:56 +0200 Heiko Carstens wrote: > > Steven Rostedt noted that s390 is the only architecture which calls > ftrace_push_return_trace() before ftrace_graph_entry() and therefore has I don't know if s390 is the only arch. I didn't finish reading all the arch specific code

Re: [RFC/PATCH] ftrace: add set_graph_notrace filter

2013-10-11 Thread Heiko Carstens
On Fri, Oct 11, 2013 at 05:34:19PM +0900, Namhyung Kim wrote: > Hi Heiko, > > On Fri, 11 Oct 2013 09:21:56 +0200, Heiko Carstens wrote: > > On Fri, Oct 11, 2013 at 12:17:17AM -0400, Steven Rostedt wrote: > >> Isn't there a way we could pass the state? Hmm, I think we could use > >> depth to do

Re: [RFC/PATCH] ftrace: add set_graph_notrace filter

2013-10-11 Thread Namhyung Kim
Hi Heiko, On Fri, 11 Oct 2013 09:21:56 +0200, Heiko Carstens wrote: > On Fri, Oct 11, 2013 at 12:17:17AM -0400, Steven Rostedt wrote: >> Isn't there a way we could pass the state? Hmm, I think we could use >> depth to do that. As depth is a pointer to trace.depth and not used >> before then. We

Re: [RFC/PATCH] ftrace: add set_graph_notrace filter

2013-10-11 Thread Namhyung Kim
Hi Steve, On Fri, 11 Oct 2013 00:17:17 -0400, Steven Rostedt wrote: > Sorry for the very late reply, finally got some time to look at other > peoples code. Thank you for taking your time to review this carefully. :) > > On Tue, 3 Sep 2013 14:05:08 +0900 > Namhyung Kim wrote: > >> From:

Re: [RFC/PATCH] ftrace: add set_graph_notrace filter

2013-10-11 Thread Heiko Carstens
On Fri, Oct 11, 2013 at 12:17:17AM -0400, Steven Rostedt wrote: > Isn't there a way we could pass the state? Hmm, I think we could use > depth to do that. As depth is a pointer to trace.depth and not used > before then. We could make it negative and then check that. > > /me looks at other archs.

Re: [RFC/PATCH] ftrace: add set_graph_notrace filter

2013-10-11 Thread Steven Rostedt
On Fri, 11 Oct 2013 09:21:56 +0200 Heiko Carstens heiko.carst...@de.ibm.com wrote: Steven Rostedt noted that s390 is the only architecture which calls ftrace_push_return_trace() before ftrace_graph_entry() and therefore has I don't know if s390 is the only arch. I didn't finish reading all

Re: [RFC/PATCH] ftrace: add set_graph_notrace filter

2013-10-11 Thread Steven Rostedt
On Fri, 11 Oct 2013 17:19:46 +0900 Namhyung Kim namhy...@kernel.org wrote: Hi Steve, On Fri, 11 Oct 2013 00:17:17 -0400, Steven Rostedt wrote: Sorry for the very late reply, finally got some time to look at other peoples code. Thank you for taking your time to review this carefully. :)

Re: [RFC/PATCH] ftrace: add set_graph_notrace filter

2013-10-11 Thread Heiko Carstens
On Fri, Oct 11, 2013 at 12:17:17AM -0400, Steven Rostedt wrote: Isn't there a way we could pass the state? Hmm, I think we could use depth to do that. As depth is a pointer to trace.depth and not used before then. We could make it negative and then check that. /me looks at other archs.

Re: [RFC/PATCH] ftrace: add set_graph_notrace filter

2013-10-11 Thread Namhyung Kim
Hi Steve, On Fri, 11 Oct 2013 00:17:17 -0400, Steven Rostedt wrote: Sorry for the very late reply, finally got some time to look at other peoples code. Thank you for taking your time to review this carefully. :) On Tue, 3 Sep 2013 14:05:08 +0900 Namhyung Kim namhy...@kernel.org wrote:

Re: [RFC/PATCH] ftrace: add set_graph_notrace filter

2013-10-11 Thread Namhyung Kim
Hi Heiko, On Fri, 11 Oct 2013 09:21:56 +0200, Heiko Carstens wrote: On Fri, Oct 11, 2013 at 12:17:17AM -0400, Steven Rostedt wrote: Isn't there a way we could pass the state? Hmm, I think we could use depth to do that. As depth is a pointer to trace.depth and not used before then. We could

Re: [RFC/PATCH] ftrace: add set_graph_notrace filter

2013-10-11 Thread Heiko Carstens
On Fri, Oct 11, 2013 at 05:34:19PM +0900, Namhyung Kim wrote: Hi Heiko, On Fri, 11 Oct 2013 09:21:56 +0200, Heiko Carstens wrote: On Fri, Oct 11, 2013 at 12:17:17AM -0400, Steven Rostedt wrote: Isn't there a way we could pass the state? Hmm, I think we could use depth to do that. As

Re: [RFC/PATCH] ftrace: add set_graph_notrace filter

2013-10-10 Thread Steven Rostedt
Sorry for the very late reply, finally got some time to look at other peoples code. On Tue, 3 Sep 2013 14:05:08 +0900 Namhyung Kim wrote: > From: Namhyung Kim > > The set_graph_notrace filter is analogous to set_ftrace_notrace and > can be used for eliminating uninteresting part of function

Re: [RFC/PATCH] ftrace: add set_graph_notrace filter

2013-10-10 Thread Steven Rostedt
Sorry for the very late reply, finally got some time to look at other peoples code. On Tue, 3 Sep 2013 14:05:08 +0900 Namhyung Kim namhy...@kernel.org wrote: From: Namhyung Kim namhyung@lge.com The set_graph_notrace filter is analogous to set_ftrace_notrace and can be used for

Re: [RFC/PATCH] ftrace: add set_graph_notrace filter

2013-10-09 Thread Steven Rostedt
On Thu, 10 Oct 2013 10:51:54 +0900 Namhyung Kim wrote: > Hi Steve, > > On Mon, 30 Sep 2013 23:58:46 -0400, Steven Rostedt wrote: > > On Mon, 2013-09-30 at 16:04 +0900, Namhyung Kim wrote: > >> Ping! > > > > Ah I missed this patch. And I'm currently traveling. > > > > I'll start testing it when

Re: [RFC/PATCH] ftrace: add set_graph_notrace filter

2013-10-09 Thread Namhyung Kim
Hi Steve, On Mon, 30 Sep 2013 23:58:46 -0400, Steven Rostedt wrote: > On Mon, 2013-09-30 at 16:04 +0900, Namhyung Kim wrote: >> Ping! > > Ah I missed this patch. And I'm currently traveling. > > I'll start testing it when I get back on Friday, but feel free to ping > me again next Monday. Would

Re: [RFC/PATCH] ftrace: add set_graph_notrace filter

2013-10-09 Thread Namhyung Kim
Hi Steve, On Mon, 30 Sep 2013 23:58:46 -0400, Steven Rostedt wrote: On Mon, 2013-09-30 at 16:04 +0900, Namhyung Kim wrote: Ping! Ah I missed this patch. And I'm currently traveling. I'll start testing it when I get back on Friday, but feel free to ping me again next Monday. Would you take

Re: [RFC/PATCH] ftrace: add set_graph_notrace filter

2013-10-09 Thread Steven Rostedt
On Thu, 10 Oct 2013 10:51:54 +0900 Namhyung Kim namhy...@kernel.org wrote: Hi Steve, On Mon, 30 Sep 2013 23:58:46 -0400, Steven Rostedt wrote: On Mon, 2013-09-30 at 16:04 +0900, Namhyung Kim wrote: Ping! Ah I missed this patch. And I'm currently traveling. I'll start testing it

Re: [RFC/PATCH] ftrace: add set_graph_notrace filter

2013-09-30 Thread Steven Rostedt
On Mon, 2013-09-30 at 16:04 +0900, Namhyung Kim wrote: > Ping! Ah I missed this patch. And I'm currently traveling. I'll start testing it when I get back on Friday, but feel free to ping me again next Monday. -- Steve > > On Tue, 3 Sep 2013 14:05:08 +0900, Namhyung Kim wrote: > > From:

Re: [RFC/PATCH] ftrace: add set_graph_notrace filter

2013-09-30 Thread Namhyung Kim
Ping! On Tue, 3 Sep 2013 14:05:08 +0900, Namhyung Kim wrote: > From: Namhyung Kim > > The set_graph_notrace filter is analogous to set_ftrace_notrace and > can be used for eliminating uninteresting part of function graph trace > output. It also works with set_graph_function nicely. > > # cd

Re: [RFC/PATCH] ftrace: add set_graph_notrace filter

2013-09-30 Thread Namhyung Kim
Ping! On Tue, 3 Sep 2013 14:05:08 +0900, Namhyung Kim wrote: From: Namhyung Kim namhyung@lge.com The set_graph_notrace filter is analogous to set_ftrace_notrace and can be used for eliminating uninteresting part of function graph trace output. It also works with set_graph_function

Re: [RFC/PATCH] ftrace: add set_graph_notrace filter

2013-09-30 Thread Steven Rostedt
On Mon, 2013-09-30 at 16:04 +0900, Namhyung Kim wrote: Ping! Ah I missed this patch. And I'm currently traveling. I'll start testing it when I get back on Friday, but feel free to ping me again next Monday. -- Steve On Tue, 3 Sep 2013 14:05:08 +0900, Namhyung Kim wrote: From: Namhyung

[RFC/PATCH] ftrace: add set_graph_notrace filter

2013-09-02 Thread Namhyung Kim
From: Namhyung Kim The set_graph_notrace filter is analogous to set_ftrace_notrace and can be used for eliminating uninteresting part of function graph trace output. It also works with set_graph_function nicely. # cd /sys/kernel/debug/tracing/ # echo do_page_fault > set_graph_function #

[RFC/PATCH] ftrace: add set_graph_notrace filter

2013-09-02 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com The set_graph_notrace filter is analogous to set_ftrace_notrace and can be used for eliminating uninteresting part of function graph trace output. It also works with set_graph_function nicely. # cd /sys/kernel/debug/tracing/ # echo do_page_fault