Re: [RFC][PATCH] kvm: fix a race when closing irq eventfd

2013-02-17 Thread Li Zefan
On 2013/2/18 12:09, Li Zefan wrote: > On 2013/2/18 12:02, Alex Williamson wrote: >> On Mon, 2013-02-18 at 11:13 +0800, Li Zefan wrote: >>> While trying to fix a race when closing cgroup eventfd, I took a look >>> at how kvm deals with this problem, and I found it doesn't. >>> >>> I may be wrong,

Re: [RFC][PATCH] kvm: fix a race when closing irq eventfd

2013-02-17 Thread Alex Williamson
On Mon, 2013-02-18 at 12:09 +0800, Li Zefan wrote: > On 2013/2/18 12:02, Alex Williamson wrote: > > On Mon, 2013-02-18 at 11:13 +0800, Li Zefan wrote: > >> While trying to fix a race when closing cgroup eventfd, I took a look > >> at how kvm deals with this problem, and I found it doesn't. > >> >

Re: [RFC][PATCH] kvm: fix a race when closing irq eventfd

2013-02-17 Thread Li Zefan
On 2013/2/18 12:02, Alex Williamson wrote: > On Mon, 2013-02-18 at 11:13 +0800, Li Zefan wrote: >> While trying to fix a race when closing cgroup eventfd, I took a look >> at how kvm deals with this problem, and I found it doesn't. >> >> I may be wrong, as I don't know kvm code, so correct me if

Re: [RFC][PATCH] kvm: fix a race when closing irq eventfd

2013-02-17 Thread Alex Williamson
On Mon, 2013-02-18 at 11:13 +0800, Li Zefan wrote: > While trying to fix a race when closing cgroup eventfd, I took a look > at how kvm deals with this problem, and I found it doesn't. > > I may be wrong, as I don't know kvm code, so correct me if I'm. > > /* >* Race-free decouple

[RFC][PATCH] kvm: fix a race when closing irq eventfd

2013-02-17 Thread Li Zefan
While trying to fix a race when closing cgroup eventfd, I took a look at how kvm deals with this problem, and I found it doesn't. I may be wrong, as I don't know kvm code, so correct me if I'm. /* * Race-free decouple logic (ordering is critical) */ static void

[RFC][PATCH] kvm: fix a race when closing irq eventfd

2013-02-17 Thread Li Zefan
While trying to fix a race when closing cgroup eventfd, I took a look at how kvm deals with this problem, and I found it doesn't. I may be wrong, as I don't know kvm code, so correct me if I'm. /* * Race-free decouple logic (ordering is critical) */ static void

Re: [RFC][PATCH] kvm: fix a race when closing irq eventfd

2013-02-17 Thread Alex Williamson
On Mon, 2013-02-18 at 11:13 +0800, Li Zefan wrote: While trying to fix a race when closing cgroup eventfd, I took a look at how kvm deals with this problem, and I found it doesn't. I may be wrong, as I don't know kvm code, so correct me if I'm. /* * Race-free decouple logic

Re: [RFC][PATCH] kvm: fix a race when closing irq eventfd

2013-02-17 Thread Li Zefan
On 2013/2/18 12:02, Alex Williamson wrote: On Mon, 2013-02-18 at 11:13 +0800, Li Zefan wrote: While trying to fix a race when closing cgroup eventfd, I took a look at how kvm deals with this problem, and I found it doesn't. I may be wrong, as I don't know kvm code, so correct me if I'm.

Re: [RFC][PATCH] kvm: fix a race when closing irq eventfd

2013-02-17 Thread Alex Williamson
On Mon, 2013-02-18 at 12:09 +0800, Li Zefan wrote: On 2013/2/18 12:02, Alex Williamson wrote: On Mon, 2013-02-18 at 11:13 +0800, Li Zefan wrote: While trying to fix a race when closing cgroup eventfd, I took a look at how kvm deals with this problem, and I found it doesn't. I may be

Re: [RFC][PATCH] kvm: fix a race when closing irq eventfd

2013-02-17 Thread Li Zefan
On 2013/2/18 12:09, Li Zefan wrote: On 2013/2/18 12:02, Alex Williamson wrote: On Mon, 2013-02-18 at 11:13 +0800, Li Zefan wrote: While trying to fix a race when closing cgroup eventfd, I took a look at how kvm deals with this problem, and I found it doesn't. I may be wrong, as I don't know