Re: [RFC] [PATCH] To list all active probes in the system---Take-2

2007-02-12 Thread Ananth N Mavinakayanahalli
On Mon, Feb 12, 2007 at 12:45:15AM -0800, Andrew Morton wrote: > On Thu, 08 Feb 2007 17:16:15 +0530 Srinivasa Ds <[EMAIL PROTECTED]> wrote: > > > + if (p->pre_handler == pre_handler_kretprobe) > > This breaks on sparc64: > > kernel/kprobes.c: In function `report_probe': >

Re: [RFC] [PATCH] To list all active probes in the system---Take-2

2007-02-12 Thread Andrew Morton
On Thu, 08 Feb 2007 17:16:15 +0530 Srinivasa Ds <[EMAIL PROTECTED]> wrote: > + if (p->pre_handler == pre_handler_kretprobe) This breaks on sparc64: kernel/kprobes.c: In function `report_probe': kernel/kprobes.c:826: error: `pre_handler_kretprobe' undeclared (first use in this function) -

Re: [RFC] [PATCH] To list all active probes in the system---Take-2

2007-02-12 Thread Andrew Morton
On Thu, 08 Feb 2007 17:16:15 +0530 Srinivasa Ds [EMAIL PROTECTED] wrote: + if (p-pre_handler == pre_handler_kretprobe) This breaks on sparc64: kernel/kprobes.c: In function `report_probe': kernel/kprobes.c:826: error: `pre_handler_kretprobe' undeclared (first use in this function) - To

Re: [RFC] [PATCH] To list all active probes in the system---Take-2

2007-02-12 Thread Ananth N Mavinakayanahalli
On Mon, Feb 12, 2007 at 12:45:15AM -0800, Andrew Morton wrote: On Thu, 08 Feb 2007 17:16:15 +0530 Srinivasa Ds [EMAIL PROTECTED] wrote: + if (p-pre_handler == pre_handler_kretprobe) This breaks on sparc64: kernel/kprobes.c: In function `report_probe': kernel/kprobes.c:826: error:

Re: [RFC] [PATCH] To list all active probes in the system---Take-2

2007-02-09 Thread Andrew Morton
On Thu, 08 Feb 2007 17:16:15 +0530 Srinivasa Ds <[EMAIL PROTECTED]> wrote: > +module_init(debugfs_kprobe_init); > +#endif /* CONFIG_DEBUG_FS */ > + > __initcall(init_kprobes); I think you'll find this doesn't work when loaded as a module: we only support a single initcall per module. (Which

Re: [RFC] [PATCH] To list all active probes in the system---Take-2

2007-02-09 Thread Andrew Morton
On Thu, 08 Feb 2007 17:16:15 +0530 Srinivasa Ds [EMAIL PROTECTED] wrote: +module_init(debugfs_kprobe_init); +#endif /* CONFIG_DEBUG_FS */ + __initcall(init_kprobes); I think you'll find this doesn't work when loaded as a module: we only support a single initcall per module. (Which might be

Re: [RFC] [PATCH] To list all active probes in the system---Take-2

2007-02-08 Thread Srinivasa Ds
Andrew Morton wrote: > On Wed, 07 Feb 2007 10:55:23 +0530 > Srinivasa Ds <[EMAIL PROTECTED]> wrote: > >> --- linux-2.6.20.orig/fs/debugfs/inode.c >> +++ linux-2.6.20/fs/debugfs/inode.c >> @@ -25,6 +25,7 @@ >> >> if (retval) >> subsystem_unregister(_subsys); >> +

Re: [RFC] [PATCH] To list all active probes in the system---Take-2

2007-02-08 Thread Srinivasa Ds
Andrew Morton wrote: On Wed, 07 Feb 2007 10:55:23 +0530 Srinivasa Ds [EMAIL PROTECTED] wrote: --- linux-2.6.20.orig/fs/debugfs/inode.c +++ linux-2.6.20/fs/debugfs/inode.c @@ -25,6 +25,7 @@ if (retval) subsystem_unregister(debug_subsys); +debugfs_kprobe_init();