Re: [RFC] block_device_operations prototype changes

2007-08-27 Thread Neil Brown
On Monday August 27, [EMAIL PROTECTED] wrote: > * a bug (AFAICT) in md.c - we open raid components r/w and if it > fails, it fails. Good for our purposes, but... how about raid0 on read-only > devices? In any case, we have a ready place to store mode_t, so it's not a > problem for getting

Re: [RFC] block_device_operations prototype changes

2007-08-27 Thread Alasdair G Kergon
On Mon, Aug 27, 2007 at 11:30:53AM +0100, Al Viro wrote: > 3) ->ioctl(). What a mess... Yup. See also: Subject: [PATCH] dm: support ioctls on mapped devices: fix with fake file http://uwsg.indiana.edu/hypermail/linux/kernel/0606.2/2979.html and related threads. > First of all, we have 3

Re: [RFC] block_device_operations prototype changes

2007-08-27 Thread Linus Torvalds
On Mon, 27 Aug 2007, Al Viro wrote: > > I have the beginning of that series done and the rest mapped out in enough > details to implement it over this week. If somebody has objections, > questions or comments - yell. >From your description, I have no objections - everything sounds good. My

[RFC] block_device_operations prototype changes

2007-08-27 Thread Al Viro
It's time to sanitize prototypes of bdev ->open(), ->release() and ->ioctl(). This stuff had sat in "need to fix" for a long time and there is a bunch of bugs hard to fix without dealing with it. 1) ->open() gets inode * and file *. Almost all instances use only inode->i_bdev

[RFC] block_device_operations prototype changes

2007-08-27 Thread Al Viro
It's time to sanitize prototypes of bdev -open(), -release() and -ioctl(). This stuff had sat in need to fix for a long time and there is a bunch of bugs hard to fix without dealing with it. 1) -open() gets inode * and file *. Almost all instances use only inode-i_bdev

Re: [RFC] block_device_operations prototype changes

2007-08-27 Thread Linus Torvalds
On Mon, 27 Aug 2007, Al Viro wrote: I have the beginning of that series done and the rest mapped out in enough details to implement it over this week. If somebody has objections, questions or comments - yell. From your description, I have no objections - everything sounds good. My only

Re: [RFC] block_device_operations prototype changes

2007-08-27 Thread Alasdair G Kergon
On Mon, Aug 27, 2007 at 11:30:53AM +0100, Al Viro wrote: 3) -ioctl(). What a mess... Yup. See also: Subject: [PATCH] dm: support ioctls on mapped devices: fix with fake file http://uwsg.indiana.edu/hypermail/linux/kernel/0606.2/2979.html and related threads. First of all, we have 3

Re: [RFC] block_device_operations prototype changes

2007-08-27 Thread Neil Brown
On Monday August 27, [EMAIL PROTECTED] wrote: * a bug (AFAICT) in md.c - we open raid components r/w and if it fails, it fails. Good for our purposes, but... how about raid0 on read-only devices? In any case, we have a ready place to store mode_t, so it's not a problem for getting the