Re: [RFC] scripts: kernel-doc: avoid warnings due to initial commented lines in file

2021-03-20 Thread Aditya Srivastava
On 20/3/21 6:51 pm, Lukas Bulwahn wrote: > On Sat, Mar 20, 2021 at 1:45 PM Aditya Srivastava > wrote: >> >> On 20/3/21 12:23 pm, Aditya wrote: >>> On 18/3/21 11:48 pm, Jonathan Corbet wrote: Lukas Bulwahn writes: > Yeah, and as this line-counting is really just a poor man's >

Re: [RFC] scripts: kernel-doc: avoid warnings due to initial commented lines in file

2021-03-20 Thread Lukas Bulwahn
On Sat, Mar 20, 2021 at 1:45 PM Aditya Srivastava wrote: > > On 20/3/21 12:23 pm, Aditya wrote: > > On 18/3/21 11:48 pm, Jonathan Corbet wrote: > >> Lukas Bulwahn writes: > >> > >>> Yeah, and as this line-counting is really just a poor man's > >>> heuristics, we might just be better to really

Re: [RFC] scripts: kernel-doc: avoid warnings due to initial commented lines in file

2021-03-20 Thread Aditya Srivastava
On 20/3/21 12:23 pm, Aditya wrote: > On 18/3/21 11:48 pm, Jonathan Corbet wrote: >> Lukas Bulwahn writes: >> >>> Yeah, and as this line-counting is really just a poor man's >>> heuristics, we might just be better to really turn this heuristics >>> into a dedicated cleanup warning script, then we

Re: [RFC] scripts: kernel-doc: avoid warnings due to initial commented lines in file

2021-03-20 Thread Aditya
On 18/3/21 11:48 pm, Jonathan Corbet wrote: > Lukas Bulwahn writes: > >> Yeah, and as this line-counting is really just a poor man's >> heuristics, we might just be better to really turn this heuristics >> into a dedicated cleanup warning script, then we can check for more >> indicators, such as

Re: [RFC] scripts: kernel-doc: avoid warnings due to initial commented lines in file

2021-03-18 Thread Jonathan Corbet
Lukas Bulwahn writes: > Yeah, and as this line-counting is really just a poor man's > heuristics, we might just be better to really turn this heuristics > into a dedicated cleanup warning script, then we can check for more > indicators, such as "does it contain the word Copyright" somewhere in >

Re: [RFC] scripts: kernel-doc: avoid warnings due to initial commented lines in file

2021-03-18 Thread Lukas Bulwahn
On Thu, Mar 18, 2021 at 5:37 PM Jonathan Corbet wrote: > > Lukas Bulwahn writes: > > > I wonder if we could extend kernel-doc (not your preferred option as > > it seems) for a new dedicated warning message or maintain a separate > > kernel-doc sanity checking script to emit a dedicated warning

Re: [RFC] scripts: kernel-doc: avoid warnings due to initial commented lines in file

2021-03-18 Thread Jonathan Corbet
Lukas Bulwahn writes: > I wonder if we could extend kernel-doc (not your preferred option as > it seems) for a new dedicated warning message or maintain a separate > kernel-doc sanity checking script to emit a dedicated warning based on > some heuristics that suggests when a "header comment" is

Re: [RFC] scripts: kernel-doc: avoid warnings due to initial commented lines in file

2021-03-18 Thread Lukas Bulwahn
On Mon, Mar 15, 2021 at 8:25 PM Jonathan Corbet wrote: > > Aditya writes: > > >> The opening comment mark /** is used for kernel-doc comments [1] > >> > >> [1] > >> https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html#how-to-format-kernel-doc-comments > >> > > > > Hi Markus! > >

Re: [RFC] scripts: kernel-doc: avoid warnings due to initial commented lines in file

2021-03-15 Thread Jonathan Corbet
Aditya writes: >> The opening comment mark /** is used for kernel-doc comments [1] >> >> [1] >> https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html#how-to-format-kernel-doc-comments >> > > Hi Markus! > That's true. But the content inside the comment does not follow > kernel-doc

Re: [RFC] scripts: kernel-doc: avoid warnings due to initial commented lines in file

2021-03-11 Thread Lukas Bulwahn
On Thu, Mar 11, 2021 at 10:04 PM Aditya wrote: > > On 10/3/21 11:49 am, Lukas Bulwahn wrote: > > On Tue, Mar 9, 2021 at 10:24 PM Aditya wrote: > >> > >> On 9/3/21 7:00 pm, Markus Heiser wrote: > >>> > >>> Am 09.03.21 um 13:53 schrieb Aditya Srivastava: > Starting commented lines in a file

Re: [RFC] scripts: kernel-doc: avoid warnings due to initial commented lines in file

2021-03-11 Thread Aditya
On 10/3/21 11:49 am, Lukas Bulwahn wrote: > On Tue, Mar 9, 2021 at 10:24 PM Aditya wrote: >> >> On 9/3/21 7:00 pm, Markus Heiser wrote: >>> >>> Am 09.03.21 um 13:53 schrieb Aditya Srivastava: Starting commented lines in a file mostly contains comments describing license, copyright or

Re: [RFC] scripts: kernel-doc: avoid warnings due to initial commented lines in file

2021-03-09 Thread Lukas Bulwahn
On Tue, Mar 9, 2021 at 10:24 PM Aditya wrote: > > On 9/3/21 7:00 pm, Markus Heiser wrote: > > > > Am 09.03.21 um 13:53 schrieb Aditya Srivastava: > >> Starting commented lines in a file mostly contains comments describing > >> license, copyright or general information about the file. > >> > >>

Re: [RFC] scripts: kernel-doc: avoid warnings due to initial commented lines in file

2021-03-09 Thread Aditya
On 9/3/21 7:00 pm, Markus Heiser wrote: > > Am 09.03.21 um 13:53 schrieb Aditya Srivastava: >> Starting commented lines in a file mostly contains comments describing >> license, copyright or general information about the file. >> >> E.g., in sound/pci/ctxfi/ctresource.c, initial comment lines

Re: [RFC] scripts: kernel-doc: avoid warnings due to initial commented lines in file

2021-03-09 Thread Markus Heiser
Am 09.03.21 um 13:53 schrieb Aditya Srivastava: Starting commented lines in a file mostly contains comments describing license, copyright or general information about the file. E.g., in sound/pci/ctxfi/ctresource.c, initial comment lines describe its copyright and other related file

[RFC] scripts: kernel-doc: avoid warnings due to initial commented lines in file

2021-03-09 Thread Aditya Srivastava
Starting commented lines in a file mostly contains comments describing license, copyright or general information about the file. E.g., in sound/pci/ctxfi/ctresource.c, initial comment lines describe its copyright and other related file informations. But as kernel-doc reads these lines, it