Re: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-12-03 Thread Patrick Geary
} /* * Run 5 calibration loops to get the lowest frequency value --- From: patrickg Sent: Thursday, October 25, 2018 12:13 PM To: Prarit Bhargava; Brown, Len; linux-kernel@vger.kernel.org Cc: mi...@kernel.org; Du, Alek; ar...@l

Re: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-12-03 Thread Patrick Geary
} /* * Run 5 calibration loops to get the lowest frequency value --- From: patrickg Sent: Thursday, October 25, 2018 12:13 PM To: Prarit Bhargava; Brown, Len; linux-kernel@vger.kernel.org Cc: mi...@kernel.org; Du, Alek; ar...@l

Re: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-10-25 Thread patrickg
Sorry for the delay; lkml folder sorting gone wrong. On 10/25/18 11:01 AM, Prarit Bhargava wrote: > Patrick can you reply back with the entire patch Yes; watch the editor bork it even more than it originally did, though. ---Copypasta of first RFC patch--- --- diff --git

Re: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-10-25 Thread patrickg
Sorry for the delay; lkml folder sorting gone wrong. On 10/25/18 11:01 AM, Prarit Bhargava wrote: > Patrick can you reply back with the entire patch Yes; watch the editor bork it even more than it originally did, though. ---Copypasta of first RFC patch--- --- diff --git

Re: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-10-25 Thread Prarit Bhargava
On 10/25/2018 01:12 PM, patrickg wrote: > Resurrecting w/ +prarit who was handling mentions in a RHEL bug report > regarding this. > Patrick can you reply back with the entire patch? Thanks, P.

Re: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-10-25 Thread Prarit Bhargava
On 10/25/2018 01:12 PM, patrickg wrote: > Resurrecting w/ +prarit who was handling mentions in a RHEL bug report > regarding this. > Patrick can you reply back with the entire patch? Thanks, P.

Re: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-10-25 Thread patrickg
Resurrecting w/ +prarit who was handling mentions in a RHEL bug report regarding this.

Re: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-10-25 Thread patrickg
Resurrecting w/ +prarit who was handling mentions in a RHEL bug report regarding this.

Re: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-08-16 Thread patrickg
So it's been pretty quiet here... anything? Even just to call me nuts or explicitly state that the hardware is doing something totally wrong?

Re: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-08-16 Thread patrickg
So it's been pretty quiet here... anything? Even just to call me nuts or explicitly state that the hardware is doing something totally wrong?

Re: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-07-26 Thread patrickg
tsc_khz still zero with production CPU's, so it's reassigning tsc_khz to the cpuid-acquired cpu_khz value.

Re: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-07-26 Thread patrickg
tsc_khz still zero with production CPU's, so it's reassigning tsc_khz to the cpuid-acquired cpu_khz value.

Re: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-07-24 Thread patrickg
K, did significant poking. native_calibrate_cpu is getting precidence no matter what because on SKL server, native_calibrate_tsc is always returning zero (Note that there is a caveat 2 lines down). In native_calibrate_tsc, I'm seeing it always return zero after the `switch

Re: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-07-24 Thread patrickg
K, did significant poking. native_calibrate_cpu is getting precidence no matter what because on SKL server, native_calibrate_tsc is always returning zero (Note that there is a caveat 2 lines down). In native_calibrate_tsc, I'm seeing it always return zero after the `switch

Re: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-07-20 Thread patrickg
Sorry for the delay. Expect another large delay if you have any questions. I'm pretty heavily context switching. I wanted to double check to make sure that I wasn't mis-documenting and mis-remembering things. On 07/13/2018 07:40 PM, Brown, Len wrote: > We disabled CPUID-based TSC calibration

Re: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-07-20 Thread patrickg
Sorry for the delay. Expect another large delay if you have any questions. I'm pretty heavily context switching. I wanted to double check to make sure that I wasn't mis-documenting and mis-remembering things. On 07/13/2018 07:40 PM, Brown, Len wrote: > We disabled CPUID-based TSC calibration

RE: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-07-13 Thread Brown, Len
We disabled CPUID-based TSC calibration on SKX in December for several reasons. If you still have it enabled, you need this patch: commit b511203093489eb1829cb4de86e8214752205ac6 x86/tsc: Fix erroneous TSC rate on Skylake Xeon If you are referring to another platform that has CPUID-TSC

RE: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-07-13 Thread Brown, Len
We disabled CPUID-based TSC calibration on SKX in December for several reasons. If you still have it enabled, you need this patch: commit b511203093489eb1829cb4de86e8214752205ac6 x86/tsc: Fix erroneous TSC rate on Skylake Xeon If you are referring to another platform that has CPUID-TSC

Re: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-07-13 Thread patrickg
On 07/13/2018 12:40 PM, Arjan van de Ven wrote: > On 7/13/2018 12:19 PM, patrickg wrote: >> This RFC patch is intended to allow bypass CPUID, MSR and QuickPIT >> calibration methods should the user desire to. >> >> The current ordering in ML x86 tsc is to calibrate in the order listed >>

Re: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-07-13 Thread patrickg
On 07/13/2018 12:40 PM, Arjan van de Ven wrote: > On 7/13/2018 12:19 PM, patrickg wrote: >> This RFC patch is intended to allow bypass CPUID, MSR and QuickPIT >> calibration methods should the user desire to. >> >> The current ordering in ML x86 tsc is to calibrate in the order listed >>

Re: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-07-13 Thread patrickg
On 07/13/2018 12:40 PM, Arjan van de Ven wrote: > On 7/13/2018 12:19 PM, patrickg wrote: >> This RFC patch is intended to allow bypass CPUID, MSR and QuickPIT >> calibration methods should the user desire to. >> >> The current ordering in ML x86 tsc is to calibrate in the order listed >>

Re: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-07-13 Thread patrickg
On 07/13/2018 12:40 PM, Arjan van de Ven wrote: > On 7/13/2018 12:19 PM, patrickg wrote: >> This RFC patch is intended to allow bypass CPUID, MSR and QuickPIT >> calibration methods should the user desire to. >> >> The current ordering in ML x86 tsc is to calibrate in the order listed >>

[RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-07-13 Thread patrickg
This RFC patch is intended to allow bypass CPUID, MSR and QuickPIT calibration methods should the user desire to. The current ordering in ML x86 tsc is to calibrate in the order listed above; returning whenever there's a successful calibration. However there are certain BIOS/HW Designs for

[RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-07-13 Thread patrickg
This RFC patch is intended to allow bypass CPUID, MSR and QuickPIT calibration methods should the user desire to. The current ordering in ML x86 tsc is to calibrate in the order listed above; returning whenever there's a successful calibration. However there are certain BIOS/HW Designs for

Re: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-07-13 Thread Arjan van de Ven
On 7/13/2018 12:19 PM, patrickg wrote: This RFC patch is intended to allow bypass CPUID, MSR and QuickPIT calibration methods should the user desire to. The current ordering in ML x86 tsc is to calibrate in the order listed above; returning whenever there's a successful calibration. However

Re: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-07-13 Thread Arjan van de Ven
On 7/13/2018 12:19 PM, patrickg wrote: This RFC patch is intended to allow bypass CPUID, MSR and QuickPIT calibration methods should the user desire to. The current ordering in ML x86 tsc is to calibrate in the order listed above; returning whenever there's a successful calibration. However