Re: [RFC 3/4] drm: tegra: use the Common Display Framework

2013-01-29 Thread Mark Zhang
On 01/30/2013 03:01 PM, Alex Courbot wrote: > On 01/30/2013 03:50 PM, Mark Zhang wrote: [...] > >>> +/* register display notifier */ >>> +output->display_notifier.dev = NULL; >> >> Set "display_notifier.dev" to NULL makes we have to compare with every >> display entity, just like what you

Re: [RFC 3/4] drm: tegra: use the Common Display Framework

2013-01-29 Thread Alex Courbot
On 01/30/2013 04:24 PM, Thierry Reding wrote: Could you pick up a somewhat meaningful name? You know, there are too many variables with name "drm/connector/output/encoder"... :) Well, it's supposed to be abstract. From the CDF point of view it could be anything besides a panel. I know this

Re: [RFC 3/4] drm: tegra: use the Common Display Framework

2013-01-29 Thread Thierry Reding
On Wed, Jan 30, 2013 at 04:01:48PM +0900, Alex Courbot wrote: > On 01/30/2013 03:50 PM, Mark Zhang wrote: > >>@@ -147,6 +148,9 @@ struct tegra_output { > >> > >>struct drm_encoder encoder; > >>struct drm_connector connector; > >>+ struct display_entity this; > >>+ struct display_entity

Re: [RFC 3/4] drm: tegra: use the Common Display Framework

2013-01-29 Thread Alex Courbot
On 01/30/2013 03:50 PM, Mark Zhang wrote: @@ -147,6 +148,9 @@ struct tegra_output { struct drm_encoder encoder; struct drm_connector connector; + struct display_entity this; + struct display_entity *output; Could you pick up a somewhat meaningful name? You know,

Re: [RFC 3/4] drm: tegra: use the Common Display Framework

2013-01-29 Thread Mark Zhang
On 01/30/2013 11:02 AM, Alexandre Courbot wrote: > Make the tegra-drm driver use the Common Display Framework, letting it > control the panel state according to the DPMS status. > > A "nvidia,panel" property is added to the output node of the Tegra DC > that references the panel connected to a

[RFC 3/4] drm: tegra: use the Common Display Framework

2013-01-29 Thread Alexandre Courbot
Make the tegra-drm driver use the Common Display Framework, letting it control the panel state according to the DPMS status. A "nvidia,panel" property is added to the output node of the Tegra DC that references the panel connected to a given output. Signed-off-by: Alexandre Courbot ---

[RFC 3/4] drm: tegra: use the Common Display Framework

2013-01-29 Thread Alexandre Courbot
Make the tegra-drm driver use the Common Display Framework, letting it control the panel state according to the DPMS status. A nvidia,panel property is added to the output node of the Tegra DC that references the panel connected to a given output. Signed-off-by: Alexandre Courbot

Re: [RFC 3/4] drm: tegra: use the Common Display Framework

2013-01-29 Thread Mark Zhang
On 01/30/2013 11:02 AM, Alexandre Courbot wrote: Make the tegra-drm driver use the Common Display Framework, letting it control the panel state according to the DPMS status. A nvidia,panel property is added to the output node of the Tegra DC that references the panel connected to a given

Re: [RFC 3/4] drm: tegra: use the Common Display Framework

2013-01-29 Thread Alex Courbot
On 01/30/2013 03:50 PM, Mark Zhang wrote: @@ -147,6 +148,9 @@ struct tegra_output { struct drm_encoder encoder; struct drm_connector connector; + struct display_entity this; + struct display_entity *output; Could you pick up a somewhat meaningful name? You know,

Re: [RFC 3/4] drm: tegra: use the Common Display Framework

2013-01-29 Thread Thierry Reding
On Wed, Jan 30, 2013 at 04:01:48PM +0900, Alex Courbot wrote: On 01/30/2013 03:50 PM, Mark Zhang wrote: @@ -147,6 +148,9 @@ struct tegra_output { struct drm_encoder encoder; struct drm_connector connector; + struct display_entity this; + struct display_entity *output; Could

Re: [RFC 3/4] drm: tegra: use the Common Display Framework

2013-01-29 Thread Alex Courbot
On 01/30/2013 04:24 PM, Thierry Reding wrote: Could you pick up a somewhat meaningful name? You know, there are too many variables with name drm/connector/output/encoder... :) Well, it's supposed to be abstract. From the CDF point of view it could be anything besides a panel. I know this makes

Re: [RFC 3/4] drm: tegra: use the Common Display Framework

2013-01-29 Thread Mark Zhang
On 01/30/2013 03:01 PM, Alex Courbot wrote: On 01/30/2013 03:50 PM, Mark Zhang wrote: [...] +/* register display notifier */ +output-display_notifier.dev = NULL; Set display_notifier.dev to NULL makes we have to compare with every display entity, just like what you do in