Re: [RFC 3/8] Flushing and zeroing higher order page cache pages

2007-04-20 Thread William Lee Irwin III
On Fri, 20 Apr 2007, Mel Gorman wrote: >> While this looks fine, it seems that clear_huge_page() and >> clear_mapping_page() could share a common helper. I also note that >> clear_huge_page() calls cond_reched() and this doesn't which may be the >> type of different behavior we want to avoid. On

Re: [RFC 3/8] Flushing and zeroing higher order page cache pages

2007-04-20 Thread Christoph Lameter
On Fri, 20 Apr 2007, Mel Gorman wrote: > While this looks fine, it seems that clear_huge_page() and > clear_mapping_page() could share a common helper. I also note that > clear_huge_page() calls cond_reched() and this doesn't which may be the > type of different behavior we want to avoid. I am

Re: [RFC 3/8] Flushing and zeroing higher order page cache pages

2007-04-20 Thread Mel Gorman
On (19/04/07 09:35), Christoph Lameter didst pronounce: > --- > include/linux/pagemap.h | 27 +++ > 1 file changed, 27 insertions(+) > > Index: linux-2.6.21-rc7/include/linux/pagemap.h > === > ---

Re: [RFC 3/8] Flushing and zeroing higher order page cache pages

2007-04-20 Thread Mel Gorman
On (19/04/07 09:35), Christoph Lameter didst pronounce: --- include/linux/pagemap.h | 27 +++ 1 file changed, 27 insertions(+) Index: linux-2.6.21-rc7/include/linux/pagemap.h === ---

Re: [RFC 3/8] Flushing and zeroing higher order page cache pages

2007-04-20 Thread Christoph Lameter
On Fri, 20 Apr 2007, Mel Gorman wrote: While this looks fine, it seems that clear_huge_page() and clear_mapping_page() could share a common helper. I also note that clear_huge_page() calls cond_reched() and this doesn't which may be the type of different behavior we want to avoid. I am

Re: [RFC 3/8] Flushing and zeroing higher order page cache pages

2007-04-20 Thread William Lee Irwin III
On Fri, 20 Apr 2007, Mel Gorman wrote: While this looks fine, it seems that clear_huge_page() and clear_mapping_page() could share a common helper. I also note that clear_huge_page() calls cond_reched() and this doesn't which may be the type of different behavior we want to avoid. On Fri, Apr

[RFC 3/8] Flushing and zeroing higher order page cache pages

2007-04-19 Thread Christoph Lameter
--- include/linux/pagemap.h | 27 +++ 1 file changed, 27 insertions(+) Index: linux-2.6.21-rc7/include/linux/pagemap.h === --- linux-2.6.21-rc7.orig/include/linux/pagemap.h 2007-04-18

[RFC 3/8] Flushing and zeroing higher order page cache pages

2007-04-19 Thread Christoph Lameter
--- include/linux/pagemap.h | 27 +++ 1 file changed, 27 insertions(+) Index: linux-2.6.21-rc7/include/linux/pagemap.h === --- linux-2.6.21-rc7.orig/include/linux/pagemap.h 2007-04-18