Re: [RFC PATCH] sched: wake-affine throttle

2013-04-08 Thread Michael Wang
On 04/08/2013 06:00 PM, Peter Zijlstra wrote: > On Mon, 2013-03-25 at 13:24 +0800, Michael Wang wrote: >> if (affine_sd) { >> - if (cpu != prev_cpu && wake_affine(affine_sd, p, >> sync)) >> + if (cpu != prev_cpu && wake_affine(affine_sd, p, >> sync)) { >> +

Re: [RFC PATCH] sched: wake-affine throttle

2013-04-08 Thread Peter Zijlstra
On Mon, 2013-03-25 at 13:24 +0800, Michael Wang wrote: > if (affine_sd) { > - if (cpu != prev_cpu && wake_affine(affine_sd, p, > sync)) > + if (cpu != prev_cpu && wake_affine(affine_sd, p, > sync)) { > + /* > +*

Re: [RFC PATCH] sched: wake-affine throttle

2013-04-08 Thread Peter Zijlstra
On Mon, 2013-03-25 at 13:24 +0800, Michael Wang wrote: if (affine_sd) { - if (cpu != prev_cpu wake_affine(affine_sd, p, sync)) + if (cpu != prev_cpu wake_affine(affine_sd, p, sync)) { + /* +* wake_affine()

Re: [RFC PATCH] sched: wake-affine throttle

2013-04-08 Thread Michael Wang
On 04/08/2013 06:00 PM, Peter Zijlstra wrote: On Mon, 2013-03-25 at 13:24 +0800, Michael Wang wrote: if (affine_sd) { - if (cpu != prev_cpu wake_affine(affine_sd, p, sync)) + if (cpu != prev_cpu wake_affine(affine_sd, p, sync)) { +

Re: [RFC PATCH] sched: wake-affine throttle

2013-04-07 Thread Michael Wang
On 03/25/2013 01:24 PM, Michael Wang wrote: > Recently testing show that wake-affine stuff cause regression on pgbench, the > hiding rat was finally catched out. > > wake-affine stuff is always trying to pull wakee close to waker, by theory, > this will benefit us if waker's cpu cached hot data

Re: [RFC PATCH] sched: wake-affine throttle

2013-04-07 Thread Michael Wang
On 03/25/2013 01:24 PM, Michael Wang wrote: Recently testing show that wake-affine stuff cause regression on pgbench, the hiding rat was finally catched out. wake-affine stuff is always trying to pull wakee close to waker, by theory, this will benefit us if waker's cpu cached hot data for

Re: [RFC PATCH] sched: wake-affine throttle

2013-03-25 Thread Michael Wang
On 03/25/2013 10:31 PM, Mike Galbraith wrote: [snip] >> >> Do you mean 1ms interval is still too big? and you prefer to have a 0 >> option? > > Not really, I just think a fixed interval may not be good enough without > some idle time consideration. Once a single load gets going less > balancing

Re: [RFC PATCH] sched: wake-affine throttle

2013-03-25 Thread Mike Galbraith
On Mon, 2013-03-25 at 18:21 +0800, Michael Wang wrote: > Hi, Mike > > Thanks for your reply :) > > On 03/25/2013 05:22 PM, Mike Galbraith wrote: > > On Mon, 2013-03-25 at 13:24 +0800, Michael Wang wrote: > >> Recently testing show that wake-affine stuff cause regression on pgbench, > >> the >

Re: [RFC PATCH] sched: wake-affine throttle

2013-03-25 Thread Michael Wang
Hi, Mike Thanks for your reply :) On 03/25/2013 05:22 PM, Mike Galbraith wrote: > On Mon, 2013-03-25 at 13:24 +0800, Michael Wang wrote: >> Recently testing show that wake-affine stuff cause regression on pgbench, the >> hiding rat was finally catched out. >> >> wake-affine stuff is always

Re: [RFC PATCH] sched: wake-affine throttle

2013-03-25 Thread Mike Galbraith
On Mon, 2013-03-25 at 13:24 +0800, Michael Wang wrote: > Recently testing show that wake-affine stuff cause regression on pgbench, the > hiding rat was finally catched out. > > wake-affine stuff is always trying to pull wakee close to waker, by theory, > this will benefit us if waker's cpu

Re: [RFC PATCH] sched: wake-affine throttle

2013-03-25 Thread Mike Galbraith
On Mon, 2013-03-25 at 13:24 +0800, Michael Wang wrote: Recently testing show that wake-affine stuff cause regression on pgbench, the hiding rat was finally catched out. wake-affine stuff is always trying to pull wakee close to waker, by theory, this will benefit us if waker's cpu cached hot

Re: [RFC PATCH] sched: wake-affine throttle

2013-03-25 Thread Michael Wang
Hi, Mike Thanks for your reply :) On 03/25/2013 05:22 PM, Mike Galbraith wrote: On Mon, 2013-03-25 at 13:24 +0800, Michael Wang wrote: Recently testing show that wake-affine stuff cause regression on pgbench, the hiding rat was finally catched out. wake-affine stuff is always trying to

Re: [RFC PATCH] sched: wake-affine throttle

2013-03-25 Thread Mike Galbraith
On Mon, 2013-03-25 at 18:21 +0800, Michael Wang wrote: Hi, Mike Thanks for your reply :) On 03/25/2013 05:22 PM, Mike Galbraith wrote: On Mon, 2013-03-25 at 13:24 +0800, Michael Wang wrote: Recently testing show that wake-affine stuff cause regression on pgbench, the hiding rat

Re: [RFC PATCH] sched: wake-affine throttle

2013-03-25 Thread Michael Wang
On 03/25/2013 10:31 PM, Mike Galbraith wrote: [snip] Do you mean 1ms interval is still too big? and you prefer to have a 0 option? Not really, I just think a fixed interval may not be good enough without some idle time consideration. Once a single load gets going less balancing is more,

[RFC PATCH] sched: wake-affine throttle

2013-03-24 Thread Michael Wang
Recently testing show that wake-affine stuff cause regression on pgbench, the hiding rat was finally catched out. wake-affine stuff is always trying to pull wakee close to waker, by theory, this will benefit us if waker's cpu cached hot data for wakee, or the extreme ping-pong case. However, the

[RFC PATCH] sched: wake-affine throttle

2013-03-24 Thread Michael Wang
Recently testing show that wake-affine stuff cause regression on pgbench, the hiding rat was finally catched out. wake-affine stuff is always trying to pull wakee close to waker, by theory, this will benefit us if waker's cpu cached hot data for wakee, or the extreme ping-pong case. However, the