Re: [RFC PATCH 1/3] pci: APM X-Gene PCIe controller driver

2014-01-09 Thread Tanmay Inamdar
On Tue, Jan 7, 2014 at 1:27 AM, Arnd Bergmann wrote: > On Tuesday 07 January 2014, Tanmay Inamdar wrote: >> > Also, the implementation is wrong since the I/O port range already needs >> > to be ioremapped in order for inb/outb to work. There is already a >> > generic implementation of this in

Re: [RFC PATCH 1/3] pci: APM X-Gene PCIe controller driver

2014-01-09 Thread Tanmay Inamdar
On Tue, Jan 7, 2014 at 1:27 AM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 07 January 2014, Tanmay Inamdar wrote: Also, the implementation is wrong since the I/O port range already needs to be ioremapped in order for inb/outb to work. There is already a generic implementation of this in

Re: [RFC PATCH 1/3] pci: APM X-Gene PCIe controller driver

2014-01-07 Thread Arnd Bergmann
On Tuesday 07 January 2014, Tanmay Inamdar wrote: > > Also, the implementation is wrong since the I/O port range already needs > > to be ioremapped in order for inb/outb to work. There is already a > > generic implementation of this in include/asm-generic/iomap.h, which > > correctly calls

Re: [RFC PATCH 1/3] pci: APM X-Gene PCIe controller driver

2014-01-07 Thread Arnd Bergmann
On Tuesday 07 January 2014, Tanmay Inamdar wrote: Also, the implementation is wrong since the I/O port range already needs to be ioremapped in order for inb/outb to work. There is already a generic implementation of this in include/asm-generic/iomap.h, which correctly calls ioport_map.

Re: [RFC PATCH 1/3] pci: APM X-Gene PCIe controller driver

2014-01-06 Thread Jingoo Han
On Tuesday, January 07, 2014 11:45 AM, Tanmay Inamdar wrote: > On Sun, Jan 5, 2014 at 5:47 PM, Jingoo Han wrote: > > On Monday, December 23, 2013 5:02 PM, Tanmay Inamdar wrote: > >> > >> This patch adds the AppliedMicro X-gene SOC PCIe controller driver. > >> APM X-Gene PCIe controller supports

Re: [RFC PATCH 1/3] pci: APM X-Gene PCIe controller driver

2014-01-06 Thread Tanmay Inamdar
On Sun, Jan 5, 2014 at 5:47 PM, Jingoo Han wrote: > On Monday, December 23, 2013 5:02 PM, Tanmay Inamdar wrote: >> >> This patch adds the AppliedMicro X-gene SOC PCIe controller driver. >> APM X-Gene PCIe controller supports maximum upto 8 lanes and >> GEN3 speed. X-Gene has maximum 5 PCIe ports

Re: [RFC PATCH 1/3] pci: APM X-Gene PCIe controller driver

2014-01-06 Thread Tanmay Inamdar
Thanks for your comments. Please see some inline replies. On Fri, Jan 3, 2014 at 4:07 AM, Arnd Bergmann wrote: > On Monday 23 December 2013, Tanmay Inamdar wrote: >> This patch adds the AppliedMicro X-gene SOC PCIe controller driver. >> APM X-Gene PCIe controller supports maximum upto 8 lanes

Re: [RFC PATCH 1/3] pci: APM X-Gene PCIe controller driver

2014-01-06 Thread Tanmay Inamdar
Thanks for your comments. Please see some inline replies. On Fri, Jan 3, 2014 at 4:07 AM, Arnd Bergmann a...@arndb.de wrote: On Monday 23 December 2013, Tanmay Inamdar wrote: This patch adds the AppliedMicro X-gene SOC PCIe controller driver. APM X-Gene PCIe controller supports maximum upto 8

Re: [RFC PATCH 1/3] pci: APM X-Gene PCIe controller driver

2014-01-06 Thread Tanmay Inamdar
On Sun, Jan 5, 2014 at 5:47 PM, Jingoo Han jg1@samsung.com wrote: On Monday, December 23, 2013 5:02 PM, Tanmay Inamdar wrote: This patch adds the AppliedMicro X-gene SOC PCIe controller driver. APM X-Gene PCIe controller supports maximum upto 8 lanes and GEN3 speed. X-Gene has maximum 5

Re: [RFC PATCH 1/3] pci: APM X-Gene PCIe controller driver

2014-01-06 Thread Jingoo Han
On Tuesday, January 07, 2014 11:45 AM, Tanmay Inamdar wrote: On Sun, Jan 5, 2014 at 5:47 PM, Jingoo Han jg1@samsung.com wrote: On Monday, December 23, 2013 5:02 PM, Tanmay Inamdar wrote: This patch adds the AppliedMicro X-gene SOC PCIe controller driver. APM X-Gene PCIe controller

Re: [RFC PATCH 1/3] pci: APM X-Gene PCIe controller driver

2014-01-05 Thread Jingoo Han
On Monday, December 23, 2013 5:02 PM, Tanmay Inamdar wrote: > > This patch adds the AppliedMicro X-gene SOC PCIe controller driver. > APM X-Gene PCIe controller supports maximum upto 8 lanes and > GEN3 speed. X-Gene has maximum 5 PCIe ports supported. (+cc Jason Gunthorpe, Arnd Bergmann) Hi

Re: [RFC PATCH 1/3] pci: APM X-Gene PCIe controller driver

2014-01-05 Thread Jingoo Han
On Monday, December 23, 2013 5:02 PM, Tanmay Inamdar wrote: This patch adds the AppliedMicro X-gene SOC PCIe controller driver. APM X-Gene PCIe controller supports maximum upto 8 lanes and GEN3 speed. X-Gene has maximum 5 PCIe ports supported. (+cc Jason Gunthorpe, Arnd Bergmann) Hi Tanmay

Re: [RFC PATCH 1/3] pci: APM X-Gene PCIe controller driver

2014-01-03 Thread Arnd Bergmann
On Monday 23 December 2013, Tanmay Inamdar wrote: > This patch adds the AppliedMicro X-gene SOC PCIe controller driver. > APM X-Gene PCIe controller supports maximum upto 8 lanes and > GEN3 speed. X-Gene has maximum 5 PCIe ports supported. > > Signed-off-by: Tanmay Inamdar > --- >

Re: [RFC PATCH 1/3] pci: APM X-Gene PCIe controller driver

2014-01-03 Thread Arnd Bergmann
On Monday 23 December 2013, Tanmay Inamdar wrote: This patch adds the AppliedMicro X-gene SOC PCIe controller driver. APM X-Gene PCIe controller supports maximum upto 8 lanes and GEN3 speed. X-Gene has maximum 5 PCIe ports supported. Signed-off-by: Tanmay Inamdar tinam...@apm.com ---

Re: [RFC PATCH 1/3] pci: APM X-Gene PCIe controller driver

2014-01-02 Thread Bjorn Helgaas
On Mon, Dec 23, 2013 at 1:02 AM, Tanmay Inamdar wrote: > This patch adds the AppliedMicro X-gene SOC PCIe controller driver. > APM X-Gene PCIe controller supports maximum upto 8 lanes and > GEN3 speed. X-Gene has maximum 5 PCIe ports supported. > > Signed-off-by: Tanmay Inamdar Since Jason

Re: [RFC PATCH 1/3] pci: APM X-Gene PCIe controller driver

2014-01-02 Thread Bjorn Helgaas
On Mon, Dec 23, 2013 at 1:02 AM, Tanmay Inamdar tinam...@apm.com wrote: This patch adds the AppliedMicro X-gene SOC PCIe controller driver. APM X-Gene PCIe controller supports maximum upto 8 lanes and GEN3 speed. X-Gene has maximum 5 PCIe ports supported. Signed-off-by: Tanmay Inamdar

[RFC PATCH 1/3] pci: APM X-Gene PCIe controller driver

2013-12-23 Thread Tanmay Inamdar
This patch adds the AppliedMicro X-gene SOC PCIe controller driver. APM X-Gene PCIe controller supports maximum upto 8 lanes and GEN3 speed. X-Gene has maximum 5 PCIe ports supported. Signed-off-by: Tanmay Inamdar --- drivers/pci/host/Kconfig |5 + drivers/pci/host/Makefile |1

[RFC PATCH 1/3] pci: APM X-Gene PCIe controller driver

2013-12-23 Thread Tanmay Inamdar
This patch adds the AppliedMicro X-gene SOC PCIe controller driver. APM X-Gene PCIe controller supports maximum upto 8 lanes and GEN3 speed. X-Gene has maximum 5 PCIe ports supported. Signed-off-by: Tanmay Inamdar tinam...@apm.com --- drivers/pci/host/Kconfig |5 +