Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-08-06 Thread Richard Weinberger
Am 06.08.2015 um 11:19 schrieb Boris Brezillon: >> I think this needs more discussion. >> >> Boris, Brian, will you be at Embedded Linux Conference Europe in Dublin? >> Maybe we can discuss these issues (data retention, ff-checks, etc...) in >> person and figure out where to address them. >> I

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-08-06 Thread Boris Brezillon
Hi Richard, On Tue, 4 Aug 2015 09:21:27 +0200 Richard Weinberger wrote: > Andrea, > > Am 04.08.2015 um 09:02 schrieb Andrea Scian: > >> I'm not sure whether introducing a read-before-write check is the best > >> solution. > >> At least we need hard numbers for slow/old SLC NANDs too. > > > >

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-08-06 Thread Richard Weinberger
Am 06.08.2015 um 11:19 schrieb Boris Brezillon: I think this needs more discussion. Boris, Brian, will you be at Embedded Linux Conference Europe in Dublin? Maybe we can discuss these issues (data retention, ff-checks, etc...) in person and figure out where to address them. I really want

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-08-06 Thread Boris Brezillon
Hi Richard, On Tue, 4 Aug 2015 09:21:27 +0200 Richard Weinberger rich...@nod.at wrote: Andrea, Am 04.08.2015 um 09:02 schrieb Andrea Scian: I'm not sure whether introducing a read-before-write check is the best solution. At least we need hard numbers for slow/old SLC NANDs too.

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-08-05 Thread Andrea Scian
Il 04/08/2015 09:21, Richard Weinberger ha scritto: Andrea, Am 04.08.2015 um 09:02 schrieb Andrea Scian: I'm not sure whether introducing a read-before-write check is the best solution. At least we need hard numbers for slow/old SLC NANDs too. We can enable the feature only for MLC, AFAIK it

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-08-05 Thread Andrea Scian
Il 04/08/2015 09:21, Richard Weinberger ha scritto: Andrea, Am 04.08.2015 um 09:02 schrieb Andrea Scian: I'm not sure whether introducing a read-before-write check is the best solution. At least we need hard numbers for slow/old SLC NANDs too. We can enable the feature only for MLC, AFAIK it

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-08-04 Thread Richard Weinberger
Andrea, Am 04.08.2015 um 09:02 schrieb Andrea Scian: >> I'm not sure whether introducing a read-before-write check is the best >> solution. >> At least we need hard numbers for slow/old SLC NANDs too. > > We can enable the feature only for MLC, AFAIK it has not been required for > old SLC ;-)

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-08-04 Thread Andrea Scian
Richard, Il 03/08/2015 21:32, Richard Weinberger ha scritto: Am 03.08.2015 um 15:39 schrieb Andrea Scian: I think I can find some time to do some performance tests on real hardware. Can you please help me in finding: - which benchmark to use (currently I'm using bonnie++ on UBIFS, maybe I can

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-08-04 Thread Richard Weinberger
Andrea, Am 04.08.2015 um 09:02 schrieb Andrea Scian: I'm not sure whether introducing a read-before-write check is the best solution. At least we need hard numbers for slow/old SLC NANDs too. We can enable the feature only for MLC, AFAIK it has not been required for old SLC ;-) I think

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-08-04 Thread Andrea Scian
Richard, Il 03/08/2015 21:32, Richard Weinberger ha scritto: Am 03.08.2015 um 15:39 schrieb Andrea Scian: I think I can find some time to do some performance tests on real hardware. Can you please help me in finding: - which benchmark to use (currently I'm using bonnie++ on UBIFS, maybe I can

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-08-03 Thread Richard Weinberger
Am 03.08.2015 um 15:39 schrieb Andrea Scian: >>> I think I can find some time to do some performance tests on real hardware. >>> Can you please help me in finding: >>> - which benchmark to use (currently I'm using bonnie++ on UBIFS, maybe I >>> can you just mtd_speedtest) >>> - where to implement

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-08-03 Thread Andrea Scian
Il 03/08/2015 14:42, Boris Brezillon ha scritto: Adding Artem and Richard in the loop. thanks ;-) On Mon, 3 Aug 2015 13:16:02 +0200 Andrea Scian wrote: Dear Boris, Il 31/07/2015 18:27, Boris Brezillon ha scritto: On Fri, 31 Jul 2015 18:19:30 +0200 Andrea Scian wrote: Il 31/07/2015

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-08-03 Thread Boris Brezillon
Adding Artem and Richard in the loop. On Mon, 3 Aug 2015 13:16:02 +0200 Andrea Scian wrote: > > Dear Boris, > > Il 31/07/2015 18:27, Boris Brezillon ha scritto: > > On Fri, 31 Jul 2015 18:19:30 +0200 > > Andrea Scian wrote: > > > >> Il 31/07/2015 16:10, Boris Brezillon ha scritto: > >>> On

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-08-03 Thread Andrea Scian
Dear Boris, Il 31/07/2015 18:27, Boris Brezillon ha scritto: On Fri, 31 Jul 2015 18:19:30 +0200 Andrea Scian wrote: Il 31/07/2015 16:10, Boris Brezillon ha scritto: On Fri, 31 Jul 2015 15:40:13 +0200 Andrea Scian wrote: Boris, Il 31/07/2015 12:32, Boris Brezillon ha scritto: Hi

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-08-03 Thread Andrea Scian
Dear Boris, Il 31/07/2015 18:27, Boris Brezillon ha scritto: On Fri, 31 Jul 2015 18:19:30 +0200 Andrea Scian r...@dave-tech.it wrote: Il 31/07/2015 16:10, Boris Brezillon ha scritto: On Fri, 31 Jul 2015 15:40:13 +0200 Andrea Scian r...@dave-tech.it wrote: Boris, Il 31/07/2015 12:32,

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-08-03 Thread Boris Brezillon
Adding Artem and Richard in the loop. On Mon, 3 Aug 2015 13:16:02 +0200 Andrea Scian r...@dave-tech.it wrote: Dear Boris, Il 31/07/2015 18:27, Boris Brezillon ha scritto: On Fri, 31 Jul 2015 18:19:30 +0200 Andrea Scian r...@dave-tech.it wrote: Il 31/07/2015 16:10, Boris Brezillon

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-08-03 Thread Andrea Scian
Il 03/08/2015 14:42, Boris Brezillon ha scritto: Adding Artem and Richard in the loop. thanks ;-) On Mon, 3 Aug 2015 13:16:02 +0200 Andrea Scian r...@dave-tech.it wrote: Dear Boris, Il 31/07/2015 18:27, Boris Brezillon ha scritto: On Fri, 31 Jul 2015 18:19:30 +0200 Andrea Scian

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-08-03 Thread Richard Weinberger
Am 03.08.2015 um 15:39 schrieb Andrea Scian: I think I can find some time to do some performance tests on real hardware. Can you please help me in finding: - which benchmark to use (currently I'm using bonnie++ on UBIFS, maybe I can you just mtd_speedtest) - where to implement those read I

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-07-31 Thread Boris Brezillon
On Fri, 31 Jul 2015 18:19:30 +0200 Andrea Scian wrote: > Il 31/07/2015 16:10, Boris Brezillon ha scritto: > > On Fri, 31 Jul 2015 15:40:13 +0200 > > Andrea Scian wrote: > > > >> > >> Boris, > >> > >> Il 31/07/2015 12:32, Boris Brezillon ha scritto: > >>> Hi Andrea, > >>> > >>> Adding Han in Cc.

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-07-31 Thread Andrea Scian
Il 31/07/2015 16:10, Boris Brezillon ha scritto: On Fri, 31 Jul 2015 15:40:13 +0200 Andrea Scian wrote: Boris, Il 31/07/2015 12:32, Boris Brezillon ha scritto: Hi Andrea, Adding Han in Cc. On Fri, 31 Jul 2015 12:07:21 +0200 Andrea Scian wrote: Dear Boris, Il 30/07/2015 19:34, Boris

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-07-31 Thread Boris Brezillon
On Fri, 31 Jul 2015 15:40:13 +0200 Andrea Scian wrote: > > Boris, > > Il 31/07/2015 12:32, Boris Brezillon ha scritto: > > Hi Andrea, > > > > Adding Han in Cc. > > > > On Fri, 31 Jul 2015 12:07:21 +0200 > > Andrea Scian wrote: > > > >> > >> Dear Boris, > >> > >> > >> Il 30/07/2015 19:34,

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-07-31 Thread Andrea Scian
Boris, Il 31/07/2015 12:32, Boris Brezillon ha scritto: Hi Andrea, Adding Han in Cc. On Fri, 31 Jul 2015 12:07:21 +0200 Andrea Scian wrote: Dear Boris, Il 30/07/2015 19:34, Boris Brezillon ha scritto: The default NAND read functions are relying on an underlying controller to correct

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-07-31 Thread Boris Brezillon
Hi Andrea, Adding Han in Cc. On Fri, 31 Jul 2015 12:07:21 +0200 Andrea Scian wrote: > > Dear Boris, > > > Il 30/07/2015 19:34, Boris Brezillon ha scritto: > > The default NAND read functions are relying on an underlying controller > > to correct bitflips, but some of those controller cannot

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-07-31 Thread Andrea Scian
Dear Boris, Il 30/07/2015 19:34, Boris Brezillon ha scritto: The default NAND read functions are relying on an underlying controller to correct bitflips, but some of those controller cannot properly fix bitflips in erased pages. In case of ECC failures, check if the page of subpage is empty

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-07-31 Thread Boris Brezillon
On Fri, 31 Jul 2015 15:40:13 +0200 Andrea Scian r...@dave-tech.it wrote: Boris, Il 31/07/2015 12:32, Boris Brezillon ha scritto: Hi Andrea, Adding Han in Cc. On Fri, 31 Jul 2015 12:07:21 +0200 Andrea Scian r...@dave-tech.it wrote: Dear Boris, Il 30/07/2015 19:34,

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-07-31 Thread Andrea Scian
Boris, Il 31/07/2015 12:32, Boris Brezillon ha scritto: Hi Andrea, Adding Han in Cc. On Fri, 31 Jul 2015 12:07:21 +0200 Andrea Scian r...@dave-tech.it wrote: Dear Boris, Il 30/07/2015 19:34, Boris Brezillon ha scritto: The default NAND read functions are relying on an underlying

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-07-31 Thread Andrea Scian
Il 31/07/2015 16:10, Boris Brezillon ha scritto: On Fri, 31 Jul 2015 15:40:13 +0200 Andrea Scian r...@dave-tech.it wrote: Boris, Il 31/07/2015 12:32, Boris Brezillon ha scritto: Hi Andrea, Adding Han in Cc. On Fri, 31 Jul 2015 12:07:21 +0200 Andrea Scian r...@dave-tech.it wrote: Dear

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-07-31 Thread Boris Brezillon
On Fri, 31 Jul 2015 18:19:30 +0200 Andrea Scian r...@dave-tech.it wrote: Il 31/07/2015 16:10, Boris Brezillon ha scritto: On Fri, 31 Jul 2015 15:40:13 +0200 Andrea Scian r...@dave-tech.it wrote: Boris, Il 31/07/2015 12:32, Boris Brezillon ha scritto: Hi Andrea, Adding Han in

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-07-31 Thread Andrea Scian
Dear Boris, Il 30/07/2015 19:34, Boris Brezillon ha scritto: The default NAND read functions are relying on an underlying controller to correct bitflips, but some of those controller cannot properly fix bitflips in erased pages. In case of ECC failures, check if the page of subpage is empty

Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-07-31 Thread Boris Brezillon
Hi Andrea, Adding Han in Cc. On Fri, 31 Jul 2015 12:07:21 +0200 Andrea Scian r...@dave-tech.it wrote: Dear Boris, Il 30/07/2015 19:34, Boris Brezillon ha scritto: The default NAND read functions are relying on an underlying controller to correct bitflips, but some of those

[RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-07-30 Thread Boris Brezillon
The default NAND read functions are relying on an underlying controller to correct bitflips, but some of those controller cannot properly fix bitflips in erased pages. In case of ECC failures, check if the page of subpage is empty before reporting an ECC failure. Signed-off-by: Boris Brezillon

[RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions

2015-07-30 Thread Boris Brezillon
The default NAND read functions are relying on an underlying controller to correct bitflips, but some of those controller cannot properly fix bitflips in erased pages. In case of ECC failures, check if the page of subpage is empty before reporting an ECC failure. Signed-off-by: Boris Brezillon