Re: [RFC PATCH 3/3] dt-bindings: pci: xgene pcie device tree bindings

2014-01-11 Thread Arnd Bergmann
On Saturday 11 January 2014, Tanmay Inamdar wrote: > On Tue, Jan 7, 2014 at 7:35 AM, Arnd Bergmann wrote: > > On Tuesday 07 January 2014, Tanmay Inamdar wrote: > >> On Fri, Jan 3, 2014 at 1:49 AM, Arnd Bergmann wrote: > >> > > >> > Better use an anonymous clock? > >> > >> Sorry. Can you please

Re: [RFC PATCH 3/3] dt-bindings: pci: xgene pcie device tree bindings

2014-01-11 Thread Arnd Bergmann
On Saturday 11 January 2014, Tanmay Inamdar wrote: On Tue, Jan 7, 2014 at 7:35 AM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 07 January 2014, Tanmay Inamdar wrote: On Fri, Jan 3, 2014 at 1:49 AM, Arnd Bergmann a...@arndb.de wrote: Better use an anonymous clock? Sorry. Can you

Re: [RFC PATCH 3/3] dt-bindings: pci: xgene pcie device tree bindings

2014-01-10 Thread Tanmay Inamdar
On Tue, Jan 7, 2014 at 7:35 AM, Arnd Bergmann wrote: > On Tuesday 07 January 2014, Tanmay Inamdar wrote: >> On Fri, Jan 3, 2014 at 1:49 AM, Arnd Bergmann wrote: >> >> +Required properties: >> >> +- status: Either "ok" or "disabled". >> >> +- device_type: set to "pci" >> >> +- compatible: should

Re: [RFC PATCH 3/3] dt-bindings: pci: xgene pcie device tree bindings

2014-01-10 Thread Tanmay Inamdar
On Tue, Jan 7, 2014 at 7:35 AM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 07 January 2014, Tanmay Inamdar wrote: On Fri, Jan 3, 2014 at 1:49 AM, Arnd Bergmann a...@arndb.de wrote: +Required properties: +- status: Either ok or disabled. +- device_type: set to pci +- compatible: should

Re: [RFC PATCH 3/3] dt-bindings: pci: xgene pcie device tree bindings

2014-01-09 Thread Tanmay Inamdar
On Tue, Jan 7, 2014 at 10:31 AM, Jason Gunthorpe wrote: > On Tue, Jan 07, 2014 at 04:35:01PM +0100, Arnd Bergmann wrote: > >> > >> + 0x 0x0 0xd000 0xe0 0xd000 0x0 >> > >> 0x0020 /* cfg */ >> > > >> > > config space is not normally in the ranges property,

Re: [RFC PATCH 3/3] dt-bindings: pci: xgene pcie device tree bindings

2014-01-09 Thread Tanmay Inamdar
On Tue, Jan 7, 2014 at 10:31 AM, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: On Tue, Jan 07, 2014 at 04:35:01PM +0100, Arnd Bergmann wrote: + 0x 0x0 0xd000 0xe0 0xd000 0x0 0x0020 /* cfg */ config space is not normally in the

Re: [RFC PATCH 3/3] dt-bindings: pci: xgene pcie device tree bindings

2014-01-07 Thread Jason Gunthorpe
On Tue, Jan 07, 2014 at 04:35:01PM +0100, Arnd Bergmann wrote: > > >> + 0x 0x0 0xd000 0xe0 0xd000 0x0 > > >> 0x0020 /* cfg */ > > > > > > config space is not normally in the ranges property, and I think you will > > > need > > > it in the pcie node

Re: [RFC PATCH 3/3] dt-bindings: pci: xgene pcie device tree bindings

2014-01-07 Thread Arnd Bergmann
On Tuesday 07 January 2014 16:35:01 Arnd Bergmann wrote: > > >> +SoC specific DT Entry: > > >> + pcie0: pcie@1f2b { > > >> + status = "disabled"; > > >> + device_type = "pci"; > > >> + compatible = "xgene,pcie"; > > >> + #interrupt-cells =

Re: [RFC PATCH 3/3] dt-bindings: pci: xgene pcie device tree bindings

2014-01-07 Thread Arnd Bergmann
On Tuesday 07 January 2014, Tanmay Inamdar wrote: > On Fri, Jan 3, 2014 at 1:49 AM, Arnd Bergmann wrote: > >> +Required properties: > >> +- status: Either "ok" or "disabled". > >> +- device_type: set to "pci" > >> +- compatible: should contain "xgene,pcie" to identify the core. > >> +- reg: base

Re: [RFC PATCH 3/3] dt-bindings: pci: xgene pcie device tree bindings

2014-01-07 Thread Arnd Bergmann
On Tuesday 07 January 2014, Tanmay Inamdar wrote: On Fri, Jan 3, 2014 at 1:49 AM, Arnd Bergmann a...@arndb.de wrote: +Required properties: +- status: Either ok or disabled. +- device_type: set to pci +- compatible: should contain xgene,pcie to identify the core. +- reg: base addresses

Re: [RFC PATCH 3/3] dt-bindings: pci: xgene pcie device tree bindings

2014-01-07 Thread Arnd Bergmann
On Tuesday 07 January 2014 16:35:01 Arnd Bergmann wrote: +SoC specific DT Entry: + pcie0: pcie@1f2b { + status = disabled; + device_type = pci; + compatible = xgene,pcie; + #interrupt-cells = 1; + #size-cells

Re: [RFC PATCH 3/3] dt-bindings: pci: xgene pcie device tree bindings

2014-01-07 Thread Jason Gunthorpe
On Tue, Jan 07, 2014 at 04:35:01PM +0100, Arnd Bergmann wrote: + 0x 0x0 0xd000 0xe0 0xd000 0x0 0x0020 /* cfg */ config space is not normally in the ranges property, and I think you will need it in the pcie node itself as a 'reg'

Re: [RFC PATCH 3/3] dt-bindings: pci: xgene pcie device tree bindings

2014-01-06 Thread Tanmay Inamdar
On Fri, Jan 3, 2014 at 1:49 AM, Arnd Bergmann wrote: > On Monday 23 December 2013, Tanmay Inamdar wrote: >> This patch adds the bindings for X-Gene PCIe driver. The driver resides >> under 'drivers/pci/host/pcie-xgene.c' file. >> >> Signed-off-by: Tanmay Inamdar >> --- >>

Re: [RFC PATCH 3/3] dt-bindings: pci: xgene pcie device tree bindings

2014-01-06 Thread Tanmay Inamdar
On Fri, Jan 3, 2014 at 1:49 AM, Arnd Bergmann a...@arndb.de wrote: On Monday 23 December 2013, Tanmay Inamdar wrote: This patch adds the bindings for X-Gene PCIe driver. The driver resides under 'drivers/pci/host/pcie-xgene.c' file. Signed-off-by: Tanmay Inamdar tinam...@apm.com ---

Re: [RFC PATCH 3/3] dt-bindings: pci: xgene pcie device tree bindings

2014-01-03 Thread Arnd Bergmann
On Monday 23 December 2013, Tanmay Inamdar wrote: > This patch adds the bindings for X-Gene PCIe driver. The driver resides > under 'drivers/pci/host/pcie-xgene.c' file. > > Signed-off-by: Tanmay Inamdar > --- > .../devicetree/bindings/pci/xgene-pcie.txt | 43 > >

Re: [RFC PATCH 3/3] dt-bindings: pci: xgene pcie device tree bindings

2014-01-03 Thread Arnd Bergmann
On Monday 23 December 2013, Tanmay Inamdar wrote: This patch adds the bindings for X-Gene PCIe driver. The driver resides under 'drivers/pci/host/pcie-xgene.c' file. Signed-off-by: Tanmay Inamdar tinam...@apm.com --- .../devicetree/bindings/pci/xgene-pcie.txt | 43

[RFC PATCH 3/3] dt-bindings: pci: xgene pcie device tree bindings

2013-12-23 Thread Tanmay Inamdar
This patch adds the bindings for X-Gene PCIe driver. The driver resides under 'drivers/pci/host/pcie-xgene.c' file. Signed-off-by: Tanmay Inamdar --- .../devicetree/bindings/pci/xgene-pcie.txt | 43 1 file changed, 43 insertions(+) create mode 100644

[RFC PATCH 3/3] dt-bindings: pci: xgene pcie device tree bindings

2013-12-23 Thread Tanmay Inamdar
This patch adds the bindings for X-Gene PCIe driver. The driver resides under 'drivers/pci/host/pcie-xgene.c' file. Signed-off-by: Tanmay Inamdar tinam...@apm.com --- .../devicetree/bindings/pci/xgene-pcie.txt | 43 1 file changed, 43 insertions(+) create mode