Re: [RFC PATCH v3 13/13] kasan: introduce inline instrumentation

2014-09-29 Thread Andrey Ryabinin
On 09/29/2014 06:28 PM, Dmitry Vyukov wrote: > On Fri, Sep 26, 2014 at 9:33 PM, Andrey Ryabinin > wrote: >> 2014-09-26 21:18 GMT+04:00 Dmitry Vyukov : >>> >>> Yikes! >>> So this works during bootstrap, for user memory accesses, valloc >>> memory, etc, right? >>> >> >> Yes, this works. Userspace

Re: [RFC PATCH v3 13/13] kasan: introduce inline instrumentation

2014-09-29 Thread Dmitry Vyukov
On Fri, Sep 26, 2014 at 9:33 PM, Andrey Ryabinin wrote: > 2014-09-26 21:18 GMT+04:00 Dmitry Vyukov : >> >> Yikes! >> So this works during bootstrap, for user memory accesses, valloc >> memory, etc, right? >> > > Yes, this works. Userspace memory access in instrumented code will > produce general

Re: [RFC PATCH v3 13/13] kasan: introduce inline instrumentation

2014-09-29 Thread Dmitry Vyukov
On Wed, Sep 24, 2014 at 4:44 PM, Andrey Ryabinin wrote: > This patch only demonstration how easy this could be achieved. > GCC doesn't support this feature yet. Two patches required for this: > https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00452.html >

Re: [RFC PATCH v3 13/13] kasan: introduce inline instrumentation

2014-09-29 Thread Dmitry Vyukov
On Wed, Sep 24, 2014 at 4:44 PM, Andrey Ryabinin a.ryabi...@samsung.com wrote: This patch only demonstration how easy this could be achieved. GCC doesn't support this feature yet. Two patches required for this: https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00452.html

Re: [RFC PATCH v3 13/13] kasan: introduce inline instrumentation

2014-09-29 Thread Dmitry Vyukov
On Fri, Sep 26, 2014 at 9:33 PM, Andrey Ryabinin ryabinin@gmail.com wrote: 2014-09-26 21:18 GMT+04:00 Dmitry Vyukov dvyu...@google.com: Yikes! So this works during bootstrap, for user memory accesses, valloc memory, etc, right? Yes, this works. Userspace memory access in instrumented

Re: [RFC PATCH v3 13/13] kasan: introduce inline instrumentation

2014-09-29 Thread Andrey Ryabinin
On 09/29/2014 06:28 PM, Dmitry Vyukov wrote: On Fri, Sep 26, 2014 at 9:33 PM, Andrey Ryabinin ryabinin@gmail.com wrote: 2014-09-26 21:18 GMT+04:00 Dmitry Vyukov dvyu...@google.com: Yikes! So this works during bootstrap, for user memory accesses, valloc memory, etc, right? Yes, this

Re: [RFC PATCH v3 13/13] kasan: introduce inline instrumentation

2014-09-26 Thread Andrey Ryabinin
2014-09-26 21:18 GMT+04:00 Dmitry Vyukov : > > Yikes! > So this works during bootstrap, for user memory accesses, valloc > memory, etc, right? > Yes, this works. Userspace memory access in instrumented code will produce general protection fault, so it won't be unnoticed. -- Best regards,

Re: [RFC PATCH v3 13/13] kasan: introduce inline instrumentation

2014-09-26 Thread Dmitry Vyukov
On Wed, Sep 24, 2014 at 5:44 AM, Andrey Ryabinin wrote: > This patch only demonstration how easy this could be achieved. > GCC doesn't support this feature yet. Two patches required for this: > https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00452.html >

Re: [RFC PATCH v3 13/13] kasan: introduce inline instrumentation

2014-09-26 Thread Dmitry Vyukov
On Wed, Sep 24, 2014 at 5:44 AM, Andrey Ryabinin a.ryabi...@samsung.com wrote: This patch only demonstration how easy this could be achieved. GCC doesn't support this feature yet. Two patches required for this: https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00452.html

Re: [RFC PATCH v3 13/13] kasan: introduce inline instrumentation

2014-09-26 Thread Andrey Ryabinin
2014-09-26 21:18 GMT+04:00 Dmitry Vyukov dvyu...@google.com: Yikes! So this works during bootstrap, for user memory accesses, valloc memory, etc, right? Yes, this works. Userspace memory access in instrumented code will produce general protection fault, so it won't be unnoticed. -- Best

[RFC PATCH v3 13/13] kasan: introduce inline instrumentation

2014-09-24 Thread Andrey Ryabinin
This patch only demonstration how easy this could be achieved. GCC doesn't support this feature yet. Two patches required for this: https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00452.html https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00605.html In inline instrumentation mode compiler

[RFC PATCH v3 13/13] kasan: introduce inline instrumentation

2014-09-24 Thread Andrey Ryabinin
This patch only demonstration how easy this could be achieved. GCC doesn't support this feature yet. Two patches required for this: https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00452.html https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00605.html In inline instrumentation mode compiler