Re: [RFC Part2 PATCH v3 05/26] KVM: SVM: Reserve ASID range for SEV guest

2017-09-12 Thread Borislav Petkov
On Tue, Sep 12, 2017 at 03:24:05PM -0500, Brijesh Singh wrote: > > If anything, this comment should explain what that variable is. > > Basically the comment you have in sev_hardware_setup() now. > > > > Will add more comments. I didn't mean that - I meant that /* Secure Encrypted Virtualization

Re: [RFC Part2 PATCH v3 05/26] KVM: SVM: Reserve ASID range for SEV guest

2017-09-12 Thread Borislav Petkov
On Tue, Sep 12, 2017 at 03:24:05PM -0500, Brijesh Singh wrote: > > If anything, this comment should explain what that variable is. > > Basically the comment you have in sev_hardware_setup() now. > > > > Will add more comments. I didn't mean that - I meant that /* Secure Encrypted Virtualization

Re: [RFC Part2 PATCH v3 05/26] KVM: SVM: Reserve ASID range for SEV guest

2017-09-12 Thread Brijesh Singh
On 09/12/2017 03:04 PM, Borislav Petkov wrote: ... SEV-enabled guest is from 1 to a maximum value defined via CPUID Fn8000_001f[ECX]. I'd rewrite that to: "The range of allowed SEV guest ASIDs is [1 - CPUID_8000_001F[ECX][31:0]]". thanks, will do. ... +/* Secure Encrypted

Re: [RFC Part2 PATCH v3 05/26] KVM: SVM: Reserve ASID range for SEV guest

2017-09-12 Thread Brijesh Singh
On 09/12/2017 03:04 PM, Borislav Petkov wrote: ... SEV-enabled guest is from 1 to a maximum value defined via CPUID Fn8000_001f[ECX]. I'd rewrite that to: "The range of allowed SEV guest ASIDs is [1 - CPUID_8000_001F[ECX][31:0]]". thanks, will do. ... +/* Secure Encrypted

Re: [RFC Part2 PATCH v3 05/26] KVM: SVM: Reserve ASID range for SEV guest

2017-09-12 Thread Borislav Petkov
On Mon, Jul 24, 2017 at 03:02:42PM -0500, Brijesh Singh wrote: > SEV-enabled guest must use ASIDs from the defined subset, while non-SEV "A SEV-enabled ..." > guests can use the remaining ASID range. The range of ASID allowed for > SEV-enabled guest is from 1 to a maximum value defined via CPUID

Re: [RFC Part2 PATCH v3 05/26] KVM: SVM: Reserve ASID range for SEV guest

2017-09-12 Thread Borislav Petkov
On Mon, Jul 24, 2017 at 03:02:42PM -0500, Brijesh Singh wrote: > SEV-enabled guest must use ASIDs from the defined subset, while non-SEV "A SEV-enabled ..." > guests can use the remaining ASID range. The range of ASID allowed for > SEV-enabled guest is from 1 to a maximum value defined via CPUID

[RFC Part2 PATCH v3 05/26] KVM: SVM: Reserve ASID range for SEV guest

2017-07-24 Thread Brijesh Singh
SEV-enabled guest must use ASIDs from the defined subset, while non-SEV guests can use the remaining ASID range. The range of ASID allowed for SEV-enabled guest is from 1 to a maximum value defined via CPUID Fn8000_001f[ECX]. Signed-off-by: Brijesh Singh ---

[RFC Part2 PATCH v3 05/26] KVM: SVM: Reserve ASID range for SEV guest

2017-07-24 Thread Brijesh Singh
SEV-enabled guest must use ASIDs from the defined subset, while non-SEV guests can use the remaining ASID range. The range of ASID allowed for SEV-enabled guest is from 1 to a maximum value defined via CPUID Fn8000_001f[ECX]. Signed-off-by: Brijesh Singh --- arch/x86/kvm/svm.c | 23