Re: [Suggestion] drivers/staging/tidspbridge: strcpy and strncpy, src length checking issue.

2013-01-05 Thread Chen Gang
于 2013年01月05日 19:17, Omar Ramirez Luna 写道: > Hi, > > On Thu, Dec 13, 2012 at 9:50 PM, Chen Gang wrote: >> in drivers/staging/tidspbridge/rmgr/proc.c: >> >> if strlen(drv_datap->base_img) == size, will pass checking (line 397) >> the size is the full length of exec_file (line 382, line

Re: [Suggestion] drivers/staging/tidspbridge: strcpy and strncpy, src length checking issue.

2013-01-05 Thread Omar Ramirez Luna
Hi, On Thu, Dec 13, 2012 at 9:50 PM, Chen Gang wrote: > in drivers/staging/tidspbridge/rmgr/proc.c: > > if strlen(drv_datap->base_img) == size, will pass checking (line 397) > the size is the full length of exec_file (line 382, line 468..469) > strcpy causes issue: src len is

Re: [Suggestion] drivers/staging/tidspbridge: strcpy and strncpy, src length checking issue.

2013-01-05 Thread Omar Ramirez Luna
Hi, On Sun, Dec 30, 2012 at 9:28 PM, Chen Gang wrote: > is it suitable to send a patch for it, by me ? Thanks for your suggestions, I have created the patches and will submit them soon, but feel free to submit patches for any other suggestions in future. Cheers, Omar -- To unsubscribe from

Re: [Suggestion] drivers/staging/tidspbridge: strcpy and strncpy, src length checking issue.

2013-01-05 Thread Omar Ramirez Luna
Hi, On Sun, Dec 30, 2012 at 9:28 PM, Chen Gang gang.c...@asianux.com wrote: is it suitable to send a patch for it, by me ? Thanks for your suggestions, I have created the patches and will submit them soon, but feel free to submit patches for any other suggestions in future. Cheers, Omar --

Re: [Suggestion] drivers/staging/tidspbridge: strcpy and strncpy, src length checking issue.

2013-01-05 Thread Omar Ramirez Luna
Hi, On Thu, Dec 13, 2012 at 9:50 PM, Chen Gang gang.c...@asianux.com wrote: in drivers/staging/tidspbridge/rmgr/proc.c: if strlen(drv_datap-base_img) == size, will pass checking (line 397) the size is the full length of exec_file (line 382, line 468..469) strcpy causes issue:

Re: [Suggestion] drivers/staging/tidspbridge: strcpy and strncpy, src length checking issue.

2013-01-05 Thread Chen Gang
于 2013年01月05日 19:17, Omar Ramirez Luna 写道: Hi, On Thu, Dec 13, 2012 at 9:50 PM, Chen Gang gang.c...@asianux.com wrote: in drivers/staging/tidspbridge/rmgr/proc.c: if strlen(drv_datap-base_img) == size, will pass checking (line 397) the size is the full length of exec_file (line

Re: [Suggestion] drivers/staging/tidspbridge: strcpy and strncpy, src length checking issue.

2012-12-30 Thread Chen Gang
Hi Omar Ramirez Luna: Since you are really too busy. is it suitable to send a patch for it, by me ? no reply within a week, means it is suitable. :-) gchen. 于 2012年12月14日 11:50, Chen Gang 写道: > Hello Omar Ramirez Luna: > > in drivers/staging/tidspbridge/rmgr/proc.c: > > if

Re: [Suggestion] drivers/staging/tidspbridge: strcpy and strncpy, src length checking issue.

2012-12-30 Thread Chen Gang
Hi Omar Ramirez Luna: Since you are really too busy. is it suitable to send a patch for it, by me ? no reply within a week, means it is suitable. :-) gchen. 于 2012年12月14日 11:50, Chen Gang 写道: Hello Omar Ramirez Luna: in drivers/staging/tidspbridge/rmgr/proc.c: if

Re: [Suggestion] drivers/staging/tidspbridge: strcpy and strncpy, src length checking issue.

2012-12-25 Thread Chen Gang
于 2012年12月24日 22:27, Omar Ramirez Luna 写道: > Hi Gchen, > > On Mon, Dec 17, 2012 at 8:40 PM, Chen Gang wrote: >> Hello Omar Ramirez Luna: >> >> excuse me to bother you (maybe you are busy in these days). >> please help checking this suggestion when you have free time. > > Yes, I'm checking

Re: [Suggestion] drivers/staging/tidspbridge: strcpy and strncpy, src length checking issue.

2012-12-25 Thread Chen Gang
于 2012年12月24日 22:27, Omar Ramirez Luna 写道: Hi Gchen, On Mon, Dec 17, 2012 at 8:40 PM, Chen Gang gang.c...@asianux.com wrote: Hello Omar Ramirez Luna: excuse me to bother you (maybe you are busy in these days). please help checking this suggestion when you have free time. Yes, I'm

Re: [Suggestion] drivers/staging/tidspbridge: strcpy and strncpy, src length checking issue.

2012-12-24 Thread Omar Ramirez Luna
Hi Gchen, On Mon, Dec 17, 2012 at 8:40 PM, Chen Gang wrote: > Hello Omar Ramirez Luna: > > excuse me to bother you (maybe you are busy in these days). > please help checking this suggestion when you have free time. Yes, I'm checking your suggestions, I was a little busy last week, for the

Re: [Suggestion] drivers/staging/tidspbridge: strcpy and strncpy, src length checking issue.

2012-12-24 Thread Omar Ramirez Luna
Hi Gchen, On Mon, Dec 17, 2012 at 8:40 PM, Chen Gang gang.c...@asianux.com wrote: Hello Omar Ramirez Luna: excuse me to bother you (maybe you are busy in these days). please help checking this suggestion when you have free time. Yes, I'm checking your suggestions, I was a little busy

Re: [Suggestion] drivers/staging/tidspbridge: strcpy and strncpy, src length checking issue.

2012-12-17 Thread Chen Gang
Hello Omar Ramirez Luna: excuse me to bother you (maybe you are busy in these days). please help checking this suggestion when you have free time. my suggestion may be not valid (I already have at least 9 fault which I made) for example of my fault: A) net/atm: "%pM means format

Re: [Suggestion] drivers/staging/tidspbridge: strcpy and strncpy, src length checking issue.

2012-12-17 Thread Chen Gang
Hello Omar Ramirez Luna: excuse me to bother you (maybe you are busy in these days). please help checking this suggestion when you have free time. my suggestion may be not valid (I already have at least 9 fault which I made) for example of my fault: A) net/atm: "%pM means format

Re: [Suggestion] drivers/staging/tidspbridge: strcpy and strncpy, src length checking issue.

2012-12-17 Thread Chen Gang
Hello Omar Ramirez Luna: excuse me to bother you (maybe you are busy in these days). please help checking this suggestion when you have free time. my suggestion may be not valid (I already have at least 9 fault which I made) for example of my fault: A) net/atm: %pM means format this

Re: [Suggestion] drivers/staging/tidspbridge: strcpy and strncpy, src length checking issue.

2012-12-17 Thread Chen Gang
Hello Omar Ramirez Luna: excuse me to bother you (maybe you are busy in these days). please help checking this suggestion when you have free time. my suggestion may be not valid (I already have at least 9 fault which I made) for example of my fault: A) net/atm: %pM means format this

[Suggestion] drivers/staging/tidspbridge: strcpy and strncpy, src length checking issue.

2012-12-13 Thread Chen Gang
Hello Omar Ramirez Luna: in drivers/staging/tidspbridge/rmgr/proc.c: if strlen(drv_datap->base_img) == size, will pass checking (line 397) the size is the full length of exec_file (line 382, line 468..469) strcpy causes issue: src len is strlen(drv_datap->base_img) + '\0'. (line

[Suggestion] drivers/staging/tidspbridge: strcpy and strncpy, src length checking issue.

2012-12-13 Thread Chen Gang
Hello Omar Ramirez Luna: in drivers/staging/tidspbridge/rmgr/proc.c: if strlen(drv_datap-base_img) == size, will pass checking (line 397) the size is the full length of exec_file (line 382, line 468..469) strcpy causes issue: src len is strlen(drv_datap-base_img) + '\0'. (line