Re: [alsa-devel] [PATCH v2 6/9] ASoC: mediatek: add mt2701 platform driver implementation.

2016-06-09 Thread Mark Brown
On Wed, Jun 08, 2016 at 11:32:22AM +0800, Garlic Tseng wrote: > On Tue, 2016-06-07 at 17:31 +0100, Mark Brown wrote: > > > + SOC_DAPM_SINGLE_AUTODISABLE("Multi ch asrc out3", PWR2_TOP_CON, 7, 1, > > > + 1), > > > +}; > > On/off controls should end in Switch. > Do you

Re: [alsa-devel] [PATCH v2 6/9] ASoC: mediatek: add mt2701 platform driver implementation.

2016-06-09 Thread Mark Brown
On Wed, Jun 08, 2016 at 11:32:22AM +0800, Garlic Tseng wrote: > On Tue, 2016-06-07 at 17:31 +0100, Mark Brown wrote: > > > + SOC_DAPM_SINGLE_AUTODISABLE("Multi ch asrc out3", PWR2_TOP_CON, 7, 1, > > > + 1), > > > +}; > > On/off controls should end in Switch. > Do you

Re: [alsa-devel] [PATCH v2 6/9] ASoC: mediatek: add mt2701 platform driver implementation.

2016-06-07 Thread Garlic Tseng
On Tue, 2016-06-07 at 17:31 +0100, Mark Brown wrote: > On Fri, Jun 03, 2016 at 12:56:21PM +0800, Garlic Tseng wrote: > > > + if (val < 0 || val > MT2701_I2S_NUM) { > > + dev_err(afe->dev, "%s, num not available, num %d, val %d\n", > > + __func__, num, val); > > +

Re: [alsa-devel] [PATCH v2 6/9] ASoC: mediatek: add mt2701 platform driver implementation.

2016-06-07 Thread Garlic Tseng
On Tue, 2016-06-07 at 17:31 +0100, Mark Brown wrote: > On Fri, Jun 03, 2016 at 12:56:21PM +0800, Garlic Tseng wrote: > > > + if (val < 0 || val > MT2701_I2S_NUM) { > > + dev_err(afe->dev, "%s, num not available, num %d, val %d\n", > > + __func__, num, val); > > +

Re: [alsa-devel] [PATCH v2 6/9] ASoC: mediatek: add mt2701 platform driver implementation.

2016-06-07 Thread Mark Brown
On Fri, Jun 03, 2016 at 12:56:21PM +0800, Garlic Tseng wrote: > + if (val < 0 || val > MT2701_I2S_NUM) { > + dev_err(afe->dev, "%s, num not available, num %d, val %d\n", > + __func__, num, val); > + return -1; Real error codes please. > +static

Re: [alsa-devel] [PATCH v2 6/9] ASoC: mediatek: add mt2701 platform driver implementation.

2016-06-07 Thread Mark Brown
On Fri, Jun 03, 2016 at 12:56:21PM +0800, Garlic Tseng wrote: > + if (val < 0 || val > MT2701_I2S_NUM) { > + dev_err(afe->dev, "%s, num not available, num %d, val %d\n", > + __func__, num, val); > + return -1; Real error codes please. > +static

[alsa-devel] [PATCH v2 6/9] ASoC: mediatek: add mt2701 platform driver implementation.

2016-06-02 Thread Garlic Tseng
Add mt2701 platform driver implementation for playback and capture. The implement follow DAPM structure (memory interface as FE and I2S as BE). Because of the hardware design, i2s out required to be enabled when we need to enable i2s in. This patch includes the implementation. Signed-off-by:

[alsa-devel] [PATCH v2 6/9] ASoC: mediatek: add mt2701 platform driver implementation.

2016-06-02 Thread Garlic Tseng
Add mt2701 platform driver implementation for playback and capture. The implement follow DAPM structure (memory interface as FE and I2S as BE). Because of the hardware design, i2s out required to be enabled when we need to enable i2s in. This patch includes the implementation. Signed-off-by: