Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-14 Thread Lee Jones
On Fri, 14 Feb 2014, Laszlo Papp wrote: > On Fri, Feb 14, 2014 at 9:02 AM, Lee Jones wrote: > >> >> http://comments.gmane.org/gmane.linux.kernel/1645251 > >> >> > >> >> Step 2 did not happen. I did not get any review for my change. I > >> >> literally submitted that within a couple of hours

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-14 Thread Laszlo Papp
On Fri, Feb 14, 2014 at 9:02 AM, Lee Jones wrote: >> >> http://comments.gmane.org/gmane.linux.kernel/1645251 >> >> >> >> Step 2 did not happen. I did not get any review for my change. I >> >> literally submitted that within a couple of hours after the request. >> >> >> >> Could you please tell me

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-14 Thread Lee Jones
> -static int max6650_probe(struct i2c_client *client, > -const struct i2c_device_id *id); > -static int max6650_init_client(struct i2c_client *client); > -static int max6650_remove(struct i2c_client *client); > +static int

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-14 Thread Lee Jones
> >> http://comments.gmane.org/gmane.linux.kernel/1645251 > >> > >> Step 2 did not happen. I did not get any review for my change. I > >> literally submitted that within a couple of hours after the request. > >> > >> Could you please tell me what was wrong with that change, and why I > >> did not

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-14 Thread Lee Jones
http://comments.gmane.org/gmane.linux.kernel/1645251 Step 2 did not happen. I did not get any review for my change. I literally submitted that within a couple of hours after the request. Could you please tell me what was wrong with that change, and why I did not get any respect not

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-14 Thread Lee Jones
-static int max6650_probe(struct i2c_client *client, -const struct i2c_device_id *id); -static int max6650_init_client(struct i2c_client *client); -static int max6650_remove(struct i2c_client *client); +static int max6650_probe(struct platform_device *pdev); +static

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-14 Thread Laszlo Papp
On Fri, Feb 14, 2014 at 9:02 AM, Lee Jones lee.jo...@linaro.org wrote: http://comments.gmane.org/gmane.linux.kernel/1645251 Step 2 did not happen. I did not get any review for my change. I literally submitted that within a couple of hours after the request. Could you please tell me

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-14 Thread Lee Jones
On Fri, 14 Feb 2014, Laszlo Papp wrote: On Fri, Feb 14, 2014 at 9:02 AM, Lee Jones lee.jo...@linaro.org wrote: http://comments.gmane.org/gmane.linux.kernel/1645251 Step 2 did not happen. I did not get any review for my change. I literally submitted that within a couple of hours after

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Laszlo Papp
On Thu, Feb 13, 2014 at 12:40 PM, Lee Jones wrote: >> http://comments.gmane.org/gmane.linux.kernel/1645251 >> >> Step 2 did not happen. I did not get any review for my change. I >> literally submitted that within a couple of hours after the request. >> >> Could you please tell me what was wrong

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Laszlo Papp
On Thu, Feb 13, 2014 at 4:16 PM, Guenter Roeck wrote: > On 02/13/2014 04:27 AM, Laszlo Papp wrote: >> >> On Thu, Feb 13, 2014 at 11:33 AM, Lee Jones wrote: -static int max6650_probe(struct i2c_client *client, -const struct i2c_device_id *id);

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Guenter Roeck
On 02/13/2014 03:58 AM, Jean Delvare wrote: Hi Lee, On Thu, 13 Feb 2014 11:16:07 +, Lee Jones wrote: On Thu, 13 Feb 2014, Jean Delvare wrote: Guenter just did: http://lists.lm-sensors.org/pipermail/lm-sensors/2014-February/041224.html Nice, FWIW: Acked-by: Lee Jones Any change to

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Guenter Roeck
On 02/13/2014 04:27 AM, Laszlo Papp wrote: On Thu, Feb 13, 2014 at 11:33 AM, Lee Jones wrote: -static int max6650_probe(struct i2c_client *client, -const struct i2c_device_id *id); -static int max6650_init_client(struct i2c_client *client); -static int max6650_remove(struct

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Laszlo Papp
On Thu, Feb 13, 2014 at 12:57 PM, Jean Delvare wrote: > Hi Laszlo, > > On Thu, 13 Feb 2014 12:27:28 +, Laszlo Papp wrote: >> On Thu, Feb 13, 2014 at 11:33 AM, Lee Jones wrote: >> > Right, I've had enough. I'm removing your patch from the MFD tree. >> > >> > I've asked too many people to give

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Jean Delvare
Hi Laszlo, On Thu, 13 Feb 2014 12:27:28 +, Laszlo Papp wrote: > On Thu, Feb 13, 2014 at 11:33 AM, Lee Jones wrote: > > Right, I've had enough. I'm removing your patch from the MFD tree. > > > > I've asked too many people to give you a second chance and asked you > > privately to behave

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Lee Jones
> http://comments.gmane.org/gmane.linux.kernel/1645251 > > Step 2 did not happen. I did not get any review for my change. I > literally submitted that within a couple of hours after the request. > > Could you please tell me what was wrong with that change, and why I > did not get any respect not

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Laszlo Papp
On Thu, Feb 13, 2014 at 11:33 AM, Lee Jones wrote: >> >>> > -static int max6650_probe(struct i2c_client *client, >> >>> > -const struct i2c_device_id *id); >> >>> > -static int max6650_init_client(struct i2c_client *client); >> >>> > -static int max6650_remove(struct

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Jean Delvare
Hi Lee, On Thu, 13 Feb 2014 11:16:07 +, Lee Jones wrote: > On Thu, 13 Feb 2014, Jean Delvare wrote: > > Guenter just did: > > > > http://lists.lm-sensors.org/pipermail/lm-sensors/2014-February/041224.html > > Nice, FWIW: > Acked-by: Lee Jones > > > Any change to the max6650 driver

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Lee Jones
> >>> > -static int max6650_probe(struct i2c_client *client, > >>> > -const struct i2c_device_id *id); > >>> > -static int max6650_init_client(struct i2c_client *client); > >>> > -static int max6650_remove(struct i2c_client *client); > >>> > +static int max6650_probe(struct

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Laszlo Papp
I will try hard to concentrate on the technical and fruitful stuff in the reply... On Thu, Feb 13, 2014 at 11:07 AM, Jean Delvare wrote: > Hi Laszlo, > > Le Thursday 13 February 2014 à 10:46 +, Laszlo Papp a écrit : >> On Thu, Feb 13, 2014 at 10:38 AM, Laszlo Papp wrote: >> > On Thu, Feb

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Lee Jones
On Thu, 13 Feb 2014, Jean Delvare wrote: > On Thu, 13 Feb 2014 09:58:17 +, Lee Jones wrote: > > > The MFD driver has now been added, so this driver is now being adopted to > > > be a > > > subdevice driver on top of it. This means, the i2c driver usage is being > > > converted to platform

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Jean Delvare
Hi Laszlo, Le Thursday 13 February 2014 à 10:46 +, Laszlo Papp a écrit : > On Thu, Feb 13, 2014 at 10:38 AM, Laszlo Papp wrote: > > On Thu, Feb 13, 2014 at 10:15 AM, Jean Delvare wrote: > >> Any change to the max6650 driver should go on top of his patch series > >> to avoid conflicts: > >>

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Laszlo Papp
On Thu, Feb 13, 2014 at 10:38 AM, Laszlo Papp wrote: > On Thu, Feb 13, 2014 at 10:15 AM, Jean Delvare wrote: >> On Thu, 13 Feb 2014 09:58:17 +, Lee Jones wrote: >>> > The MFD driver has now been added, so this driver is now being adopted to >>> > be a >>> > subdevice driver on top of it.

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Laszlo Papp
On Thu, Feb 13, 2014 at 10:15 AM, Jean Delvare wrote: > On Thu, 13 Feb 2014 09:58:17 +, Lee Jones wrote: >> > The MFD driver has now been added, so this driver is now being adopted to >> > be a >> > subdevice driver on top of it. This means, the i2c driver usage is being >> > converted to

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Jean Delvare
On Thu, 13 Feb 2014 09:58:17 +, Lee Jones wrote: > > The MFD driver has now been added, so this driver is now being adopted to > > be a > > subdevice driver on top of it. This means, the i2c driver usage is being > > converted to platform driver usage all around. > > > > Signed-off-by:

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Jean Delvare
On Thu, 13 Feb 2014 09:58:17 +, Lee Jones wrote: The MFD driver has now been added, so this driver is now being adopted to be a subdevice driver on top of it. This means, the i2c driver usage is being converted to platform driver usage all around. Signed-off-by: Laszlo Papp

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Laszlo Papp
On Thu, Feb 13, 2014 at 10:15 AM, Jean Delvare jdelv...@suse.de wrote: On Thu, 13 Feb 2014 09:58:17 +, Lee Jones wrote: The MFD driver has now been added, so this driver is now being adopted to be a subdevice driver on top of it. This means, the i2c driver usage is being converted to

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Laszlo Papp
On Thu, Feb 13, 2014 at 10:38 AM, Laszlo Papp lp...@kde.org wrote: On Thu, Feb 13, 2014 at 10:15 AM, Jean Delvare jdelv...@suse.de wrote: On Thu, 13 Feb 2014 09:58:17 +, Lee Jones wrote: The MFD driver has now been added, so this driver is now being adopted to be a subdevice driver on

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Jean Delvare
Hi Laszlo, Le Thursday 13 February 2014 à 10:46 +, Laszlo Papp a écrit : On Thu, Feb 13, 2014 at 10:38 AM, Laszlo Papp lp...@kde.org wrote: On Thu, Feb 13, 2014 at 10:15 AM, Jean Delvare jdelv...@suse.de wrote: Any change to the max6650 driver should go on top of his patch series to

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Lee Jones
On Thu, 13 Feb 2014, Jean Delvare wrote: On Thu, 13 Feb 2014 09:58:17 +, Lee Jones wrote: The MFD driver has now been added, so this driver is now being adopted to be a subdevice driver on top of it. This means, the i2c driver usage is being converted to platform driver usage

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Laszlo Papp
I will try hard to concentrate on the technical and fruitful stuff in the reply... On Thu, Feb 13, 2014 at 11:07 AM, Jean Delvare jdelv...@suse.de wrote: Hi Laszlo, Le Thursday 13 February 2014 à 10:46 +, Laszlo Papp a écrit : On Thu, Feb 13, 2014 at 10:38 AM, Laszlo Papp lp...@kde.org

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Lee Jones
-static int max6650_probe(struct i2c_client *client, -const struct i2c_device_id *id); -static int max6650_init_client(struct i2c_client *client); -static int max6650_remove(struct i2c_client *client); +static int max6650_probe(struct platform_device *pdev);

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Jean Delvare
Hi Lee, On Thu, 13 Feb 2014 11:16:07 +, Lee Jones wrote: On Thu, 13 Feb 2014, Jean Delvare wrote: Guenter just did: http://lists.lm-sensors.org/pipermail/lm-sensors/2014-February/041224.html Nice, FWIW: Acked-by: Lee Jones lee.jo...@linaro.org Any change to the max6650

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Laszlo Papp
On Thu, Feb 13, 2014 at 11:33 AM, Lee Jones lee.jo...@linaro.org wrote: -static int max6650_probe(struct i2c_client *client, -const struct i2c_device_id *id); -static int max6650_init_client(struct i2c_client *client); -static int max6650_remove(struct i2c_client

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Lee Jones
http://comments.gmane.org/gmane.linux.kernel/1645251 Step 2 did not happen. I did not get any review for my change. I literally submitted that within a couple of hours after the request. Could you please tell me what was wrong with that change, and why I did not get any respect not to

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Jean Delvare
Hi Laszlo, On Thu, 13 Feb 2014 12:27:28 +, Laszlo Papp wrote: On Thu, Feb 13, 2014 at 11:33 AM, Lee Jones lee.jo...@linaro.org wrote: Right, I've had enough. I'm removing your patch from the MFD tree. I've asked too many people to give you a second chance and asked you

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Laszlo Papp
On Thu, Feb 13, 2014 at 12:57 PM, Jean Delvare jdelv...@suse.de wrote: Hi Laszlo, On Thu, 13 Feb 2014 12:27:28 +, Laszlo Papp wrote: On Thu, Feb 13, 2014 at 11:33 AM, Lee Jones lee.jo...@linaro.org wrote: Right, I've had enough. I'm removing your patch from the MFD tree. I've asked

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Guenter Roeck
On 02/13/2014 04:27 AM, Laszlo Papp wrote: On Thu, Feb 13, 2014 at 11:33 AM, Lee Jones lee.jo...@linaro.org wrote: -static int max6650_probe(struct i2c_client *client, -const struct i2c_device_id *id); -static int max6650_init_client(struct i2c_client *client); -static int

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Guenter Roeck
On 02/13/2014 03:58 AM, Jean Delvare wrote: Hi Lee, On Thu, 13 Feb 2014 11:16:07 +, Lee Jones wrote: On Thu, 13 Feb 2014, Jean Delvare wrote: Guenter just did: http://lists.lm-sensors.org/pipermail/lm-sensors/2014-February/041224.html Nice, FWIW: Acked-by: Lee Jones

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Laszlo Papp
On Thu, Feb 13, 2014 at 4:16 PM, Guenter Roeck li...@roeck-us.net wrote: On 02/13/2014 04:27 AM, Laszlo Papp wrote: On Thu, Feb 13, 2014 at 11:33 AM, Lee Jones lee.jo...@linaro.org wrote: -static int max6650_probe(struct i2c_client *client, -const struct i2c_device_id

Re: [lm-sensors] [RFC PATCH] hwmon: (max6650) Convert to be a platform driver

2014-02-13 Thread Laszlo Papp
On Thu, Feb 13, 2014 at 12:40 PM, Lee Jones lee.jo...@linaro.org wrote: http://comments.gmane.org/gmane.linux.kernel/1645251 Step 2 did not happen. I did not get any review for my change. I literally submitted that within a couple of hours after the request. Could you please tell me what was