Re: [net-next PATCH v5 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

2021-02-16 Thread Calvin Johnson
On Mon, Feb 15, 2021 at 05:15:36PM +0200, Andy Shevchenko wrote: > On Mon, Feb 15, 2021 at 5:13 PM Andy Shevchenko > wrote: > > > > On Mon, Feb 15, 2021 at 2:33 PM Calvin Johnson > > wrote: > > > On Mon, Feb 08, 2021 at 04:28:31PM +, Russell King - ARM Linux admin > > > wrote: > > > > ... >

Re: [net-next PATCH v5 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

2021-02-15 Thread Andy Shevchenko
On Mon, Feb 15, 2021 at 5:13 PM Andy Shevchenko wrote: > > On Mon, Feb 15, 2021 at 2:33 PM Calvin Johnson > wrote: > > On Mon, Feb 08, 2021 at 04:28:31PM +, Russell King - ARM Linux admin > > wrote: > > ... > > > I think of_phy_is_fixed_link() needs to be fixed. I'll add below fix. > > > >

Re: [net-next PATCH v5 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

2021-02-15 Thread Andy Shevchenko
On Mon, Feb 15, 2021 at 2:33 PM Calvin Johnson wrote: > On Mon, Feb 08, 2021 at 04:28:31PM +, Russell King - ARM Linux admin > wrote: ... > I think of_phy_is_fixed_link() needs to be fixed. I'll add below fix. > > --- a/drivers/net/mdio/of_mdio.c > +++ b/drivers/net/mdio/of_mdio.c > @@

Re: [net-next PATCH v5 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

2021-02-15 Thread Calvin Johnson
On Mon, Feb 08, 2021 at 04:28:31PM +, Russell King - ARM Linux admin wrote: > On Mon, Feb 08, 2021 at 08:42:44PM +0530, Calvin Johnson wrote: > > Modify dpaa2_mac_connect() to support ACPI along with DT. > > Modify dpaa2_mac_get_node() to get the dpmac fwnode from either > > DT or ACPI. > > >

Re: [net-next PATCH v5 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

2021-02-08 Thread Russell King - ARM Linux admin
On Mon, Feb 08, 2021 at 08:42:44PM +0530, Calvin Johnson wrote: > Modify dpaa2_mac_connect() to support ACPI along with DT. > Modify dpaa2_mac_get_node() to get the dpmac fwnode from either > DT or ACPI. > > Replace of_get_phy_mode with fwnode_get_phy_mode to get > phy-mode for a dpmac_node. > >

Re: [net-next PATCH v5 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

2021-02-08 Thread Andy Shevchenko
On Mon, Feb 8, 2021 at 5:15 PM Calvin Johnson wrote: > > Modify dpaa2_mac_connect() to support ACPI along with DT. > Modify dpaa2_mac_get_node() to get the dpmac fwnode from either > DT or ACPI. > > Replace of_get_phy_mode with fwnode_get_phy_mode to get > phy-mode for a dpmac_node. > > Use

[net-next PATCH v5 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver

2021-02-08 Thread Calvin Johnson
Modify dpaa2_mac_connect() to support ACPI along with DT. Modify dpaa2_mac_get_node() to get the dpmac fwnode from either DT or ACPI. Replace of_get_phy_mode with fwnode_get_phy_mode to get phy-mode for a dpmac_node. Use helper function phylink_fwnode_phy_connect() to find phy_dev and connect to