Re: [net-next rfc v7 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info

2012-12-04 Thread Jason Wang
On Tuesday, December 04, 2012 02:13:11 PM Rusty Russell wrote: > Jason Wang writes: > > On Monday, December 03, 2012 12:25:42 PM Rusty Russell wrote: > >> > + > >> > +/* Work struct for refilling if we run low on memory. */ > >> > +struct delayed_work refill; > >> > >> I can't

Re: [net-next rfc v7 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info

2012-12-04 Thread Jason Wang
On Monday, December 03, 2012 01:18:48 PM Michael S. Tsirkin wrote: > On Mon, Dec 03, 2012 at 01:15:01PM +0800, Jason Wang wrote: > > > > + > > > > > > > > + /* Work struct for refilling if we run low on memory. */ > > > > > > > > + struct delayed_work refill; > > > > > > I can't really see the

Re: [net-next rfc v7 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info

2012-12-04 Thread Jason Wang
On Monday, December 03, 2012 01:18:48 PM Michael S. Tsirkin wrote: On Mon, Dec 03, 2012 at 01:15:01PM +0800, Jason Wang wrote: + + /* Work struct for refilling if we run low on memory. */ + struct delayed_work refill; I can't really see the justificaiton for a refill

Re: [net-next rfc v7 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info

2012-12-04 Thread Jason Wang
On Tuesday, December 04, 2012 02:13:11 PM Rusty Russell wrote: Jason Wang jasow...@redhat.com writes: On Monday, December 03, 2012 12:25:42 PM Rusty Russell wrote: + +/* Work struct for refilling if we run low on memory. */ +struct delayed_work refill; I can't

Re: [net-next rfc v7 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info

2012-12-03 Thread Rusty Russell
Jason Wang writes: > On Monday, December 03, 2012 12:25:42 PM Rusty Russell wrote: >> > + >> > + /* Work struct for refilling if we run low on memory. */ >> > + struct delayed_work refill; >> >> I can't really see the justificaiton for a refill per queue. Just have >> one work iterate all the

Re: [net-next rfc v7 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info

2012-12-03 Thread Michael S. Tsirkin
On Mon, Dec 03, 2012 at 01:15:01PM +0800, Jason Wang wrote: > > > + > > > > + /* Work struct for refilling if we run low on memory. */ > > > > + struct delayed_work refill; > > > > > > I can't really see the justificaiton for a refill per queue. Just have > > > one work iterate all the queues

Re: [net-next rfc v7 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info

2012-12-03 Thread Michael S. Tsirkin
On Mon, Dec 03, 2012 at 01:15:01PM +0800, Jason Wang wrote: + + /* Work struct for refilling if we run low on memory. */ + struct delayed_work refill; I can't really see the justificaiton for a refill per queue. Just have one work iterate all the queues if it happens,

Re: [net-next rfc v7 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info

2012-12-03 Thread Rusty Russell
Jason Wang jasow...@redhat.com writes: On Monday, December 03, 2012 12:25:42 PM Rusty Russell wrote: + + /* Work struct for refilling if we run low on memory. */ + struct delayed_work refill; I can't really see the justificaiton for a refill per queue. Just have one work iterate all

Re: [net-next rfc v7 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info

2012-12-02 Thread Rusty Russell
Jason Wang writes: > To support multiqueue transmitq/receiveq, the first step is to separate queue > related structure from virtnet_info. This patch introduce send_queue and > receive_queue structure and use the pointer to them as the parameter in > functions handling sending/receiving. OK,

Re: [net-next rfc v7 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info

2012-12-02 Thread Rusty Russell
Jason Wang jasow...@redhat.com writes: To support multiqueue transmitq/receiveq, the first step is to separate queue related structure from virtnet_info. This patch introduce send_queue and receive_queue structure and use the pointer to them as the parameter in functions handling

[net-next rfc v7 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info

2012-11-27 Thread Jason Wang
To support multiqueue transmitq/receiveq, the first step is to separate queue related structure from virtnet_info. This patch introduce send_queue and receive_queue structure and use the pointer to them as the parameter in functions handling sending/receiving. Signed-off-by: Krishna Kumar

[net-next rfc v7 1/3] virtio-net: separate fields of sending/receiving queue from virtnet_info

2012-11-27 Thread Jason Wang
To support multiqueue transmitq/receiveq, the first step is to separate queue related structure from virtnet_info. This patch introduce send_queue and receive_queue structure and use the pointer to them as the parameter in functions handling sending/receiving. Signed-off-by: Krishna Kumar