RE: [patch] [SCSI] mpt3sas: cut and paste bug storing trigger mpi

2012-12-11 Thread Reddy, Sreekanth
h; Support; James E.J. Bottomley; DL-MPT Fusion Linux; linux-s...@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-janit...@vger.kernel.org Subject: [patch] [SCSI] mpt3sas: cut and paste bug storing trigger mpi ioc->diag_trigger_mpi is an SL_WH_MPI_TRIGGERS_T struct. There is a cut an

RE: [patch] [SCSI] mpt3sas: cut and paste bug storing trigger mpi

2012-12-11 Thread Reddy, Sreekanth
, Sreekanth; Support; James E.J. Bottomley; DL-MPT Fusion Linux; linux-s...@vger.kernel.org; linux-kernel@vger.kernel.org; kernel-janit...@vger.kernel.org Subject: [patch] [SCSI] mpt3sas: cut and paste bug storing trigger mpi ioc-diag_trigger_mpi is an SL_WH_MPI_TRIGGERS_T struct. There is a cut

Re: [patch] [SCSI] mpt3sas: cut and paste bug storing trigger mpi

2012-12-07 Thread Dan Carpenter
On Fri, Dec 07, 2012 at 09:41:56AM +0100, Rolf Eike Beer wrote: > > memset(>diag_trigger_mpi, 0, > >-sizeof(struct SL_WH_EVENT_TRIGGERS_T)); > >+sizeof(struct SL_WH_MPI_TRIGGERS_T)); > > memcpy(>diag_trigger_mpi, buf, sz); > > if (ioc->diag_trigger_mpi.ValidEntries >

Re: [patch] [SCSI] mpt3sas: cut and paste bug storing trigger mpi

2012-12-07 Thread Rolf Eike Beer
ioc->diag_trigger_mpi is an SL_WH_MPI_TRIGGERS_T struct. There is a cut and paste error here and SL_WH_EVENT_TRIGGERS_T is used instead of SL_WH_MPI_TRIGGERS_T. Since the SL_WH_EVENT_TRIGGERS_T is smaller than SL_WH_MPI_TRIGGERS_T, it means we only clear part of the buffer. Signed-off-by:

Re: [patch] [SCSI] mpt3sas: cut and paste bug storing trigger mpi

2012-12-07 Thread Rolf Eike Beer
ioc-diag_trigger_mpi is an SL_WH_MPI_TRIGGERS_T struct. There is a cut and paste error here and SL_WH_EVENT_TRIGGERS_T is used instead of SL_WH_MPI_TRIGGERS_T. Since the SL_WH_EVENT_TRIGGERS_T is smaller than SL_WH_MPI_TRIGGERS_T, it means we only clear part of the buffer. Signed-off-by: Dan

Re: [patch] [SCSI] mpt3sas: cut and paste bug storing trigger mpi

2012-12-07 Thread Dan Carpenter
On Fri, Dec 07, 2012 at 09:41:56AM +0100, Rolf Eike Beer wrote: memset(ioc-diag_trigger_mpi, 0, -sizeof(struct SL_WH_EVENT_TRIGGERS_T)); +sizeof(struct SL_WH_MPI_TRIGGERS_T)); memcpy(ioc-diag_trigger_mpi, buf, sz); if (ioc-diag_trigger_mpi.ValidEntries

[patch] [SCSI] mpt3sas: cut and paste bug storing trigger mpi

2012-12-06 Thread Dan Carpenter
ioc->diag_trigger_mpi is an SL_WH_MPI_TRIGGERS_T struct. There is a cut and paste error here and SL_WH_EVENT_TRIGGERS_T is used instead of SL_WH_MPI_TRIGGERS_T. Since the SL_WH_EVENT_TRIGGERS_T is smaller than SL_WH_MPI_TRIGGERS_T, it means we only clear part of the buffer. Signed-off-by: Dan

[patch] [SCSI] mpt3sas: cut and paste bug storing trigger mpi

2012-12-06 Thread Dan Carpenter
ioc-diag_trigger_mpi is an SL_WH_MPI_TRIGGERS_T struct. There is a cut and paste error here and SL_WH_EVENT_TRIGGERS_T is used instead of SL_WH_MPI_TRIGGERS_T. Since the SL_WH_EVENT_TRIGGERS_T is smaller than SL_WH_MPI_TRIGGERS_T, it means we only clear part of the buffer. Signed-off-by: Dan