Re: [patch] build error: allnoconfig fails on mincore/swapper_space

2007-02-15 Thread Jeff Garzik
Linus Torvalds wrote: On Thu, 15 Feb 2007, Randy Dunlap wrote: so, are we going to get a revert of 42da9cbd3eedde33a42acc2cb06f454814cf5de0 ? Has that been requested? or are there other plans? It should be fixed now (I had patches from Nick, but got sidetracked by trying to fix metacity for

Re: [patch] build error: allnoconfig fails on mincore/swapper_space

2007-02-15 Thread Linus Torvalds
On Thu, 15 Feb 2007, Randy Dunlap wrote: > > so, are we going to get a revert of 42da9cbd3eedde33a42acc2cb06f454814cf5de0 ? > Has that been requested? or are there other plans? It should be fixed now (I had patches from Nick, but got sidetracked by trying to fix metacity for the gnome people)

Re: [patch] build error: allnoconfig fails on mincore/swapper_space

2007-02-15 Thread Randy Dunlap
On Wed, 14 Feb 2007 00:19:06 + (GMT) Hugh Dickins wrote: > On Tue, 13 Feb 2007, Randy Dunlap wrote: > > From: Randy Dunlap <[EMAIL PROTECTED]> > > > > Don't check for pte swap entries when CONFIG_SWAP=n. > > And save 'present' in the vec array. > > > > mm/built-in.o: In function `sys_mincore

Re: [patch] build error: allnoconfig fails on mincore/swapper_space

2007-02-14 Thread Christoph Lameter
On Wed, 14 Feb 2007, Nick Piggin wrote: > Can't you have migration without swap? Yes you can. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the

Re: [patch] build error: allnoconfig fails on mincore/swapper_space

2007-02-14 Thread Nick Piggin
Hugh Dickins wrote: On Wed, 14 Feb 2007, Nick Piggin wrote: Can't you have migration without swap? Yes: but then the only swap entry it can find (short of page table corruption, which isn't really the focus of mincore) is a migration entry, isn't it? Just doesn't seem logical to have CONFI

Re: [patch] build error: allnoconfig fails on mincore/swapper_space

2007-02-13 Thread Hugh Dickins
On Wed, 14 Feb 2007, Nick Piggin wrote: > > Can't you have migration without swap? Yes: but then the only swap entry it can find (short of page table corruption, which isn't really the focus of mincore) is a migration entry, isn't it? Hugh - To unsubscribe from this list: send the line "unsubscr

Re: [patch] build error: allnoconfig fails on mincore/swapper_space

2007-02-13 Thread Nick Piggin
Hugh Dickins wrote: On Tue, 13 Feb 2007, Randy Dunlap wrote: From: Randy Dunlap <[EMAIL PROTECTED]> Don't check for pte swap entries when CONFIG_SWAP=n. And save 'present' in the vec array. mm/built-in.o: In function `sys_mincore': (.text+0xe584): undefined reference to `swapper_space' Signe

Re: [patch] build error: allnoconfig fails on mincore/swapper_space

2007-02-13 Thread Hugh Dickins
On Tue, 13 Feb 2007, Randy Dunlap wrote: > From: Randy Dunlap <[EMAIL PROTECTED]> > > Don't check for pte swap entries when CONFIG_SWAP=n. > And save 'present' in the vec array. > > mm/built-in.o: In function `sys_mincore': > (.text+0xe584): undefined reference to `swapper_space' > > Signed-off-

Re: [patch] build error: allnoconfig fails on mincore/swapper_space

2007-02-13 Thread Randy Dunlap
> > > > oops. CONFIG_SWAP=n, I assume? > > Sorry for being so slow to respond on this. Yes, I'm inclined to > your ifdeffery fix - one can go cleverer, but I'd say it's the > appropriate fix now. > > But, please change your "present = 0;" to "present = 1;" - > if CONFIG_SWAP isn't on, it has

Re: [patch] build error: allnoconfig fails on mincore/swapper_space

2007-02-13 Thread Hugh Dickins
On Tue, 13 Feb 2007, Randy Dunlap wrote: > On Tue, 13 Feb 2007 13:48:53 +1100 Nick Piggin wrote: > > Andrew Morton wrote: > > >>On Mon, 12 Feb 2007 14:50:40 -0800 Randy Dunlap <[EMAIL PROTECTED]> wrote: > > >>2.6.20-git8 on x86_64: > > >> > > >> > > >> LD init/built-in.o > > >> LD .tmp_

[patch] build error: allnoconfig fails on mincore/swapper_space

2007-02-13 Thread Randy Dunlap
On Tue, 13 Feb 2007 13:48:53 +1100 Nick Piggin wrote: > Andrew Morton wrote: > >>On Mon, 12 Feb 2007 14:50:40 -0800 Randy Dunlap <[EMAIL PROTECTED]> wrote: > >>2.6.20-git8 on x86_64: > >> > >> > >> LD init/built-in.o > >> LD .tmp_vmlinux1 > >>mm/built-in.o: In function `sys_mincore': >