Re: [patch] net, 8139too.c: fix netpoll deadlock

2007-02-15 Thread Atsushi Nemoto
On Wed, 14 Feb 2007 11:30:25 +0900 (JST), Atsushi Nemoto <[EMAIL PROTECTED]> wrote: > > hm, this isnt really about NAPI polling, but about the > > netconsole/netpoll/netdump poll_controller() handler. > > > > with netconsole, printk can be called from IRQ context (and is > > frequently from

Re: [patch] net, 8139too.c: fix netpoll deadlock

2007-02-15 Thread Atsushi Nemoto
On Wed, 14 Feb 2007 11:30:25 +0900 (JST), Atsushi Nemoto [EMAIL PROTECTED] wrote: hm, this isnt really about NAPI polling, but about the netconsole/netpoll/netdump poll_controller() handler. with netconsole, printk can be called from IRQ context (and is frequently from IRQ context

Re: [patch] net, 8139too.c: fix netpoll deadlock

2007-02-13 Thread Atsushi Nemoto
Let me resume two months old topic... On Wed, 13 Dec 2006 02:12:31 +0100, Ingo Molnar <[EMAIL PROTECTED]> wrote: > > I have lived with the "NAPI ->poll() handler runs in BH irq enabled > > context" rule for years. Is it definitely false/dead ? > > > > If so at least 8139cp needs the same fix. >

Re: [patch] net, 8139too.c: fix netpoll deadlock

2007-02-13 Thread Atsushi Nemoto
Let me resume two months old topic... On Wed, 13 Dec 2006 02:12:31 +0100, Ingo Molnar [EMAIL PROTECTED] wrote: I have lived with the NAPI -poll() handler runs in BH irq enabled context rule for years. Is it definitely false/dead ? If so at least 8139cp needs the same fix. hm, this

Re: [patch] net, 8139too.c: fix netpoll deadlock

2006-12-12 Thread Ingo Molnar
* Francois Romieu <[EMAIL PROTECTED]> wrote: > > (I'll queue it, if Linus doesn't pick it up; please CC me in the > > future) > > I have lived with the "NAPI ->poll() handler runs in BH irq enabled > context" rule for years. Is it definitely false/dead ? > > If so at least 8139cp needs the

Re: [patch] net, 8139too.c: fix netpoll deadlock

2006-12-12 Thread Francois Romieu
Jeff Garzik <[EMAIL PROTECTED]> : > Ingo Molnar wrote: [...] > >fix deadlock in the 8139too driver: poll handlers should never forcibly > >enable local interrupts, because they might be used by netpoll/printk > >from IRQ context. > > ACK > > (I'll queue it, if Linus doesn't pick it up; please

Re: [patch] net, 8139too.c: fix netpoll deadlock

2006-12-12 Thread Jeff Garzik
Ingo Molnar wrote: Subject: [patch] net, 8139too.c: fix netpoll deadlock From: Ingo Molnar <[EMAIL PROTECTED]> fix deadlock in the 8139too driver: poll handlers should never forcibly enable local interrupts, because they might be used by netpoll/printk from IRQ context. ACK (I'll

[patch] net, 8139too.c: fix netpoll deadlock

2006-12-12 Thread Ingo Molnar
Subject: [patch] net, 8139too.c: fix netpoll deadlock From: Ingo Molnar <[EMAIL PROTECTED]> fix deadlock in the 8139too driver: poll handlers should never forcibly enable local interrupts, because they might be used by netpoll/printk from IRQ context. =

[patch] net, 8139too.c: fix netpoll deadlock

2006-12-12 Thread Ingo Molnar
Subject: [patch] net, 8139too.c: fix netpoll deadlock From: Ingo Molnar [EMAIL PROTECTED] fix deadlock in the 8139too driver: poll handlers should never forcibly enable local interrupts, because they might be used by netpoll/printk from IRQ context. = [ INFO

Re: [patch] net, 8139too.c: fix netpoll deadlock

2006-12-12 Thread Jeff Garzik
Ingo Molnar wrote: Subject: [patch] net, 8139too.c: fix netpoll deadlock From: Ingo Molnar [EMAIL PROTECTED] fix deadlock in the 8139too driver: poll handlers should never forcibly enable local interrupts, because they might be used by netpoll/printk from IRQ context. ACK (I'll queue

Re: [patch] net, 8139too.c: fix netpoll deadlock

2006-12-12 Thread Francois Romieu
Jeff Garzik [EMAIL PROTECTED] : Ingo Molnar wrote: [...] fix deadlock in the 8139too driver: poll handlers should never forcibly enable local interrupts, because they might be used by netpoll/printk from IRQ context. ACK (I'll queue it, if Linus doesn't pick it up; please CC me in the

Re: [patch] net, 8139too.c: fix netpoll deadlock

2006-12-12 Thread Ingo Molnar
* Francois Romieu [EMAIL PROTECTED] wrote: (I'll queue it, if Linus doesn't pick it up; please CC me in the future) I have lived with the NAPI -poll() handler runs in BH irq enabled context rule for years. Is it definitely false/dead ? If so at least 8139cp needs the same fix. hm,