Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread H. Peter Anvin
On 02/19/2013 02:11 PM, Cyrill Gorcunov wrote: On Tue, Feb 19, 2013 at 02:00:35PM -0800, Andrew Morton wrote: I think this syscall is usefull even without c/r stuff. That's why I made it with separate config option. hm, OK. But the patch also permits CONFIG_CHECKPOINT_RESTORE=y,

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread Cyrill Gorcunov
On Wed, Feb 20, 2013 at 02:15:48AM +0400, Cyrill Gorcunov wrote: > > Here is update. Peter, does it look good for you too? Sigh, -ENOTQUILTREFRESHED, sorry --- From: Cyrill Gorcunov Subject: kcmp: Make it to depend on CHECKPOINT_RESTORE Since kcmp syscall has been implemented (initially on x86

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread Cyrill Gorcunov
On Wed, Feb 20, 2013 at 02:11:46AM +0400, Cyrill Gorcunov wrote: > On Tue, Feb 19, 2013 at 02:00:35PM -0800, Andrew Morton wrote: > > > > > > I think this syscall is usefull even without c/r stuff. > > > That's why I made it with separate config option. > > > > hm, OK. > > > > But the patch

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread Cyrill Gorcunov
On Tue, Feb 19, 2013 at 02:00:35PM -0800, Andrew Morton wrote: > > > > I think this syscall is usefull even without c/r stuff. > > That's why I made it with separate config option. > > hm, OK. > > But the patch also permits CONFIG_CHECKPOINT_RESTORE=y, CONFIG_KCMP=n > which surely isn't

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread Cyrill Gorcunov
On Tue, Feb 19, 2013 at 01:48:27PM -0800, H. Peter Anvin wrote: > > > >This permits people to select kcmp with CONFIG_CHECKPOINT_RESTORE=n. > >Is there any point in doing that? > > > >What would be wrong with just doing > > > > obj-$(CONFIG_CHECKPOINT_RESTORE) += kcmp.o > > > > The real

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread Andrew Morton
On Wed, 20 Feb 2013 01:54:32 +0400 Cyrill Gorcunov wrote: > On Tue, Feb 19, 2013 at 01:42:56PM -0800, Andrew Morton wrote: > > > Index: linux-2.6.git/kernel/Makefile > > > === > > > --- linux-2.6.git.orig/kernel/Makefile > > > +++

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread Cyrill Gorcunov
On Tue, Feb 19, 2013 at 01:42:56PM -0800, Andrew Morton wrote: > > Index: linux-2.6.git/kernel/Makefile > > === > > --- linux-2.6.git.orig/kernel/Makefile > > +++ linux-2.6.git/kernel/Makefile > > @@ -25,9 +25,7 @@ endif > > obj-y +=

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread H. Peter Anvin
On 02/19/2013 01:42 PM, Andrew Morton wrote: Index: linux-2.6.git/kernel/Makefile === --- linux-2.6.git.orig/kernel/Makefile +++ linux-2.6.git/kernel/Makefile @@ -25,9 +25,7 @@ endif obj-y += sched/ obj-y += power/ -ifeq

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread Andrew Morton
On Tue, 19 Feb 2013 22:28:38 +0400 Cyrill Gorcunov wrote: > Since kcmp syscall has been implemented (initially on > x86 architecture) a number of other archs wire it up > as well: xtensa, sparc, sh, s390, mips, microblaze, > m68k (not taking into account those who uses > for syscall numbers >

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread Cyrill Gorcunov
On Tue, Feb 19, 2013 at 09:53:47AM -0800, H. Peter Anvin wrote: > On 02/19/2013 01:31 AM, Cyrill Gorcunov wrote: > >+ > >+ If unsure, say N. > >+ > > Wrong advice. In this particular case, Y is the safe alternative. --- From: Cyrill Gorcunov Subject: kcmp: Make it to depend on CONFIG_KCMP

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread H. Peter Anvin
On 02/19/2013 01:31 AM, Cyrill Gorcunov wrote: + + If unsure, say N. + Wrong advice. In this particular case, Y is the safe alternative. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. -- To unsubscribe from this

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread Cyrill Gorcunov
On Tue, Feb 19, 2013 at 10:22:21AM +0100, Michal Marek wrote: > On 19.2.2013 07:48, Cyrill Gorcunov wrote: > > --- linux-2.6.git.orig/init/Kconfig > > +++ linux-2.6.git/init/Kconfig > > @@ -279,6 +279,15 @@ config FHANDLE > > get renamed. Enables open_by_handle_at(2) and name_to_handle_at(2)

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread Michal Marek
On 19.2.2013 07:48, Cyrill Gorcunov wrote: > --- linux-2.6.git.orig/init/Kconfig > +++ linux-2.6.git/init/Kconfig > @@ -279,6 +279,15 @@ config FHANDLE > get renamed. Enables open_by_handle_at(2) and name_to_handle_at(2) > syscalls. > > +config KCMP > + bool "kcmp syscall" >

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread KOSAKI Motohiro
(2/19/13 1:48 AM), Cyrill Gorcunov wrote: > Since kcmp syscall has been implemented (initially on > x86 architecture) a number of other archs wire it up > as well: xtensa, sparc, sh, s390, mips, microblaze, > m68k (not taking into account those who uses > for syscall numbers > definitions). > >

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread KOSAKI Motohiro
(2/19/13 1:48 AM), Cyrill Gorcunov wrote: Since kcmp syscall has been implemented (initially on x86 architecture) a number of other archs wire it up as well: xtensa, sparc, sh, s390, mips, microblaze, m68k (not taking into account those who uses asm-generic/unistd.h for syscall numbers

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread Michal Marek
On 19.2.2013 07:48, Cyrill Gorcunov wrote: --- linux-2.6.git.orig/init/Kconfig +++ linux-2.6.git/init/Kconfig @@ -279,6 +279,15 @@ config FHANDLE get renamed. Enables open_by_handle_at(2) and name_to_handle_at(2) syscalls. +config KCMP + bool kcmp syscall +

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread Cyrill Gorcunov
On Tue, Feb 19, 2013 at 10:22:21AM +0100, Michal Marek wrote: On 19.2.2013 07:48, Cyrill Gorcunov wrote: --- linux-2.6.git.orig/init/Kconfig +++ linux-2.6.git/init/Kconfig @@ -279,6 +279,15 @@ config FHANDLE get renamed. Enables open_by_handle_at(2) and name_to_handle_at(2)

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread H. Peter Anvin
On 02/19/2013 01:31 AM, Cyrill Gorcunov wrote: + + If unsure, say N. + Wrong advice. In this particular case, Y is the safe alternative. -hpa -- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf. -- To unsubscribe from this

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread Cyrill Gorcunov
On Tue, Feb 19, 2013 at 09:53:47AM -0800, H. Peter Anvin wrote: On 02/19/2013 01:31 AM, Cyrill Gorcunov wrote: + + If unsure, say N. + Wrong advice. In this particular case, Y is the safe alternative. --- From: Cyrill Gorcunov gorcu...@openvz.org Subject: kcmp: Make it to depend on

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread Andrew Morton
On Tue, 19 Feb 2013 22:28:38 +0400 Cyrill Gorcunov gorcu...@openvz.org wrote: Since kcmp syscall has been implemented (initially on x86 architecture) a number of other archs wire it up as well: xtensa, sparc, sh, s390, mips, microblaze, m68k (not taking into account those who uses

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread H. Peter Anvin
On 02/19/2013 01:42 PM, Andrew Morton wrote: Index: linux-2.6.git/kernel/Makefile === --- linux-2.6.git.orig/kernel/Makefile +++ linux-2.6.git/kernel/Makefile @@ -25,9 +25,7 @@ endif obj-y += sched/ obj-y += power/ -ifeq

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread Cyrill Gorcunov
On Tue, Feb 19, 2013 at 01:42:56PM -0800, Andrew Morton wrote: Index: linux-2.6.git/kernel/Makefile === --- linux-2.6.git.orig/kernel/Makefile +++ linux-2.6.git/kernel/Makefile @@ -25,9 +25,7 @@ endif obj-y += sched/

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread Andrew Morton
On Wed, 20 Feb 2013 01:54:32 +0400 Cyrill Gorcunov gorcu...@openvz.org wrote: On Tue, Feb 19, 2013 at 01:42:56PM -0800, Andrew Morton wrote: Index: linux-2.6.git/kernel/Makefile === --- linux-2.6.git.orig/kernel/Makefile

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread Cyrill Gorcunov
On Tue, Feb 19, 2013 at 01:48:27PM -0800, H. Peter Anvin wrote: This permits people to select kcmp with CONFIG_CHECKPOINT_RESTORE=n. Is there any point in doing that? What would be wrong with just doing obj-$(CONFIG_CHECKPOINT_RESTORE) += kcmp.o The real question is if there

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread Cyrill Gorcunov
On Tue, Feb 19, 2013 at 02:00:35PM -0800, Andrew Morton wrote: I think this syscall is usefull even without c/r stuff. That's why I made it with separate config option. hm, OK. But the patch also permits CONFIG_CHECKPOINT_RESTORE=y, CONFIG_KCMP=n which surely isn't something which

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread Cyrill Gorcunov
On Wed, Feb 20, 2013 at 02:11:46AM +0400, Cyrill Gorcunov wrote: On Tue, Feb 19, 2013 at 02:00:35PM -0800, Andrew Morton wrote: I think this syscall is usefull even without c/r stuff. That's why I made it with separate config option. hm, OK. But the patch also permits

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread Cyrill Gorcunov
On Wed, Feb 20, 2013 at 02:15:48AM +0400, Cyrill Gorcunov wrote: Here is update. Peter, does it look good for you too? Sigh, -ENOTQUILTREFRESHED, sorry --- From: Cyrill Gorcunov gorcu...@openvz.org Subject: kcmp: Make it to depend on CHECKPOINT_RESTORE Since kcmp syscall has been implemented

Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-19 Thread H. Peter Anvin
On 02/19/2013 02:11 PM, Cyrill Gorcunov wrote: On Tue, Feb 19, 2013 at 02:00:35PM -0800, Andrew Morton wrote: I think this syscall is usefull even without c/r stuff. That's why I made it with separate config option. hm, OK. But the patch also permits CONFIG_CHECKPOINT_RESTORE=y,

[patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-18 Thread Cyrill Gorcunov
Since kcmp syscall has been implemented (initially on x86 architecture) a number of other archs wire it up as well: xtensa, sparc, sh, s390, mips, microblaze, m68k (not taking into account those who uses for syscall numbers definitions). But the Makefile, which turns kcmp.o generation on still

[patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

2013-02-18 Thread Cyrill Gorcunov
Since kcmp syscall has been implemented (initially on x86 architecture) a number of other archs wire it up as well: xtensa, sparc, sh, s390, mips, microblaze, m68k (not taking into account those who uses asm-generic/unistd.h for syscall numbers definitions). But the Makefile, which turns kcmp.o