Re: [patch 18/19] gpio/msm-v2: Avoid redundant lookup of irq_data

2015-07-14 Thread Thomas Gleixner
On Tue, 14 Jul 2015, Ilia Mirkin wrote: > > static void msm_gpio_irq_ack(struct irq_data *d) > > { > > - int gpio = msm_irq_to_gpio(_gpio.gpio_chip, d->irq); > > + int gpio = d->hw_irq; > > Does this build? It was hwirq above, not hw_irq. Indeed. Updated patch below. Thanks,

Re: [patch 18/19] gpio/msm-v2: Avoid redundant lookup of irq_data

2015-07-14 Thread Thomas Gleixner
On Tue, 14 Jul 2015, Ilia Mirkin wrote: static void msm_gpio_irq_ack(struct irq_data *d) { - int gpio = msm_irq_to_gpio(msm_gpio.gpio_chip, d-irq); + int gpio = d-hw_irq; Does this build? It was hwirq above, not hw_irq. Indeed. Updated patch below. Thanks, tglx

Re: [patch 18/19] gpio/msm-v2: Avoid redundant lookup of irq_data

2015-07-13 Thread Jiang Liu
On 2015/7/14 13:28, Ilia Mirkin wrote: > > On Jul 13, 2015 4:42 PM, "Thomas Gleixner" > wrote: >> >> It's pretty silly to do >> >> irq_data *d = irq_get_irq_data(irq_data->irq); >> >> because that results in d = irq_data, but goes through a lookup of the >>

[patch 18/19] gpio/msm-v2: Avoid redundant lookup of irq_data

2015-07-13 Thread Thomas Gleixner
It's pretty silly to do irq_data *d = irq_get_irq_data(irq_data->irq); because that results in d = irq_data, but goes through a lookup of the irq_data. Use irq_data directly. Signed-off-by: Thomas Gleixner Cc: Linus Walleij Cc: Alexandre Courbot Cc: Jiang Liu Cc:

Re: [patch 18/19] gpio/msm-v2: Avoid redundant lookup of irq_data

2015-07-13 Thread Jiang Liu
On 2015/7/14 13:28, Ilia Mirkin wrote: On Jul 13, 2015 4:42 PM, Thomas Gleixner t...@linutronix.de mailto:t...@linutronix.de wrote: It's pretty silly to do irq_data *d = irq_get_irq_data(irq_data-irq); because that results in d = irq_data, but goes through a lookup of the irq_data.

[patch 18/19] gpio/msm-v2: Avoid redundant lookup of irq_data

2015-07-13 Thread Thomas Gleixner
It's pretty silly to do irq_data *d = irq_get_irq_data(irq_data-irq); because that results in d = irq_data, but goes through a lookup of the irq_data. Use irq_data directly. Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Linus Walleij linus.wall...@linaro.org Cc: Alexandre Courbot