Re: [patch 2/2] ALSA: fireworks: small leak on error path

2014-05-29 Thread Takashi Iwai
At Wed, 28 May 2014 19:42:46 +0300, Dan Carpenter wrote: > > There was a typo here so we return directly instead of freeing "hwinfo". > > Signed-off-by: Dan Carpenter Applied, thanks. Takashi > > diff --git a/sound/firewire/fireworks/fireworks.c > b/sound/firewire/fireworks/fireworks.c >

Re: [patch 2/2] ALSA: fireworks: small leak on error path

2014-05-29 Thread Takashi Iwai
At Wed, 28 May 2014 19:42:46 +0300, Dan Carpenter wrote: There was a typo here so we return directly instead of freeing hwinfo. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Applied, thanks. Takashi diff --git a/sound/firewire/fireworks/fireworks.c

Re: [alsa-devel] [patch 2/2] ALSA: fireworks: small leak on error path

2014-05-28 Thread Takashi Sakamoto
(May 29 2014 01:42), Dan Carpenter wrote: > There was a typo here so we return directly instead of freeing "hwinfo". > > Signed-off-by: Dan Carpenter Reviewd-by: Takashi Sakamoto Tested-by: Takashi Sakamoto > diff --git a/sound/firewire/fireworks/fireworks.c >

[patch 2/2] ALSA: fireworks: small leak on error path

2014-05-28 Thread Dan Carpenter
There was a typo here so we return directly instead of freeing "hwinfo". Signed-off-by: Dan Carpenter diff --git a/sound/firewire/fireworks/fireworks.c b/sound/firewire/fireworks/fireworks.c index 8e856cc..996fdc4 100644 --- a/sound/firewire/fireworks/fireworks.c +++

Re: [alsa-devel] [patch 2/2] ALSA: fireworks: small leak on error path

2014-05-28 Thread Takashi Sakamoto
(May 29 2014 01:42), Dan Carpenter wrote: There was a typo here so we return directly instead of freeing hwinfo. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Reviewd-by: Takashi Sakamoto o-taka...@sakamocchi.jp Tested-by: Takashi Sakamoto o-taka...@sakamocchi.jp diff --git

[patch 2/2] ALSA: fireworks: small leak on error path

2014-05-28 Thread Dan Carpenter
There was a typo here so we return directly instead of freeing hwinfo. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/sound/firewire/fireworks/fireworks.c b/sound/firewire/fireworks/fireworks.c index 8e856cc..996fdc4 100644 --- a/sound/firewire/fireworks/fireworks.c +++