Re: [patch 3/4] ipmi: add pci remove handling

2007-02-16 Thread Corey Minyard
On Fri, Feb 16, 2007 at 02:16:17PM +0100, Rolf Eike Beer wrote: > > Please use pci_{set,get}_drvdata() to access this field. > > Greetings, > > Eike Yes, much better. Thanks. One more time... Add pci_remove handling to the driver, so it will clean up if the device is hot-removed.

Re: [patch 3/4] ipmi: add pci remove handling

2007-02-16 Thread Rolf Eike Beer
Am Donnerstag, 15. Februar 2007 schrieb Corey Minyard: > On Thu, Feb 15, 2007 at 02:27:45AM -0800, Andrew Morton wrote: > > Judging from the patch headers you were working against 2.6.19, which is > > most optimistic. Please always prepare and test patches against the > > latest kernel. > > Well,

Re: [patch 3/4] ipmi: add pci remove handling

2007-02-16 Thread Rolf Eike Beer
Am Donnerstag, 15. Februar 2007 schrieb Corey Minyard: On Thu, Feb 15, 2007 at 02:27:45AM -0800, Andrew Morton wrote: Judging from the patch headers you were working against 2.6.19, which is most optimistic. Please always prepare and test patches against the latest kernel. Well, I had it

Re: [patch 3/4] ipmi: add pci remove handling

2007-02-16 Thread Corey Minyard
On Fri, Feb 16, 2007 at 02:16:17PM +0100, Rolf Eike Beer wrote: Please use pci_{set,get}_drvdata() to access this field. Greetings, Eike Yes, much better. Thanks. One more time... Add pci_remove handling to the driver, so it will clean up if the device is hot-removed. Signed-off-by:

Re: [patch 3/4] ipmi: add pci remove handling

2007-02-15 Thread Corey Minyard
On Thu, Feb 15, 2007 at 02:27:45AM -0800, Andrew Morton wrote: > > Judging from the patch headers you were working against 2.6.19, which is > most optimistic. Please always prepare and test patches against the > latest kernel. Well, I had it applied against a 2.6.20 kernel, but I messed up the

Re: [patch 3/4] ipmi: add pci remove handling

2007-02-15 Thread Andrew Morton
On Wed, 14 Feb 2007 14:06:24 -0600 Corey Minyard <[EMAIL PROTECTED]> wrote: > Add pci_remove handling to the driver, so it will clean up if > the device is hot-removed. > > Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> > > Index: linux-2.6.19/drivers/char/ipmi/ipmi_si_intf.c >

Re: [patch 3/4] ipmi: add pci remove handling

2007-02-15 Thread Andrew Morton
On Wed, 14 Feb 2007 14:06:24 -0600 Corey Minyard [EMAIL PROTECTED] wrote: Add pci_remove handling to the driver, so it will clean up if the device is hot-removed. Signed-off-by: Corey Minyard [EMAIL PROTECTED] Index: linux-2.6.19/drivers/char/ipmi/ipmi_si_intf.c

Re: [patch 3/4] ipmi: add pci remove handling

2007-02-15 Thread Corey Minyard
On Thu, Feb 15, 2007 at 02:27:45AM -0800, Andrew Morton wrote: Judging from the patch headers you were working against 2.6.19, which is most optimistic. Please always prepare and test patches against the latest kernel. Well, I had it applied against a 2.6.20 kernel, but I messed up the

[patch 3/4] ipmi: add pci remove handling

2007-02-14 Thread Corey Minyard
Add pci_remove handling to the driver, so it will clean up if the device is hot-removed. Signed-off-by: Corey Minyard <[EMAIL PROTECTED]> Index: linux-2.6.19/drivers/char/ipmi/ipmi_si_intf.c === ---

[patch 3/4] ipmi: add pci remove handling

2007-02-14 Thread Corey Minyard
Add pci_remove handling to the driver, so it will clean up if the device is hot-removed. Signed-off-by: Corey Minyard [EMAIL PROTECTED] Index: linux-2.6.19/drivers/char/ipmi/ipmi_si_intf.c === ---