Re: [patch 5/8] ntp: Make the RTC synchronization more reliable

2021-01-11 Thread Geert Uytterhoeven
Hi Thomas, On Mon, Jan 11, 2021 at 11:12 AM Thomas Gleixner wrote: > On Tue, Dec 29 2020 at 20:41, Geert Uytterhoeven wrote: > >> Reported-by: Miroslav Lichvar > >> Signed-off-by: Thomas Gleixner > > > > Thanks for your patch, which is now commit c9e6189fb03123a7 ("ntp: Make > > the RTC

Re: [patch 5/8] ntp: Make the RTC synchronization more reliable

2021-01-11 Thread Thomas Gleixner
On Tue, Dec 29 2020 at 20:41, Geert Uytterhoeven wrote: > Hi Thomas, >> Reported-by: Miroslav Lichvar >> Signed-off-by: Thomas Gleixner > > Thanks for your patch, which is now commit c9e6189fb03123a7 ("ntp: Make > the RTC synchronization more reliable"). > > Since this commit, the I2C RTC on the

Re: [patch 5/8] ntp: Make the RTC synchronization more reliable

2020-12-29 Thread Geert Uytterhoeven
Hi Thomas, On Sun, Dec 6, 2020 at 11:10 PM Thomas Gleixner wrote: > Miroslav reported that the periodic RTC synchronization in the NTP code > fails more often than not to hit the specified update window. > > The reason is that the code uses delayed_work to schedule the update which > needs to be

Re: [patch 5/8] ntp: Make the RTC synchronization more reliable

2020-12-07 Thread Jason Gunthorpe
On Sun, Dec 06, 2020 at 10:46:18PM +0100, Thomas Gleixner wrote: > Miroslav reported that the periodic RTC synchronization in the NTP code > fails more often than not to hit the specified update window. > > The reason is that the code uses delayed_work to schedule the update which > needs to be

Re: [patch 5/8] ntp: Make the RTC synchronization more reliable

2020-12-07 Thread Miroslav Lichvar
On Sun, Dec 06, 2020 at 10:46:18PM +0100, Thomas Gleixner wrote: > Switch it to an hrtimer instead which schedules the actual update work. The > hrtimer will expire precisely (max 1 jiffie delay when high resolution > timers are not available). The actual scheduling delay of the work is the > same

[patch 5/8] ntp: Make the RTC synchronization more reliable

2020-12-06 Thread Thomas Gleixner
Miroslav reported that the periodic RTC synchronization in the NTP code fails more often than not to hit the specified update window. The reason is that the code uses delayed_work to schedule the update which needs to be in thread context as the underlying RTC might be connected via a slow bus,